💬 maflcko commented on pull request "doc: Amend notes on benchmarking":
(https://github.com/bitcoin/bitcoin/pull/31690#discussion_r1922375792)
That is due to `__linux__` not being set on macOS, so I'll just drop this. It can be left as-is.

💬 l0rinc commented on pull request "doc: Amend notes on benchmarking":
(https://github.com/bitcoin/bitcoin/pull/31690#discussion_r1922378569)
> That is due to __linux__ not being set on macOS

Thanks for clarifying

> so I'll just drop this

I think it did make sense to replace the base58 examples with more representative ones

💬 maflcko commented on pull request "kernel: Move block tree db open to block manager":
(https://github.com/bitcoin/bitcoin/pull/30965#discussion_r1922387437)
Forgot to drop the casts in the rebase?

💬 maflcko commented on pull request "doc: Amend notes on benchmarking":
(https://github.com/bitcoin/bitcoin/pull/31690#discussion_r1922387509)
This is just for illustration of the output format, so anything should be fine.

💬 TheCharlatan commented on pull request "kernel: Move block tree db open to block manager":
(https://github.com/bitcoin/bitcoin/pull/30965#discussion_r1922402772)
yes -_-

👍 brunoerg approved a pull request: "doc: Amend notes on benchmarking"
(https://github.com/bitcoin/bitcoin/pull/31690#pullrequestreview-2562393804)
code review ACK 2db6923332c7daa20d250cc5aa6bde080a7d0caf

💬 l0rinc commented on pull request "doc: Amend notes on benchmarking":
(https://github.com/bitcoin/bitcoin/pull/31690#discussion_r1922409530)
I've mentioned this since it confused me at the beginning, seeing base58 benchmarks as examples - which is why I worked on optimizing it at first.

💬 l0rinc commented on pull request "doc: Amend notes on benchmarking":
(https://github.com/bitcoin/bitcoin/pull/31690#issuecomment-2602439488)
ACK 2db6923332c7daa20d250cc5aa6bde080a7d0caf

📝 vasild opened a pull request: "util: fix compiler warning about deprecated space before _MiB"
(https://github.com/bitcoin/bitcoin/pull/31691)
```
src/util/byte_units.h:13:29: error: identifier '_MiB' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
13 | constexpr size_t operator"" _MiB(unsigned long long mebibytes)
| ~~~~~~~~~~~^~~~
| operator""_MiB
1 error generated.
```

Clang 20.0.0

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement m
...

💬 vasild commented on pull request "kernel: Move kernel-related cache constants to kernel cache":
(https://github.com/bitcoin/bitcoin/pull/31483#discussion_r1922435758)
```
src/util/byte_units.h:13:29: error: identifier '_MiB' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
13 | constexpr size_t operator"" _MiB(unsigned long long mebibytes)
| ~~~~~~~~~~~^~~~
| operator""_MiB
1 error generated.
```

clang 20.0.0

Fixed in https://github.com/bitcoin/bitcoin/pull/31691

👍 TheCharlatan approved a pull request: "util: fix compiler warning about deprecated space before _MiB"
(https://github.com/bitcoin/bitcoin/pull/31691#pullrequestreview-2562454081)
ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3

💬 willcl-ark commented on pull request "util: detect and warn when using exFAT on MacOS":
(https://github.com/bitcoin/bitcoin/pull/31453#issuecomment-2602491201)
df1ba101419729aafa382d970ee605e2a6273e26 squashes the commits together, and also removes the duplicate warning messages, instead printing a single warning with a list of violating directories, e.g. going from:

```
Warning: Specified data directory "/Volumes/sandisk1/signet" is exFAT which is known to have intermittent corruption problems on MacOS. See https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#filesystem-recommendations for more information.
Warning: Specified blocks direct
...

💬 TheCharlatan commented on pull request "kernel: Move block tree db open to block manager":
(https://github.com/bitcoin/bitcoin/pull/30965#issuecomment-2602500903)
Updated 7f484b319bdc9e646e270b6d6d9a1c7e52296dc0 -> f3cfdf2b511776211a0399510ced735e556d510d ([blockmanDB_8](https://github.com/TheCharlatan/bitcoin/tree/blockmanDB_8) -> [blockmanDB_9](https://github.com/TheCharlatan/bitcoin/tree/blockmanDB_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/blockmanDB_8..blockmanDB_9))

* Drop `static_casts` as pointed out by @maflcko's [comment](https://github.com/bitcoin/bitcoin/pull/30965#discussion_r1922387437).

🚀 fanquake merged a pull request: "depends: Qt 5.15.16"
(https://github.com/bitcoin/bitcoin/pull/30774)

💬 willcl-ark commented on pull request "ci: optionally use local docker build cache":
(https://github.com/bitcoin/bitcoin/pull/31545#issuecomment-2602513967)
Concept ACK.

Rather than removing the previous local cache and replacing with the newly-created cache, would it make sense to use dockers build cache pruning mechanism, [`docker builder prune`](https://docs.docker.com/reference/cli/docker/builder/prune/), where we can specify removing either objects older than `x`, or to a certain storage (size) requirement?

This way it seems like we could always append to the cache with `--cache-to` and prune to size or age as makes sense for the runner.

💬 maflcko commented on pull request "util: fix compiler warning about deprecated space before _MiB":
(https://github.com/bitcoin/bitcoin/pull/31691#issuecomment-2602517116)
lgtm ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3

There should be an rc1 in two weeks, so the CI could be bumped to that to avoid issues in the future.

🚀 fanquake merged a pull request: "util: fix compiler warning about deprecated space before _MiB"
(https://github.com/bitcoin/bitcoin/pull/31691)

🤔 furszy reviewed a pull request: "doc: Amend notes on benchmarking"
(https://github.com/bitcoin/bitcoin/pull/31690#pullrequestreview-2562545874)
ACK 2db6923332c7daa20d250cc5aa6bde080a7d0caf

💬 kevkevinpal commented on pull request "descriptors: Try pubkeys of both evenness when retrieving the private keys for an xonly pubkey in a descriptor":
(https://github.com/bitcoin/bitcoin/pull/31590#issuecomment-2602589312)
Concept and Code review ACK [c0045e6](https://github.com/bitcoin/bitcoin/pull/31590/commits/c0045e6cee06bc0029fb79b5a531aa1f2b817424)

fixes issue and looks good to me!

🤔 hebasto reviewed a pull request: "util: fix compiler warning about deprecated space before _MiB"
(https://github.com/bitcoin/bitcoin/pull/31691#pullrequestreview-2562559589)
Post-merge ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3.