⚠️ Laughter79 opened an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)
Check out this post on Nextdoor: https://nextdoor.com/p/wLC4RXZ93L9X?utm_source=share&slp=&share_platform=1&extras=OTA2MTI2MzM%3D&utm_campaign=1737066747996

✅ pinheadmz closed an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)

💬 Laughter79 commented on issue "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor":
(https://github.com/bitcoin/bitcoin/issues/31677#issuecomment-2597042890)
buymeacoffee.com/haleyslaug3

:lock: fanquake locked an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)

💬 luke-jr commented on pull request "optimization: increase default LevelDB write batch size to 64 MiB":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-2597073268)
I think those graphs need to be on height rather than seconds. The larger dbbatchsize making it faster means it gets further in the chain, leading to the higher max at the end...

I would expect both lines to be essentially overlapping except during flushes.

💬 sipa commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2597143537)
Works out-of-the box on an Archer AX3000 Pro router/modem (with NAT-PMP fallback):

```
2025-01-16T21:58:50.803107Z [net] portmap: gateway [IPv4]: 192.168.0.1
2025-01-16T21:58:50.804793Z [net] pcp: Requesting port mapping for addr 0.0.0.0 port 8333 from gateway 192.168.0.1
2025-01-16T21:58:50.804834Z [net] pcp: Internal address after connect: 192.168.0.150
2025-01-16T21:58:50.805718Z [net] pcp: Received response of 8 bytes: (scrubbed)
2025-01-16T21:58:50.805736Z [net] portmap: Got unsupported PC
...

💬 theStack commented on pull request "test: p2p: fix sending of manual INVs in tx download test":
(https://github.com/bitcoin/bitcoin/pull/31658#issuecomment-2597168018)
> > My understanding is that a change like this would make the test fail on master, and pass with the patch in the pull request as it is now. But I haven't tried it, so I may be missing something?
>
> I suspect that theStack was looking for something that would prevent the underlying issue (sending wrong inv type) in general:
>
> For example we could add an `assert` in `send_message` of `p2p.py` if we try to send an `Inv` of type `MSG_TX` and have `self.wtxidrelay` set (and vice versa). Bu
...

💬 whitslack commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2597171643)
@Sjors: You want to know who wants this? I've been wanting to use Bitcoin Core to decode and manipulate the PSBTs that Core Lightning stores in its database, but it only works for the older, first-gen PSBTs. Core Lightning moved on to PSBTv2 some time ago, so now all the newer PSBTs fail to parse in Bitcoin Core. I've been having to hack together various half-baked tools I've found around the Internet, but it would be so good if Bitcoin Core would be upgraded to the current spec.

👍 theStack approved a pull request: "[test] fix p2p_orphan_handling.py empty orphanage check"
(https://github.com/bitcoin/bitcoin/pull/31675#pullrequestreview-2557742334)
ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec

💬 instagibbs commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2597189917)
@whitslack yes I authored the migration, and v2<->v0 roundtripping is supported in libwally as well. Would be nice to move the industry a bit closer to making v2 the defacto default.

💬 davidgumberg commented on pull request "depends: Use base system's `sha256sum` utility on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/31626#issuecomment-2597211469)
Tested depends build on a fresh BSD 14.2 install[^1], `sha256sum` is available and `shasum` is not.

```console
root@freebsd:~ # freebsd-version
14.2-RELEASE
root@freebsd:~ # shasum
-sh: shasum: not found
root@freebsd:~ # sha256sum --version
sha256sum (FreeBSD) 14.2
```

<details> <summary> Full build log</summary>

```console
root@freebsd:~ # fetch https://github.com/bitcoin/bitcoin/archive/refs/heads/master.zip
root@freebsd:~ # sha256sum master.zip
30cadd9f1293505f4e70173d9d1e
...

💬 davidgumberg commented on pull request "depends: Use base system's `sha256sum` utility on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/31626#discussion_r1919427041)
```suggestion
build_freebsd_DOWNLOAD = fetch --timeout 180 --retry -o
```

related but probably out-of-scope: freebsd's `fetch` utility could be used to also drop the curl dependency, there is a regression since it is unable to limit number of retries([16-year old patch awaits feedback](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=131427)), and to set a handshake timeout, but these can be approximated with a single connection timeout

💬 davidgumberg commented on pull request "init: Lock blocksdir in addition to datadir":
(https://github.com/bitcoin/bitcoin/pull/31674#issuecomment-2597266508)
Concept ACK

💬 davidgumberg commented on pull request "build: Make config warnings fatal if -DWERROR=ON":
(https://github.com/bitcoin/bitcoin/pull/31665#discussion_r1919456572)
Thanks, fixed.

👍 tdb3 approved a pull request: "rpc: add gettarget , target getmininginfo field and show next block info"
(https://github.com/bitcoin/bitcoin/pull/31583#pullrequestreview-2557869188)
re ACK cb305da72df501991a6700cd20be79dde4591184

Nice cleanup. It seems reasonable to have removed the spend test.

`git range-diff e7c479495509c068215b73f6df070af2d406ae15..712e3ffde5fa4fd26c0f217942b4a289cf37f361 e7c479495509c068215b73f6df070af2d406ae15..cb305da72df501991a6700cd20be79dde4591184`

👍 tdb3 approved a pull request: "rpc: fix mintime field testnet4, expand timewarp attack test"
(https://github.com/bitcoin/bitcoin/pull/31600#pullrequestreview-2557911778)
code review ACK 4d8dea9cb92efa362f72b0c2a5b89d312b452c0a

Comments were addressed. Clarity increased.

💬 NicolaLS commented on pull request "doc: Improve dependencies documentation":
(https://github.com/bitcoin/bitcoin/pull/31634#discussion_r1919662581)
thank you. so the PR to reference for the "version used" would be #27172 correct ?

[manifest](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/manifest.scm) uses `((gnu packages cmake) #:select (cmake-minimal))` which is why we can find the version ([relevant comment in cmake.scm](https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/cmake.scm?id=713ac1fe47de1a5f29f6186e51d9ffb2b8083258#n164))

💬 TheCharlatan commented on pull request "kernel: Move block tree db open to block manager":
(https://github.com/bitcoin/bitcoin/pull/30965#issuecomment-2597622776)
Rebased b776e40554c8a315d832f3996d14ff2e3ae7b8cb -> 7f484b319bdc9e646e270b6d6d9a1c7e52296dc0 ([blockmanDB_7](https://github.com/TheCharlatan/bitcoin/tree/blockmanDB_7) -> [blockmanDB_8](https://github.com/TheCharlatan/bitcoin/tree/blockmanDB_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/blockmanDB_7..blockmanDB_8))

* Resolved conflict with #31483

💬 Sjors commented on pull request "gui, psbt: Use SIGHASH_DEFAULT when signing PSBTs":
(https://github.com/bitcoin-core/gui/pull/850#issuecomment-2597680511)
@pablomartin4btc it's part of #31622.

The description in `interpreter.h` is ambiguous. It says "Taproot only". It also says "equivalent to SIGHASH_ALL", but doesn't say that it gets converted (and obviously a constant can't guarantee that actually happens).

💬 hebasto commented on pull request "doc: Improve dependencies documentation":
(https://github.com/bitcoin/bitcoin/pull/31634#discussion_r1919735896)
>so the PR to reference for the "version used" would be #27172 correct ?

That refers to a Darwin-specific change. https://github.com/bitcoin/bitcoin/pull/29725 is a PR, which made `cmake-minimal` a global requirement.

However, in the future, updates like https://github.com/bitcoin/bitcoin/pull/30730 might bump the `cmake-minimal` version.