💬 davidgumberg commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#discussion_r1919308734)
typo in this comment, I'll fix if I retouch

💬 glozow commented on pull request "p2p: track and use all potential peers for orphan resolution":
(https://github.com/bitcoin/bitcoin/pull/31397#issuecomment-2597023473)
Followup #31666 wraps up all the comments here except for 2 things which might be a little more involved:

https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1902153685 (because we need to add a txid index)
https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1919108948

💬 tcharding commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2597024315)
cc @dangould

💬 glozow commented on pull request "p2p: track and use all potential peers for orphan resolution":
(https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1919312846)
Right. Not changing for now because it may be useful to recurse in-orphanage ancestors in this function.

👋 glozow's pull request is ready for review: "multi-peer orphan resolution followups"
(https://github.com/bitcoin/bitcoin/pull/31666)

💬 davidgumberg commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#issuecomment-2597025353)
Rebased to incorporate feedback, now try to set a good default `--platform linux/$arch` which should be an improvement for running CI on macOS.

This solution also avoids an issue I ran into after making the image tags less specific, which is that if no `--platform` argument is set, docker will try to use any image that it has cached before fetching a native image.

💬 luke-jr commented on pull request "net: option to disallow v1 connection on ipv4 and ipv6 peers":
(https://github.com/bitcoin/bitcoin/pull/30951#discussion_r1919212142)
nit: indentation

🤔 luke-jr requested changes to a pull request: "net: option to disallow v1 connection on ipv4 and ipv6 peers"
(https://github.com/bitcoin/bitcoin/pull/30951#pullrequestreview-2557320101)
No opinion on concept. Just code review.

💬 luke-jr commented on pull request "net: option to disallow v1 connection on ipv4 and ipv6 peers":
(https://github.com/bitcoin/bitcoin/pull/30951#discussion_r1919211882)
Rather avoid the temporary global and just check this when setting `connOptions`

💬 luke-jr commented on pull request "net: option to disallow v1 connection on ipv4 and ipv6 peers":
(https://github.com/bitcoin/bitcoin/pull/30951#discussion_r1919254645)
The method doesn't change anything, it just returns a value...

💬 davidgumberg commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#discussion_r1919320878)
Marking this as resolved since my latest push tries to set the right native "--platform=linux/{arch}", falling back to "--platform=linux" which is also valid according to docker's documentation although I haven't tested this yet.

⚠️ Laughter79 opened an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)
Check out this post on Nextdoor: https://nextdoor.com/p/wLC4RXZ93L9X?utm_source=share&slp=&share_platform=1&extras=OTA2MTI2MzM%3D&utm_campaign=1737066747996

✅ pinheadmz closed an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)

💬 Laughter79 commented on issue "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor":
(https://github.com/bitcoin/bitcoin/issues/31677#issuecomment-2597042890)
buymeacoffee.com/haleyslaug3

:lock: fanquake locked an issue: "https://x.com/i/lists/1304677213694914560?t=7NbHcRrYw2gVVjTlzykd6A&s=09 — Nextdoor"
(https://github.com/bitcoin/bitcoin/issues/31677)

💬 luke-jr commented on pull request "optimization: increase default LevelDB write batch size to 64 MiB":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-2597073268)
I think those graphs need to be on height rather than seconds. The larger dbbatchsize making it faster means it gets further in the chain, leading to the higher max at the end...

I would expect both lines to be essentially overlapping except during flushes.

💬 sipa commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2597143537)
Works out-of-the box on an Archer AX3000 Pro router/modem (with NAT-PMP fallback):

```
2025-01-16T21:58:50.803107Z [net] portmap: gateway [IPv4]: 192.168.0.1
2025-01-16T21:58:50.804793Z [net] pcp: Requesting port mapping for addr 0.0.0.0 port 8333 from gateway 192.168.0.1
2025-01-16T21:58:50.804834Z [net] pcp: Internal address after connect: 192.168.0.150
2025-01-16T21:58:50.805718Z [net] pcp: Received response of 8 bytes: (scrubbed)
2025-01-16T21:58:50.805736Z [net] portmap: Got unsupported PC
...

💬 theStack commented on pull request "test: p2p: fix sending of manual INVs in tx download test":
(https://github.com/bitcoin/bitcoin/pull/31658#issuecomment-2597168018)
> > My understanding is that a change like this would make the test fail on master, and pass with the patch in the pull request as it is now. But I haven't tried it, so I may be missing something?
>
> I suspect that theStack was looking for something that would prevent the underlying issue (sending wrong inv type) in general:
>
> For example we could add an `assert` in `send_message` of `p2p.py` if we try to send an `Inv` of type `MSG_TX` and have `self.wtxidrelay` set (and vice versa). Bu
...

💬 whitslack commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2597171643)
@Sjors: You want to know who wants this? I've been wanting to use Bitcoin Core to decode and manipulate the PSBTs that Core Lightning stores in its database, but it only works for the older, first-gen PSBTs. Core Lightning moved on to PSBTv2 some time ago, so now all the newer PSBTs fail to parse in Bitcoin Core. I've been having to hack together various half-baked tools I've found around the Internet, but it would be so good if Bitcoin Core would be upgraded to the current spec.

👍 theStack approved a pull request: "[test] fix p2p_orphan_handling.py empty orphanage check"
(https://github.com/bitcoin/bitcoin/pull/31675#pullrequestreview-2557742334)
ACK 2e75ebb6169da08b04c4769555c4c84d6b5ca0ec