💬 achow101 commented on pull request "test: raise explicit error if any of the needed release binaries is missing":
(https://github.com/bitcoin/bitcoin/pull/31462#issuecomment-2581434327)
ACK 1ea7e45a1f445d32a2b690d52befb2e63418653b

🚀 achow101 merged a pull request: "test: raise explicit error if any of the needed release binaries is missing"
(https://github.com/bitcoin/bitcoin/pull/31462)

✅ achow101 closed an issue: "wallet: wallet_migration.py fails on sqlite-only build"
(https://github.com/bitcoin/bitcoin/issues/31447)

🚀 achow101 merged a pull request: "wallet: migration, avoid loading legacy wallet after failure when BDB isn't compiled"
(https://github.com/bitcoin/bitcoin/pull/31451)

🚀 achow101 merged a pull request: "build, test: Build `db_tests.cpp` regardless of `USE_BDB`"
(https://github.com/bitcoin/bitcoin/pull/31617)

💬 achow101 commented on pull request "fuzz: Abort if system time is called without mock time being set":
(https://github.com/bitcoin/bitcoin/pull/31549#issuecomment-2581498389)
ACK a96b84cb1b76e65a639e62f0224f534f89858c18

🚀 achow101 merged a pull request: "fuzz: Abort if system time is called without mock time being set"
(https://github.com/bitcoin/bitcoin/pull/31549)

💬 pinheadmz commented on pull request "httpserver, rest: improving URI validation":
(https://github.com/bitcoin/bitcoin/pull/27253#discussion_r1909648045)
I noticed this while reviewing https://github.com/bitcoin/bitcoin/pull/27468 (comments locked on that PR) for my own work on `HTTPRequest` -- this test vector doesn't have a `?` so even if the URI didn't contain invalid characters it would still return null for the query parameter request. It doesn't really matter for the invalid-URI-throws-error test but it should matter for this follow up, part of which I'm trying to integrate.

So, my question is - should the test vector always have been:

...

💬 davidgumberg commented on pull request "descriptors: Try pubkeys of both evenness when retrieving the private keys for an xonly pubkey in a descriptor":
(https://github.com/bitcoin/bitcoin/pull/31590#discussion_r1909748960)
nit: The equality operator could be explicitly defaulted for `SigningProvider`:

```diff
diff --git a/src/script/signingprovider.h b/src/script/signingprovider.h
index 5b1da681f8..8262db0b52 100644
--- a/src/script/signingprovider.h
+++ b/src/script/signingprovider.h
@@ -153,6 +153,7 @@ class SigningProvider
{
public:
virtual ~SigningProvider() = default;
+ virtual bool operator==(const SigningProvider&) const = default;
```

💬 TheCharlatan commented on pull request "kernel: Move kernel-related cache constants to kernel cache":
(https://github.com/bitcoin/bitcoin/pull/31483#discussion_r1909955145)
@hodlinator since you initially proposed the current solution, do you have any fresh opinions here?

📝 barajeel opened a pull request: "fix: Optimized Performance Update bloom.cpp"
(https://github.com/bitcoin/bitcoin/pull/31632)
I made several optimizations to the Bloom filter code to enhance its performance and readability:

- Removed redundant calculations by precomputing frequently used values.
- Added early exits in loops to avoid unnecessary iterations.
- Retained efficient bitwise operations for setting and checking bits.
- Improved memory resizing for the `CRollingBloomFilter` by using bit shifts.
- Simplified conditionals in the `IsRelevantAndUpdate` method for better clarity.
- Improved comments to bette
...

✅ maflcko closed a pull request: "fix: Optimized Performance Update bloom.cpp"
(https://github.com/bitcoin/bitcoin/pull/31632)

💬 maflcko commented on pull request "depends: Use base system's `sha256sum` utility":
(https://github.com/bitcoin/bitcoin/pull/31626#issuecomment-2582053263)
Could add freebsd to the title now?

💬 maflcko commented on pull request "fuzz: Abort if system time is called without mock time being set":
(https://github.com/bitcoin/bitcoin/pull/31549#issuecomment-2582087785)
post-merge reACK a96b84cb1b76e65a639e62f0224f534f89858c18 (only change is adding missing mocktime in init)

👍 TheCharlatan approved a pull request: "init,log: Unify block index log line"
(https://github.com/bitcoin/bitcoin/pull/31616#pullrequestreview-2541869126)
ACK e04be3731f4921cd51d25b1d6210eace7600fea4

💬 maflcko commented on pull request "qa: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#discussion_r1910044619)
coming from the conflicting pull, I don't think this call should exist in the first place for two reasons:

* It doesn't work in most cases, because a failure to start any node likely means the RPC isn't up for the other nodes either, so the call will just fail in most cases. Effectively just using the kill fallback.
* It doesn't make sense to special case startup. Nodes can at any time fail to start (not only in start_nodes), or crash, and adding this exception handling to all places isn't u
...

💬 hebasto commented on pull request "depends: Use base system's `sha256sum` utility on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/31626#issuecomment-2582141098)
> Could add freebsd to the title now?

Added.

💬 hebasto commented on pull request "Safegcd-based modular inverses in MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/21590#discussion_r1910054910)
I suggest to limit the scope of this warning suppression to the `bitcoin_crypto` library only:
```diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index f2a8183c84..2dba6f255d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -397,7 +397,6 @@ target_link_libraries(core_interface INTERFACE warn_interface)
if(MSVC)
try_append_cxx_flags("/W3" TARGET warn_interface SKIP_LINK)
try_append_cxx_flags("/wd4018" TARGET warn_interface SKIP_LINK)
- try_append_cxx_flags("/wd4146" TARGET
...

💬 Sjors commented on pull request "miner: always treat SegWit as active":
(https://github.com/bitcoin/bitcoin/pull/31625#issuecomment-2582176125)
It would be good if someone has a link to the earlier reasoning.

💬 l0rinc commented on pull request "optimization: batch XOR operations 12% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2582176601)
Thank you @Sjors for testing it.
I was surprised to see your config only revealed a 3% change so I reran the full IBDs with the configs you had: `-dbcache=30000 -stopatheight=878000` (I had `-dbcache=1000 -stopatheight=870000` before).
I suspect the difference in our measurements could stem from doing a single run and not including the final dump in the measurements.

I wasn't seeding from local nodes, so the variance was a bit bigger for me, but I ran both before and after several times an
...