🚀 fanquake merged a pull request: "depends: Update capnproto to 1.1.0"
(https://github.com/bitcoin/bitcoin/pull/31552)

💬 hebasto commented on pull request "qa: Ensure consistent use of decimals instead of floats":
(https://github.com/bitcoin/bitcoin/pull/31595#issuecomment-2572924040)
> Why? While we are currently relying on the `short` python `repr()` algorithm for floats, this has been stable and reliable since it's been introduced in python 3.1 as far as I know - so I don't really see the benefit of changing dozens of functional tests / adding a new linter - unless there have been other bugs related to this in the past?

Consider two lines from [`test/functional/rpc_psbt.py`](https://github.com/bitcoin/bitcoin/blob/master/test/functional/rpc_psbt.py):https://github.com/b
...

🚀 fanquake merged a pull request: "doc: Install `net/py-pyzmq` port on FreeBSD for `interface_zmq.py`"
(https://github.com/bitcoin/bitcoin/pull/31526)

📝 fanquake converted_to_draft a pull request: "rpc, cli: add getbalances#total, and use it for -getinfo"
(https://github.com/bitcoin/bitcoin/pull/31353)
Add a "total" field in RPC getbalances to be able to easily see the total amount held in the wallet, and use that field for the wallet balances in CLI -getinfo.

Currently -getinfo only returns getbalances#mine.trusted for wallet balances. It would make sense to instead return the total balance. For instance, to see:

- watchonly balances
- reused outputs, like coins returned to a wallet from an exchange or third party service that uses a fixed (reused) address, whether `avoid_reuse` is se
...

📝 l0rinc opened a pull request: "scripted-diff: Replace invalid txid in RPC examples with valid one"
(https://github.com/bitcoin/bitcoin/pull/31610)
The RPC examples previously used an invalid 63-character txid, causing errors such as:
```
build/src/bitcoin-cli gettransaction "1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d" true
error code: -8
error message:
txid must be of length 64 (not 63, for '1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d')
```

This commit replaces the invalid txid with a valid one from https://github.com/bitcoin/bitcoin/blob/df5c643f92d4a6b1ef4dfe4b9c54f902990bb54b/src/validat
...

💬 l0rinc commented on pull request "refactor: modernize recent `ByteType` usages and read/write functions":
(https://github.com/bitcoin/bitcoin/pull/31601#issuecomment-2572965630)
I haven't seen your commit, I've recreated it - do you want me to cherry-pick that here instead?

🤔 maflcko reviewed a pull request: "fuzz: Abort if system time is called without mock time being set"
(https://github.com/bitcoin/bitcoin/pull/31549#pullrequestreview-2531996019)
I think you forgot to set it in the init function? Otherwise, the global state may be non-deterministic:

```diff
index e4e4723c74..3f3bfbeeaa 100644
--- a/src/test/fuzz/fuzz.cpp
+++ b/src/test/fuzz/fuzz.cpp
@@ -115,6 +115,7 @@ void initialize()
// - GetStrongRandBytes(), which is used for the creation of private key material.
// - Creating a BasicTestingSetup or derived class will switch to a random seed.
SeedRandomStateForTest(SeedRand::ZEROS);
+ //here

//
...

✅ kehiy closed a pull request: "doc: upgrade bitcoin core license to 2025."
(https://github.com/bitcoin/bitcoin/pull/31605)

💬 kehiy commented on pull request "doc: upgrade bitcoin core license to 2025.":
(https://github.com/bitcoin/bitcoin/pull/31605#issuecomment-2573001867)
@maflcko first commit was made in github and it seems i cant squash it properly. ill try to open a new pr.

💬 fanquake commented on issue "build: compiler flags in linker flags output":
(https://github.com/bitcoin/bitcoin/issues/31487#issuecomment-2573006198)
Same for stuff like:
`[09:29:46.367] Linker flags .......................... -Wno-error=return-type -Wno-error=maybe-uninitialized -Wno-error=array-bounds`
Showing this in "Linker flags" output doesn't make sense.

📝 kehiy opened a pull request: "doc: upgrade license to 2025."
(https://github.com/bitcoin/bitcoin/pull/31611)

💬 glozow commented on pull request "[28.x] 28.1 backports and final changes":
(https://github.com/bitcoin/bitcoin/pull/31594#issuecomment-2573019102)
reACK 36314b8da2ee65afd5636fa830d436c5c22bd260

💬 maflcko commented on pull request "fuzz: Abort if system time is called without mock time being set":
(https://github.com/bitcoin/bitcoin/pull/31549#issuecomment-2573048815)
Tested that no superflous ones were added via:

<details><summary>diff</summary>

```diff
diff --git a/src/test/fuzz/fuzz.cpp b/src/test/fuzz/fuzz.cpp
index e4e4723c74..eda5ff4cc6 100644
--- a/src/test/fuzz/fuzz.cpp
+++ b/src/test/fuzz/fuzz.cpp
@@ -78,11 +78,13 @@ void FuzzFrameworkRegisterTarget(std::string_view name, TypeTestOneInput target,

static std::string_view g_fuzz_target;
static const TypeTestOneInput* g_test_one_input{nullptr};
+bool g_ever_used_g_mocktime{false};

...

💬 maflcko commented on pull request "fuzz: Abort if system time is called without mock time being set":
(https://github.com/bitcoin/bitcoin/pull/31549#issuecomment-2573049796)
ACK 28e374f0a7dc1bda1c71e14eb896b2d9d2f23b48 🍭

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK 28e374f0a7dc1bda1c71e14eb8
...

💬 rkrux commented on pull request "BlockAssembler: return selected packages virtual size and fee":
(https://github.com/bitcoin/bitcoin/pull/30391#discussion_r1904134687)
Thank you for sharing that PR. The term `vFeerateHistogram` in itself is fine and in the #21422 PR a histogram is indeed created.
What I find confusing here is calling a simple vector of feefrac's a histogram. If a histogram will be created using this field later, let's call **that field** a histogram and not this one?

💬 hebasto commented on issue "build: compiler flags in linker flags output":
(https://github.com/bitcoin/bitcoin/issues/31487#issuecomment-2573088492)
> Same for stuff like: `[09:29:46.367] Linker flags .......................... -Wno-error=return-type -Wno-error=maybe-uninitialized -Wno-error=array-bounds` Showing this in "Linker flags" output doesn't make sense.

Replacing `CMAKE_CXX_FLAGS` with `APPEND_CXXFLAGS` to provide those flags will help.

💬 fanquake commented on issue "cmake inconsistently overriding `-O3` (sometimes)":
(https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2573089576)
@hebasto Given that your suggestion of

[> If a user wants to override any of these, they should use the CMAKE_CXX_FLAGS_<CONFIG> ](https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2541620375)

doesn't work. What should users do? Are we disallowing `-O3` wholesale? If this is the case, it should probably be documented (with the rationale), and likely warned about at configure time (if they have set `-O3` via `CMAKE_CXX_FLAGS_` or any other way), rather than sliently swapping user
...

💬 rkrux commented on pull request "BlockAssembler: return selected packages virtual size and fee":
(https://github.com/bitcoin/bitcoin/pull/30391#discussion_r1904148406)
Related to [this comment](https://github.com/bitcoin/bitcoin/pull/30391/files#r1904134687), I find the language here confusing as well. A fee rate histogram element, which I would expect to be a feeRate interval/group, is being compared to a feeFrac element, which is just a pair of fee and size.

💬 TheCharlatan commented on pull request "Miner: never create a template which exploits the timewarp bug":
(https://github.com/bitcoin/bitcoin/pull/31376#discussion_r1904153448)
I don't think the risk to the miner is big enough to warrant holding this up, especially since the timewarp fix is not actually deployed. A lot of things have to align and the miner needs to be doing weird things with setting their timestamp.

👍 TheCharlatan approved a pull request: "Miner: never create a template which exploits the timewarp bug"
(https://github.com/bitcoin/bitcoin/pull/31376#pullrequestreview-2532144755)
ACK 733fa0b0a140fc1e40c644a29953db090baa2890