💬 l0rinc commented on pull request "RPC: Add reserve member function to `UniValue` and use it in `getblock` RPC":
(https://github.com/bitcoin/bitcoin/pull/31179#discussion_r1901092142)
> I will leave that as an idea for a follow-up PR.

The problem is that the goal of this PR was to speed up the RPC.
But if we benchmark that instead of just a subset of the task, i.e.:
```patch
diff --git a/src/bench/rpc_blockchain.cpp b/src/bench/rpc_blockchain.cpp
--- a/src/bench/rpc_blockchain.cpp (revision bf5c569898d0297de010102a623bf52009607ed8)
+++ b/src/bench/rpc_blockchain.cpp (date 1735836623994)
@@ -24,7 +24,6 @@
namespace {

struct TestBlockAndIndex {
- const std::
...

💬 i-am-yuvi commented on pull request "test: Call generate RPCs through test framework only":
(https://github.com/bitcoin/bitcoin/pull/31403#issuecomment-2568122327)
> The follow-up idea in https://github.com/bitcoin/bitcoin/pull/31403#pullrequestreview-2498806354 is up-for-grabs, if someone is looking for something to work on

I'll take that!! Thanks for sharing!!

✅ maflcko closed a pull request: "fuzz: Faster leak check when generating corpus"
(https://github.com/bitcoin/bitcoin/pull/31481)

💬 maflcko commented on issue " (bitcoin core warning: unknown new rules activated versionbit 2) ":
(https://github.com/bitcoin/bitcoin/issues/31536#issuecomment-2568133106)
> i downloaded the newest version of bitcoin core wallet and run it and it finished sync but no balance showing up there either

You may have to rescan, when you load the wallet again, or restore from a backup. Otherwise, the transaction history (and balance) may be missing.

💬 maflcko commented on issue " (bitcoin core warning: unknown new rules activated versionbit 2) ":
(https://github.com/bitcoin/bitcoin/issues/31536#issuecomment-2568133444)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

💬 starius commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2568135949)
> > This change is backward-compatible, as per the old rules, such a signet challenge would always evaluate to false, rendering it unused.
>
> I don't completely agree with this, since starting an old version of bitcoind with (for example) `-signetchallenge=6a4c0901ff000000000000004c0151` would create an incompatible node. It would have a different network magic bytes and I think the `OP_RETURN` challenge would cause it to reject all blocks.

The change is backward-compatible in the sense t
...

💬 pinheadmz commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2568138710)
> This isn't accurate.

I meant, if you passed the extended challenge to an old version of bitcoin it would compute different magic bytes than if you passed the same challenge to an upgraded node.

🤔 danielabrozzoni reviewed a pull request: "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior"
(https://github.com/bitcoin/bitcoin/pull/30529#pullrequestreview-2527941633)
Concept ACK - I still haven't reviewed every commit, but this seems a nice cleanup overall.

💬 danielabrozzoni commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1901095831)
In b8c83c3a90452a35f63daac70d7cdf3ad0f2e280:

The commit message and release notes say that there are corner cases being fixed in `-nosignetseednode` and `-nosignetchallenge`, but I can't seem to reproduce them, as the code disallows the two options:

```
❯ ./build/src/bitcoind -nosignetchallenge
Error: Error parsing command line arguments: Negating of -signetchallenge is meaningless and therefore forbidden

...

💬 starius commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#discussion_r1901119937)
I verify that nodes accept blocks mined using the default signet challenge. This test includes one default signet node (2) and another node (6) configured with an extended signet challenge that uses the actual script OP_TRUE (accepts all blocks).

I added a comment with this explanation to the code.

💬 achow101 commented on pull request "[28.x] 28.1rc3 backports":
(https://github.com/bitcoin/bitcoin/pull/31594#issuecomment-2568212159)
Are these significant enough to warrant a rc3 or can we go straight to final?

✅ maflcko closed an issue: "Single-Glyph Bitcoin Transaction System"
(https://github.com/bitcoin/bitcoin/issues/31568)

💬 maflcko commented on issue "Single-Glyph Bitcoin Transaction System":
(https://github.com/bitcoin/bitcoin/issues/31568#issuecomment-2568233702)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

Network-wide consensus and/or P2P changes first need to be discussed with the greater ecosystem, for example https://groups.google.c
...

💬 maflcko commented on issue "failure in wallet_sendall.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/31571#issuecomment-2568254664)
Did you run any other command while running the tests?

Does it reproduce?

I can't reproduce with your steps on Ubuntu 22.04: `cmake -B ./bld-cmake -DBUILD_GUI=OFF -DWITH_BDB=OFF -DBUILD_BENCH=OFF -DBUILD_FOR_FUZZING=OFF -DBUILD_KERNEL_LIB=OFF -DBUILD_SHARED_LIBS=OFF -DBUILD_TESTS=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DBUILD_WALLET_TOOL=OFF && cmake --build ./bld-cmake --parallel $(nproc) && ./bld-cmake/test/functional/test_runner.py`

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1901189022)
It does not. I'll remove it

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1901192156)
I've cached `m_outbounds_count` to prevent this from happening.

This made me realize something that `fanout_targets` was incorrectly initialized, instead of reserving space for `inbounds_target_size + outbounds_target_size)`, it was being initialized with `inbounds_target_size + outbounds_target_size)` pre-existing elements initialized to 0, meaning that the returned vector contained more elements that expected

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1901195650)
Addressed in 804ccf030362fe5b232fe5c4213b77899a425f2b

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1901195715)
Addressed in 804ccf030362fe5b232fe5c4213b77899a425f2b

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1901208893)
This is already the case. The transaction that is passed to `RelayTransaction` is added to `invs_to_send` using `wtxid/txid` based on `m_wtxid_relay` (that is part of the code you quoted already). For other transactions that may be in `inv_to_send` (e.g. ancestors and/or descendants), this only apply to Erlay, and Erlay enforces `WTXID_RELAY`

💬 edilmedeiros commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2568291604)
After many hours, I could make it work.

Add this to ~/.lldbinit to make it load a local .lldbinit file: `settings set target.load-cwd-lldbinit true`. This is a convenience so that I can keep everything related to Bitcoin Core in its repo.

In the Bitcoin Core repo folder, add a .lldbinit file with (mine is located at `/Users/jose.edil/2-development/bitcoin/bitcoin-core-dev`, adjust to your path):
```
settings set target.source-map /Users/jose.edil/2-development/bitcoin/bitcoin-core-dev/bu
...