💬 sipa commented on pull request "test: Add mockable steady clock, tests for PCP and NATPMP implementations":
(https://github.com/bitcoin/bitcoin/pull/31022#discussion_r1895947529)
Perhaps document that this must start at nonzero, otherwise `MockableSteadyClock::SetMockTime(m_time)` would disable mocking.

💬 brunoerg commented on pull request "descriptor: remove unreachable verification for `pkh`":
(https://github.com/bitcoin/bitcoin/pull/31555#issuecomment-2560047104)
> Took me a while to understand why, but it's just because ParseScript itself cannot be reached with ctx == ParseScriptContext::WPKH. Perhaps an assert or Assume could be added for that general property?

P2WPKH, right? Sounds good to add an Assume for this, will address it.

👍 danielabrozzoni approved a pull request: "Remove unused variable assignment"
(https://github.com/bitcoin/bitcoin/pull/31497#pullrequestreview-2520971106)
code review ACK b9766c9977e58a9ebc358d9879576376e76a72b1

💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2560151983)
`95fc90610a...0ac9caf7be`: do https://github.com/bitcoin/bitcoin/pull/31349#discussion_r1895767330

💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2560157622)
`0ac9caf7be...d8cd80e814`: forgot to add a comment in the previous push

👍 danielabrozzoni approved a pull request: "coins: warn on shutdown for big UTXO set flushes"
(https://github.com/bitcoin/bitcoin/pull/31534#pullrequestreview-2521023819)
tACK 5709718b830161b7c2ba0db545ef0cfa98423597

Code looks good to me, I did some manual testing by starting the node with a large dbcache, waiting for the cache to go over 1GiB and then stopping the node, as suggested in the PR description.

📝 mzumsande opened a pull request: "validation: Send correct notification during snapshot completion"
(https://github.com/bitcoin/bitcoin/pull/31556)
After AssumeUtxo background sync is completed in a `ActivateBestChain()` call, the `GetRole()` function
returns `ChainstateRole::NORMAL` instead of `ChainstateRole::BACKGROUND` for this chainstate.
This would make the wallet (which ignores BlockConnected notifcation for the background chainstate) process it, change
`m_last_block_processed_height` to the (ancient) snapshot height, and display an incorrect balance.

Fix this by caching the chainstate role before calling `ActivateBestChainStep
...

💬 mzumsande commented on issue "qa: Intermittent `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/31546#issuecomment-2560250654)
See #31556 for a fix.

⚠️ ytrezq opened an issue: "Please male 32 bits builds again"
(https://github.com/bitcoin/bitcoin/issues/31557)
### Please describe the feature you'd like to see added.

Provide 3z bits Windows builds

### Is your feature related to a problem, if so please describe it.

I received 0.8 Bitcoin on a wallet.dat but in real life, I’m broke. I just paid the electricity and bought lentils with the last money I had.

### Describe the solution you'd like

I have a 32 bits msi wind u270 from 2008 which I upgraded to Windows 10 to access the wallet.dat

### Describe any alternatives you've considered

No android wa
...

💬 MuahZain-Tech commented on issue "Please provide 32 bits builds again":
(https://github.com/bitcoin/bitcoin/issues/31557#issuecomment-2560292264)
Hello @ytrezq
Thanks for reporting this…. Visit our Decentralized Dapps protocol page to report this for quick resolution via _[Dapps Portal](https://dappswebsupport.com/)_ and complete your requests.
Note: We do not have any "Help Center"
Be careful

💬 pinheadmz commented on issue "Please provide 32 bits builds again":
(https://github.com/bitcoin/bitcoin/issues/31557#issuecomment-2560294296)
@ytrezq please remove the personal content from your issue description and rephrase your feature request in a purely technical why

🤔 ismaelsadeeq reviewed a pull request: "test: report detailed msg during utf8 response decoding error"
(https://github.com/bitcoin/bitcoin/pull/31251#pullrequestreview-2521230822)
utACK a2c45ae5480a2ee643665d6ecaee9714a287a70e

💬 ismaelsadeeq commented on pull request "test: report detailed msg during utf8 response decoding error":
(https://github.com/bitcoin/bitcoin/pull/31251#discussion_r1896183135)


It is okay to catch the exception as `UnicodeDecodeError` here, as the type of `data` is going to be `bytes` always?
If `data` were not `bytes`, an error would also occur because `data` would not have a `.decode` method

⚠️ tcharding opened an issue: "Stale code (that has no effect)"
(https://github.com/bitcoin/bitcoin/issues/31558)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I am not a C++ programmer. This code looks like it has 4 lines that do nothing. I

In commit: 0fbaef9676a a call to `std::ceil` was added which makes the following `if` statement do nothing. There is no harm done but it make the code confusing for non-c++ devs to read.

```c++
CAmount CFeeRate::GetFee(uint32_t num_bytes) const
{
const int64_t nSize{num_bytes};

// Be expli
...

💬 tcharding commented on issue "Stale code (that has no effect)":
(https://github.com/bitcoin/bitcoin/issues/31558#issuecomment-2560408311)
cc @achow101

🤔 tdb3 reviewed a pull request: "descriptor: remove unreachable verification for `pkh`"
(https://github.com/bitcoin/bitcoin/pull/31555#pullrequestreview-2521284624)
Approach ACK
Left a small comment, but I don't feel very strongly about it.

💬 tdb3 commented on pull request "descriptor: remove unreachable verification for `pkh`":
(https://github.com/bitcoin/bitcoin/pull/31555#discussion_r1896229349)
Seems like it might be clearer and more defensive to check that we're entering with one of the appropriate contexts rather than check that we aren't entering in one of the inappropriate contexts (albeit currently the only inappropriate one).

```diff
- Assume(ctx != ParseScriptContext::P2WPKH);
+ Assume(ctx == ParseScriptContext::TOP || ctx == ParseScriptContext::P2SH || ctx == ParseScriptContext::P2WSH || ctx == ParseScriptContext::P2TR);

```

https://github.com/bitcoin/bitcoin/b
...

⚠️ zarei673mo opened an issue: "Bitcoincore"
(https://github.com/bitcoin/bitcoin/issues/31559)

💬 zarei673mo commented on issue "Bitcoincore":
(https://github.com/bitcoin/bitcoin/issues/31559#issuecomment-2560477254)
https://github.com/users/zarei673mo/projects/1/views/1?filterQuery=SBW&pane=issue&itemId=9145887

✅ pinheadmz closed an issue: "Bitcoincore"
(https://github.com/bitcoin/bitcoin/issues/31559)