🤔 l0rinc reviewed a pull request: "test: fix TestShell initialization and reset()"
(https://github.com/bitcoin/bitcoin/pull/31415#pullrequestreview-2517777408)
I wanted to see what the π pull request contains, ended up reviewing it.
Could you please specify in the description of how the reviewers should test the code and why the extraction was necessary besides the absolute file computation?

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894066689)
there are many other instances of `bitcoin/test` in the doc, could you please adjust the rest as well?

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894075268)
Now that it's moved out of `TestShell` this (slightly awkward) comment should likely be updated.

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894082388)
useless comment, the code already makes this obvious

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894076519)
Q: I'm not sure I understand the reason for extraction, can you please clarify that?

Nit: We're adding another global here which pollutes the namespace, can we rather inline it?
```suggestion
dummy_testshell_file = pathlib.Path(__file__).absolute().parent.parent / "testshell_dummy.py"
```

💬 hebasto commented on pull request "depends: Fix compiling `libevent` package on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31500#issuecomment-2557287932)
> Can you link to the upstream issue / PR.

> LGTM, but yeah, it'd be helpful to upstream this.

Sure thing!

Here is an upstream PR: https://github.com/libevent/libevent/pull/1768.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2557298504)
`3522e897f2...964b7b0ad6`: pet clang-tidy

💬 hebasto commented on issue "qa: Intermittent `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/31546#issuecomment-2557299362)
> Is it reproducible?

It seems intermittent.

💬 vasild commented on issue "Feature Request: Broadcast Pool":
(https://github.com/bitcoin/bitcoin/issues/30471#issuecomment-2557300801)
The closest thing to this is at https://github.com/bitcoin/bitcoin/pull/29415, waiting for testing and code review.

💬 hebasto commented on pull request "doc: Install `net/py-pyzmq` port on FreeBSD for `interface_zmq.py`":
(https://github.com/bitcoin/bitcoin/pull/31526#issuecomment-2557307026)
Friendly ping @vasild :)

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2557349002)
I'm aware this is a big chunk of code, but perhaps this can aid review a bit.

The biggest commits is [txgraph: (feature) add initial version](https://github.com/bitcoin/bitcoin/pull/31363/commits/afc6a665770004411f1b57f4f43dda916dadd8f7). To get an idea of what is going on, I think it's useful to look (in order) at:
* The `src/txgraph.h` file added in that commit, as it defines the public interface.
* The `src/test/fuzz/txgraph.cpp` test added in the next commit ([txgraph: (tests) add simul
...

💬 hebasto commented on issue "depends: `capnp` package fails to build on NetBSD 10.0":
(https://github.com/bitcoin/bitcoin/issues/31499#issuecomment-2557362137)
> Shouldn't this be an upstream bug report, given that's where the issue is?

https://github.com/capnproto/capnproto/issues/2201.

📝 marcofleon opened a pull request: "fuzz: Abort if system time is called without mock time being set"
(https://github.com/bitcoin/bitcoin/pull/31549)
This PR expands the `CheckGlobals` utility that was introduced in https://github.com/bitcoin/bitcoin/pull/31486 and should help with fuzz stability (https://github.com/bitcoin/bitcoin/issues/29018).

System time shouldn't be used when running a fuzz test, as it is likely to introduce instability (non-determinism). This PR identifies and fixes the targets that were calling system time without setting mock time at the start of an iteration.

Removing`SetMockTime()` from any one of these targe
...

💬 theuni commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557510392)
So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.

Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?

💬 hebasto commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557513164)
> So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.
>
>
>
> Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?

This is because CMake uses absolute paths to libraries during the linking stage.

💬 theuni commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557527549)
> > So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.
> > Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?
>
> This is because CMake uses absolute paths to libraries during the linking stage.

Yes, but I was asking how it found it to link against in the first place.

Answering my own question: [CMake is adding it, not `ld`](https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Platform/UnixPath
...

👍 theuni approved a pull request: "cmake: Always provide `RPATH` on NetBSD"
(https://github.com/bitcoin/bitcoin/pull/31543#pullrequestreview-2518124400)
utACK https://github.com/bitcoin/bitcoin/pull/31543/commits/11115e9aa845d675a88e18e729913f0aaa11e322

🤔 mzumsande reviewed a pull request: "qa: Limit `-maxconnections` in tests"
(https://github.com/bitcoin/bitcoin/pull/31537#pullrequestreview-2518220584)
Code Review ACK d9d5bc2e7466033d989432f53a112325fa3d6d4a

Some tests will overwrite `-maxconnections`, e.g. `p2p_eviction.py` sets it to 32 and connects 22 python peers at the same time, so with the current test suite any OS would need to be able to deal with that.
But since the BSD limit of 94 is larger than that, and I don't really see a need for functional tests having more peers than that, there should be no problem.

👍 i-am-yuvi approved a pull request: "rpc: Add signet_challenge field to getblockchaininfo and getmininginfo"
(https://github.com/bitcoin/bitcoin/pull/31531#pullrequestreview-2518245384)
Concept ACK ecaa786cc103cf7cc63ae899ec13d81a54e2fd1e

Both the RPC seems to be giving enough information about the signet challenges!! Thanks @A-Manning for this!!

I have used custom signet(OP_TRUE) on Linux x86_64:

`getblockchaininfo`:
```
{
"chain": "signet",
"blocks": 0,
"headers": 0,
"bestblockhash": "00000008819873e925422c1ff0f99f7cc9bbb232af63a077a480a3633bee1ef6",
"difficulty": 0.001126515290698186,
"time": 1598918400,
"mediantime": 1598918400,
"verificat
...

💬 i-am-yuvi commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2557651018)
Great work!! @starius
Concept ACK

This would be a great help for Warnet Game since now you can easily configure the block creation time. Will review the code very soon!!