⚠️ hebasto opened an issue: "qa: `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`"
(https://github.com/bitcoin/bitcoin/issues/31546)
https://github.com/hebasto/bitcoin/actions/runs/12431224655/job/34708713770:
```
265/315 - wallet_assumeutxo.py --descriptors failed, Duration: 5 s

stdout:
2024-12-20T12:54:28.609000Z TestFramework (INFO): PRNG seed is: 187204816715607970

2024-12-20T12:54:28.641000Z TestFramework (INFO): Initializing test directory D:\a\_temp\test_runner_₿_🏃_20241220_123237\wallet_assumeutxo_48

2024-12-20T12:54:30.237000Z TestFramework (INFO): -- Testing assumeutxo

2024-12-20T12:54:30.237000Z Tes
...

📝 l0rinc opened a pull request: "build: Use character literals for generated headers to avoid narrowing"
(https://github.com/bitcoin/bitcoin/pull/31547)
Use character literals instead of integer hex values (i.e. `'\x5b','\x0a', ...` instead of `0x5b, 0x0a, ...`) for generated headers. This avoids C++11 narrowing warnings in a more concise way than using explicit char casts.

Extra whitespace is also removed between elements for brevity.

Split out of https://github.com/bitcoin/bitcoin/pull/31542#discussion_r1893781576

💬 l0rinc commented on pull request "test: Embed univalue json tests in binary":
(https://github.com/bitcoin/bitcoin/pull/31542#discussion_r1893953186)
Extracted to https://github.com/bitcoin/bitcoin/pull/31547 - pease resolve the comment

💬 l0rinc commented on pull request "test: Embed univalue json tests in binary":
(https://github.com/bitcoin/bitcoin/pull/31542#issuecomment-2557043408)
ACK faedcc5fdabc508aaade9b461e44ea3a6670f36b

Avoiding file reads during test setup is a step forward in portability 👍
We can continue the refactors in follow-up PRs.

👍 theStack approved a pull request: "doc: Install `py3-zmq` port on OpenBSD for `interface_zmq.py`"
(https://github.com/bitcoin/bitcoin/pull/31535#pullrequestreview-2517585410)
Tested ACK be1a2e5dfbdf4b3799f07e48c41b09b54b72f9b6

Verified on OpenBSD 7.6 that `$ ./build/test/functional/interface_zmq.py` succeeds if `py3-zmq` is installed and that the test is skipped (`python3-zmq module not available`) if that package is removed.

💬 maflcko commented on issue "qa: `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/31546#issuecomment-2557052983)
Is it reproducible?

💬 maflcko commented on pull request "test: Embed univalue json tests in binary":
(https://github.com/bitcoin/bitcoin/pull/31542#discussion_r1893980063)
Thx, rebased to avoid changing the same line twice.

💬 l0rinc commented on pull request "test: Embed univalue json tests in binary":
(https://github.com/bitcoin/bitcoin/pull/31542#issuecomment-2557102250)
ACK faf7eac364fb7f421a649b483286ac8681d92b31

The changes since last ACK: [simplify char casting](https://github.com/bitcoin/bitcoin/pull/31547) and reformat the affected sources.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2557107378)
`f5fc9451aa...3522e897f2`: rebase due to conflicts

🚀 fanquake merged a pull request: "cmake: Remove unused `BUILD_TESTING` variable from "dev-mode" preset"
(https://github.com/bitcoin/bitcoin/pull/31544)

🚀 fanquake merged a pull request: "doc: Install `py3-zmq` port on OpenBSD for `interface_zmq.py`"
(https://github.com/bitcoin/bitcoin/pull/31535)

🚀 fanquake merged a pull request: "guix: latest 2.31 glibc"
(https://github.com/bitcoin/bitcoin/pull/31529)

👍 tdb3 approved a pull request: "rpc: increase the defaults for -rpcthreads and -rpcworkqueue"
(https://github.com/bitcoin/bitcoin/pull/31215#pullrequestreview-2517790394)
ACK e56fc7ce6a92eae7e80657d9f57a148cc002358d

Saw performance improvement and no degradation.

📝 maflcko opened a pull request: "fuzz: Abort when global PRNG is used before SeedRand::ZEROS"
(https://github.com/bitcoin/bitcoin/pull/31548)
This adds one more check to abort when global PRNG is used before SeedRand::ZEROS in fuzz tests. This is achieved by carving out the two remaining uses. First, `g_rng_temp_path_init`, and second the random fallback for `RANDOM_CTX_SEED`, which isn't used in fuzz tests anyway.

Requested in https://github.com/bitcoin/bitcoin/pull/31521#issuecomment-2554669015

Can be tested by reverting fadd568931a2d21e0f80e1efaf2281f5164fa20e and observing an abort when running the `utxo_total_supply` fuzz t
...

🤔 l0rinc reviewed a pull request: "test: fix TestShell initialization and reset()"
(https://github.com/bitcoin/bitcoin/pull/31415#pullrequestreview-2517777408)
I wanted to see what the π pull request contains, ended up reviewing it.
Could you please specify in the description of how the reviewers should test the code and why the extraction was necessary besides the absolute file computation?

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894066689)
there are many other instances of `bitcoin/test` in the doc, could you please adjust the rest as well?

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894075268)
Now that it's moved out of `TestShell` this (slightly awkward) comment should likely be updated.

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894082388)
useless comment, the code already makes this obvious

💬 l0rinc commented on pull request "test: fix TestShell initialization and reset()":
(https://github.com/bitcoin/bitcoin/pull/31415#discussion_r1894076519)
Q: I'm not sure I understand the reason for extraction, can you please clarify that?

Nit: We're adding another global here which pollutes the namespace, can we rather inline it?
```suggestion
dummy_testshell_file = pathlib.Path(__file__).absolute().parent.parent / "testshell_dummy.py"
```

💬 hebasto commented on pull request "depends: Fix compiling `libevent` package on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31500#issuecomment-2557287932)
> Can you link to the upstream issue / PR.

> LGTM, but yeah, it'd be helpful to upstream this.

Sure thing!

Here is an upstream PR: https://github.com/libevent/libevent/pull/1768.