Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 maflcko commented on issue "Assertion pindexPrev && pindexPrev == chainstate.m_chain.Tip() when running regtest":
(https://github.com/bitcoin/bitcoin/issues/31562#issuecomment-2561221830)
Thx, #https://github.com/bitcoin/bitcoin/pull/31563 should fix the assert crash
📝 rkrux opened a pull request: "wallet: remove redundant `Assert` call when block is disconnected"
(https://github.com/bitcoin/bitcoin/pull/32153)
It was highlighted in a PR discussion previously that the recently moved `Assert` macro call inside the block disconnected loop had been redundant for quite a while because of the presence of the `assert` macro call at the start of the function. Therefore, it is removed now.

refs #https://github.com/bitcoin/bitcoin/pull/31757#discussion_r1995416821

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
...
💬 hodlinator commented on pull request "wallet: remove redundant `Assert` call when block is disconnected":
(https://github.com/bitcoin/bitcoin/pull/32153#discussion_r2017695755)
If you re-touch, I think it would be more correct to remove the `#` in the commit message at the beginning of
`refs #https://github.com/bitcoin/bitcoin/pull/31757#discussion_r1995416821`
since it is a link and not a PR/Issue number.