💬 maflcko commented on pull request "refactor: Move GuessVerificationProgress into ChainstateManager":
(https://github.com/bitcoin/bitcoin/pull/31393#discussion_r1867360742)
Thanks, done

💬 Sjors commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2514050392)
I also tried @bigspider's MooSig demo which worked. I then crafted a multisig between A and the device: `tr(musig(A,L)/<0;1>/*)`. I managed to register the policy (after several mistakes, it's very tedious to do this manually).

I wanted to try using HWI to display the address, but I would have to modify it to work with the test app. I just yolo funded it.

I then created a withdrawal PSBT and pasted it in the Moosig script, modifying it to only add its public nonce. I also hardcoded the reg
...

💬 Prabhat1308 commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1867364249)
```suggestion
self.log.debug("Test that settxfeerate set the feerate in sat/vB")
```

👍 dergoegge approved a pull request: "Improve parallel script validation error debug logging"
(https://github.com/bitcoin/bitcoin/pull/31112#pullrequestreview-2475144960)
ACK 492e1f09943fcb6145c21d470299305a19e17d8b

💬 willcl-ark commented on issue "Crash upon RPC v1 connection in v28.0.0":
(https://github.com/bitcoin/bitcoin/issues/31041#issuecomment-2514072312)
I took a look with heaptrack on a debug build of 28.0 (output file: https://tmp.256k1.dev/heaptrack.bitcoind.3546996.zst )


Whilst number of allocations increase over time as expected:


Consumed heap memory stays pretty stable:

![image](https://github.com/user-attachments/assets/528a529c-7f35-4eb0-a6d9-59
...

💬 Sjors commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2514087290)
Looking at the functional tests in 3649c2eb2053a0c166c68beb310c9c64ddc5b273 it seems the way this is designed to work is by swapping out the active `tr([m/86'/1'/0']xpriv/<0;1>)/*` descriptor for `tr(musig([m/86'/1'/0']xpriv,other,other)/<0;1>)/*`.

I guess that's fine for the purpose of getting MuSig2 functionality in for experimental use, but it seems a bit unsafe and confusing for general use.

💬 maflcko commented on issue "Crash upon RPC v1 connection in v28.0.0":
(https://github.com/bitcoin/bitcoin/issues/31041#issuecomment-2514089741)
Thanks! I don't expect a memory leak either, but I'd find it interesting to see where the heap usage came from. I guess it is all Univalue?

💬 maflcko commented on issue "fuzz, parse_iso8601: attempt to dereference an end-of-stream istreambuf_iterator":
(https://github.com/bitcoin/bitcoin/issues/28917#issuecomment-2514119343)
Fixed in https://github.com/bitcoin/bitcoin/pull/31391

💬 willcl-ark commented on issue "Crash upon RPC v1 connection in v28.0.0":
(https://github.com/bitcoin/bitcoin/issues/31041#issuecomment-2514123767)
Actually seems to be a mixture, and UniValue doesn't particularly stand out to me:


👍 dergoegge approved a pull request: "util: Drop boost posix_time in ParseISO8601DateTime"
(https://github.com/bitcoin/bitcoin/pull/31391#pullrequestreview-2475255194)
utACK faf70cc9941ce2b0ce4fd48ecfdbe28194adb8ba

💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2514198467)
Ready for review. I updated the OP with some details.

👋 vasild's pull request is ready for review: "ci: detect outbound internet traffic generated while running tests"
(https://github.com/bitcoin/bitcoin/pull/31349)

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867426740)
I prefer having a "Config file: "-prefix to grep for in logs, so following that pattern for added messages here in this PR (but not going to touch the InitWarning as it might be shown in the GUI).

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867422543)
Thanks! Fixed in latest push.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867434512)
Current way is clearer & safer to me.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867430106)
Would rather not change to quote paths in all log messages of this function as it would touch even more lines.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867438656)
I've updated that commit to better document that I'm overriding the 2 methods (unfortunately our *.python-version* is 3.10.14, python 3.12 includes `@override`).

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867460705)
PR does not contain a test for this as I thought it was straightforward enough to skip and I didn't want to add more things to review/maintain. If we pass `-nopid` we simply do not:
- Create the file
- Write the PID
- Set the `bool` to remember deleting the file
- (Delete the file)

https://github.com/bitcoin/bitcoin/blob/95a0104f2e9869799db84add108ae8c57b56d360/src/init.cpp#L165-L192

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867433277)
Thanks, agree that it's a bit redundant in an assert, leftover from previous comment. Updated.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1867461728)
Moved back the log message in latest push to clarify.