💬 hebasto commented on issue "macOS 13.7 depends build can't find qt (symlink)":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2511369328)
> cd depends
> make NO_BDB=1
> ...
> copying packages: boost libevent qt qrencode sqlite miniupnpc zeromq
> to: /Volumes/SSD/Dev/bitcoin/depends/x86_64-apple-darwin22.6.0
> `/Users/sjors/dev` is a symlink to `/Volumes/SSD/Dev/`. I'll try a build without using a symlink. (will be a few weeks before I can access this machine)
On macOS Sequoia 15.1, when I build depends in a symlinked directory, the resulted toolchain file still refers to the real directory.
@Sjors
...
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2511369328)
> cd depends
> make NO_BDB=1
> ...
> copying packages: boost libevent qt qrencode sqlite miniupnpc zeromq
> to: /Volumes/SSD/Dev/bitcoin/depends/x86_64-apple-darwin22.6.0
> `/Users/sjors/dev` is a symlink to `/Volumes/SSD/Dev/`. I'll try a build without using a symlink. (will be a few weeks before I can access this machine)
On macOS Sequoia 15.1, when I build depends in a symlinked directory, the resulted toolchain file still refers to the real directory.
@Sjors
...
🚀 fanquake merged a pull request: "build: Set shared linker flags in toolchain file"
(https://github.com/bitcoin/bitcoin/pull/31395)
(https://github.com/bitcoin/bitcoin/pull/31395)
💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#issuecomment-2511396423)
The BitAxe doesn't like it either:
```
₿ (108381) bm1368Module: Job ID: 18, Core: 75/1, Ver: 07702000
₿ (108381) bm1368Module: Invalid job found, 0x18
```
(https://github.com/bitcoin/bitcoin/pull/31384#issuecomment-2511396423)
The BitAxe doesn't like it either:
```
₿ (108381) bm1368Module: Job ID: 18, Core: 75/1, Ver: 07702000
₿ (108381) bm1368Module: Invalid job found, 0x18
```
💬 willcl-ark commented on issue "ci: `feature_settings.py` failed in macOS 14 CI":
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2511396634)
I don't think there's much else we can do here with current information.
Does this seem worth keeping open to anyone else, seeing as we haven't seen re-occurrence in CI (AFAIK)?
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2511396634)
I don't think there's much else we can do here with current information.
Does this seem worth keeping open to anyone else, seeing as we haven't seen re-occurrence in CI (AFAIK)?
💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2511440437)
Rebased 403c20980ec118f6efdd21d7c25646e20574583b -> 8598bc9e5d3fb7ebc08cf0c6422b3e44c56230d6 ([kernelApi_7](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_7) -> [kernelApi_8](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_7..kernelApi_8))
* Get build system fixes from #31395 and #31357
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2511440437)
Rebased 403c20980ec118f6efdd21d7c25646e20574583b -> 8598bc9e5d3fb7ebc08cf0c6422b3e44c56230d6 ([kernelApi_7](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_7) -> [kernelApi_8](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_7..kernelApi_8))
* Get build system fixes from #31395 and #31357
💬 maflcko commented on pull request "contrib: fix BUILDDIR in gen-bitcoin-conf script":
(https://github.com/bitcoin/bitcoin/pull/31332#issuecomment-2511471612)
Are you still working on this?
(https://github.com/bitcoin/bitcoin/pull/31332#issuecomment-2511471612)
Are you still working on this?
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2511478347)
Rebased.
> > Starting with Qt 6.5.0, the libxcb-cursor0 package is required to be installed at runtime.
>
> There's no mention of this in `build-unix.md` or `depends/README.md`.
Amended.
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2511478347)
Rebased.
> > Starting with Qt 6.5.0, the libxcb-cursor0 package is required to be installed at runtime.
>
> There's no mention of this in `build-unix.md` or `depends/README.md`.
Amended.
💬 Detroitin commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2511481603)
huh! well I guess every block I hit that is 194.47 million Dif. hopefully helps.. I did see the pools "luck" go up LOL. im knowingly fighting a loosing battle. but i hate seeing a bully..
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2511481603)
huh! well I guess every block I hit that is 194.47 million Dif. hopefully helps.. I did see the pools "luck" go up LOL. im knowingly fighting a loosing battle. but i hate seeing a bully..
✅ maflcko closed an issue: "ci: `feature_settings.py` failed in macOS 14 CI"
(https://github.com/bitcoin/bitcoin/issues/31019)
(https://github.com/bitcoin/bitcoin/issues/31019)
💬 maflcko commented on issue "ci: `feature_settings.py` failed in macOS 14 CI":
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2511490545)
Closing for now. Can be re-opened when it happens again.
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2511490545)
Closing for now. Can be re-opened when it happens again.
💬 fanquake commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1865846547)
Not sure that the self-compilation documentation is the right place to put a note about a runtime requirement for the guix built release binaries.
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1865846547)
Not sure that the self-compilation documentation is the right place to put a note about a runtime requirement for the guix built release binaries.
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1865853511)
What do you suggest?
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1865853511)
What do you suggest?
📝 maflcko opened a pull request: "test: Call generate RPCs through test framework only"
(https://github.com/bitcoin/bitcoin/pull/31403)
The generate RPCs are special in that they should only be called by the test framework itself. This way, they will call the sync function on the nodes, which can avoid intermittent test issues. Also, when the sync is disabled, it will happen explicitly by setting the `sync_fun`.
Apply this rule here, so that all generate calls are written consistently.
(https://github.com/bitcoin/bitcoin/pull/31403)
The generate RPCs are special in that they should only be called by the test framework itself. This way, they will call the sync function on the nodes, which can avoid intermittent test issues. Also, when the sync is disabled, it will happen explicitly by setting the `sync_fun`.
Apply this rule here, so that all generate calls are written consistently.
🚀 fanquake merged a pull request: "test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py"
(https://github.com/bitcoin/bitcoin/pull/31383)
(https://github.com/bitcoin/bitcoin/pull/31383)
💬 brunoerg commented on pull request "test: addrman: tried 3 times and never a success so `isTerrible=true`":
(https://github.com/bitcoin/bitcoin/pull/30445#issuecomment-2511569863)
rfm?
(https://github.com/bitcoin/bitcoin/pull/30445#issuecomment-2511569863)
rfm?
👍 fanquake approved a pull request: "doc: Use more precise anchor links to Xcode SDK extraction"
(https://github.com/bitcoin/bitcoin/pull/31386#pullrequestreview-2472733255)
ACK 8bf1b3039cb5b396e7e6d3ac075656952edd56d5
(https://github.com/bitcoin/bitcoin/pull/31386#pullrequestreview-2472733255)
ACK 8bf1b3039cb5b396e7e6d3ac075656952edd56d5
🚀 fanquake merged a pull request: "doc: Use more precise anchor links to Xcode SDK extraction"
(https://github.com/bitcoin/bitcoin/pull/31386)
(https://github.com/bitcoin/bitcoin/pull/31386)
💬 maflcko commented on pull request "test: simple reordering to reduce run time":
(https://github.com/bitcoin/bitcoin/pull/31396#issuecomment-2511582433)
lgtm ACK 62f6d9e1a48e3b63c504996e914075cacfdcaedc
(https://github.com/bitcoin/bitcoin/pull/31396#issuecomment-2511582433)
lgtm ACK 62f6d9e1a48e3b63c504996e914075cacfdcaedc
👍 TheCharlatan approved a pull request: "test: simple reordering to reduce run time"
(https://github.com/bitcoin/bitcoin/pull/31396#pullrequestreview-2472777174)
ACK 62f6d9e1a48e3b63c504996e914075cacfdcaedc
(https://github.com/bitcoin/bitcoin/pull/31396#pullrequestreview-2472777174)
ACK 62f6d9e1a48e3b63c504996e914075cacfdcaedc
💬 fanquake commented on pull request "util: Drop boost posix_time in ParseISO8601DateTime":
(https://github.com/bitcoin/bitcoin/pull/31391#issuecomment-2511632283)
Can also drop `boost-date-time` from `vcpkg.json`.
(https://github.com/bitcoin/bitcoin/pull/31391#issuecomment-2511632283)
Can also drop `boost-date-time` from `vcpkg.json`.