💬 Sjors commented on pull request "Add multiprocess binaries to release build":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2511204009)
Trivial rebase after #31399.

I disabled ASan + LSan + UBsan again, see previous failure log: https://github.com/bitcoin/bitcoin/actions/runs/11970857809/job/33374462331?pr=30975

(this drops fda0d98237b4a82a94a5672f6bd263bca04adf35 and adjusts 0b5c84bc988e600484012f43df0e9950e7c444f5 to enable multiprocess for `ci/test/00_setup_env_native_valgrind.sh`)

💬 l0rinc commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1865645185)
It's not the purpose of this PR to add additional coverage, but after these refactors it's now possible to exercise the negative cases as well (which are missing here but tested in the other test methods, hence the TODO), similarly to how the above PR does for fuzzing.

💬 le0nAg commented on issue "Add `sat_to_btc()` and conversely `btc_to_sat()` util functions in functional tests":
(https://github.com/bitcoin/bitcoin/issues/31345#issuecomment-2511225604)
Could I take the issue?

💬 l0rinc commented on pull request "test: cover base32/base58/base64 with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#discussion_r1865666794)
I forgot about this comment, thanks for checking, both tests on 42 and 43 were invalid because of the non-trailing `=`, not the `\0` - [updated them](https://github.com/bitcoin/bitcoin/compare/6fd185c035c1cc4dd961cf14a2087e97fb069440..37e5fcfd4fad2f2daed041ddfd60b0c28e5da6b6)

💬 hebasto commented on pull request "cmake: Add `CheckLinkerSupportsPIE` module":
(https://github.com/bitcoin/bitcoin/pull/31359#issuecomment-2511246212)
> > Enhances robustness
>
> Can you explain this further? Why is CMakes own check not "robust" enough to use directly? Is this another bug/something that should be improved upstream?

Sure thing!

(Almost?) every CMake check internally uses the [`try_compile()`](https://cmake.org/cmake/help/latest/command/try_compile.html) command, whose behaviour, in turn, depends on the [`CMAKE_TRY_COMPILE_TARGET_TYPE`](https://cmake.org/cmake/help/latest/variable/CMAKE_TRY_COMPILE_TARGET_TYPE.html) var
...

💬 fanquake commented on pull request "cmake: Add `CheckLinkerSupportsPIE` module":
(https://github.com/bitcoin/bitcoin/pull/31359#issuecomment-2511251713)
This seems very fragile and unintuitive, and the fact that this could silently break at any point is not documented in any way. I don't think other bad design decisions should lead to us having to write even more boilerplate code to fix things that should "just work" (minus the upstream bugs).

👋 fanquake's pull request is ready for review: "[28.x] Backports & 28.1rc1"
(https://github.com/bitcoin/bitcoin/pull/31104)

✅ fanquake closed an issue: "RPC breakage with v28.0"
(https://github.com/bitcoin/bitcoin/issues/31039)

💬 fanquake commented on issue "RPC breakage with v28.0":
(https://github.com/bitcoin/bitcoin/issues/31039#issuecomment-2511284738)
Closing this now. Anything left to do can be tracked in individual issues. A number of things have been merged / resolved downstream. It looks like some wont be, i.e https://github.com/vansergen/rpc-bitcoin/pull/65, but that package in particular is essentially unmaintained at this point.

✅ fanquake closed a pull request: "doc: Fix dead links to mailing list archives"
(https://github.com/bitcoin/bitcoin/pull/31240)

💬 fanquake commented on pull request "doc: Fix dead links to mailing list archives":
(https://github.com/bitcoin/bitcoin/pull/31240#issuecomment-2511334022)
Will close this for now, and we can re open if/when it comes up again.

💬 hebasto commented on issue "macOS 13.7 depends build can't find qt (symlink)":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2511369328)
> cd depends
> make NO_BDB=1
> ...
> copying packages: boost libevent qt qrencode sqlite miniupnpc zeromq
> to: /Volumes/SSD/Dev/bitcoin/depends/x86_64-apple-darwin22.6.0

> `/Users/sjors/dev` is a symlink to `/Volumes/SSD/Dev/`. I'll try a build without using a symlink. (will be a few weeks before I can access this machine)

On macOS Sequoia 15.1, when I build depends in a symlinked directory, the resulted toolchain file still refers to the real directory.

@Sjors
...

🚀 fanquake merged a pull request: "build: Set shared linker flags in toolchain file"
(https://github.com/bitcoin/bitcoin/pull/31395)

💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#issuecomment-2511396423)
The BitAxe doesn't like it either:

```
₿ (108381) bm1368Module: Job ID: 18, Core: 75/1, Ver: 07702000
₿ (108381) bm1368Module: Invalid job found, 0x18
```

💬 willcl-ark commented on issue "ci: `feature_settings.py` failed in macOS 14 CI":
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2511396634)
I don't think there's much else we can do here with current information.

Does this seem worth keeping open to anyone else, seeing as we haven't seen re-occurrence in CI (AFAIK)?

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2511440437)
Rebased 403c20980ec118f6efdd21d7c25646e20574583b -> 8598bc9e5d3fb7ebc08cf0c6422b3e44c56230d6 ([kernelApi_7](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_7) -> [kernelApi_8](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_7..kernelApi_8))

* Get build system fixes from #31395 and #31357

💬 maflcko commented on pull request "contrib: fix BUILDDIR in gen-bitcoin-conf script":
(https://github.com/bitcoin/bitcoin/pull/31332#issuecomment-2511471612)
Are you still working on this?

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2511478347)
Rebased.

> > Starting with Qt 6.5.0, the libxcb-cursor0 package is required to be installed at runtime.
>
> There's no mention of this in `build-unix.md` or `depends/README.md`.

Amended.

💬 Detroitin commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2511481603)
huh! well I guess every block I hit that is 194.47 million Dif. hopefully helps.. I did see the pools "luck" go up LOL. im knowingly fighting a loosing battle. but i hate seeing a bully..

✅ maflcko closed an issue: "ci: `feature_settings.py` failed in macOS 14 CI"
(https://github.com/bitcoin/bitcoin/issues/31019)