💬 jonatack commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2500731539)
Concept ACK

> Given BIP373 doesn't have test vectors, it would be very useful that either this PR or the BIP include some hard coded PSBT examples to ensure every implementations are on the same page.

Good point (the BIP373 test vector section currently states "TBD" and seems worth completing even if the implementation here also has tests).

💬 stickies-v commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r1858493399)
> You'd probably want to pass this function a script verify object that has already passed through the required pre-checks.

I 100% agree with this approach. Adding extra types makes the API more cumbersome to use, but I think it does make it more safe, and the extra verbosity should be quite easy to hide in client libraries.

> But then you're forced to check them here again.

I think that can be avoided by having the prechecks function return a `ScriptPreChecksPassed*` (which references
...

💬 theStack commented on pull request "doc, test: more ephemeral dust follow-ups":
(https://github.com/bitcoin/bitcoin/pull/31371#discussion_r1858493647)
Hmm, thought about that, but I think this could be confusing, especially considering that transactions are still created with nVersion=2 by default (see e.g. https://github.com/bitcoin/bitcoin/issues/31348). Seems more expressive to be explicit about the tx version.

💬 theStack commented on pull request "doc, test: more ephemeral dust follow-ups":
(https://github.com/bitcoin/bitcoin/pull/31371#discussion_r1858494074)
Will do if I have to retouch.

💬 Sjors commented on pull request "net, net_processing: additional and consistent disconnect logging":
(https://github.com/bitcoin/bitcoin/pull/28521#issuecomment-2500740657)
Fixed [tidy complaint](https://cirrus-ci.com/task/4855637697363968?logs=ci#L3329-L3332).

💬 1440000bytes commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2500761664)
Concept ACK

A simple solution to avoid leaking IP address when running tests locally would be to disconnect internet while running tests.

🤔 jonatack reviewed a pull request: "wallet, desc spkm: Return SigningProvider only if we have the privkey"
(https://github.com/bitcoin/bitcoin/pull/31242#pullrequestreview-2461503357)
ACK modulo test coverage, a few suggestions if you repush.

💬 jonatack commented on pull request "wallet, desc spkm: Return SigningProvider only if we have the privkey":
(https://github.com/bitcoin/bitcoin/pull/31242#discussion_r1858519759)
```suggestion
bool FlatSigningProvider::HaveKey(const CKeyID& keyid) const
```

💬 jonatack commented on pull request "wallet, desc spkm: Return SigningProvider only if we have the privkey":
(https://github.com/bitcoin/bitcoin/pull/31242#discussion_r1858520727)
```suggestion
std::unique_ptr<FlatSigningProvider> out = GetSigningProvider(index, /*include_private=*/true);
```

💬 jonatack commented on pull request "wallet, desc spkm: Return SigningProvider only if we have the privkey":
(https://github.com/bitcoin/bitcoin/pull/31242#discussion_r1858519981)
```suggestion
bool HaveKey(const CKeyID& keyid) const override;
```

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r1858539457)
I'll propose a pre-check function and object later today then :)

💬 Sjors commented on pull request "descriptors: MuSig2":
(https://github.com/bitcoin/bitcoin/pull/31244#issuecomment-2500865562)
Can you add an example to `doc/descriptors.md`?

💬 jonatack commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2500872083)
Concept ACK. Per https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2024-11-26#1069602: "it turns out the owners of 1.2.3.4, 11.22.33.44 and 8.8.8.8, if they would bother, would know the IP address of every dev who runs the functional tests at home."

👍 instagibbs approved a pull request: "doc, test: more ephemeral dust follow-ups"
(https://github.com/bitcoin/bitcoin/pull/31371#pullrequestreview-2461615363)
ACK 160799d9135528dbdea40690f0bb0d56c6c4803a

💬 instagibbs commented on pull request "doc, test: more ephemeral dust follow-ups":
(https://github.com/bitcoin/bitcoin/pull/31371#discussion_r1858588114)
micro-nit, no need to invalidate acks
```suggestion
"""Creates a 1P1C package containing ephemeral dust by default. By default, the parent transaction
```

⚠️ theStack opened an issue: "RFC: support for writing UTXO set dump (`dumptxoutset` RPC) to a named pipe"
(https://github.com/bitcoin/bitcoin/issues/31373)
### Please describe the feature you'd like to see added.

While the primary obvious use-case for the `dumptxoutset` RPC is to create AssumeUTXO snapshots (to be distributed and loaded on newly created nodes via the `loadtxoutset` RPC later), it can also be useful as input for external tooling like converters to other UTXO set formats, e.g. https://github.com/bitcoin/bitcoin/pull/27432. For those, the intermediate step of writing a >10GB file to disk and then reading it again is wasteful and anno
...

💬 Sjors commented on pull request "psbt: MuSig2 Fields":
(https://github.com/bitcoin/bitcoin/pull/31247#issuecomment-2500931127)
Maybe add https://github.com/bitcoin/bips/blob/master/bip-0373.mediawiki to description.

💬 0xB10C commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-2500962838)
To fix a potential lifetime issue, it is probably helpful to replace `bpf_usdt_readarg_p()` (which isn't even documented) in:

https://github.com/bitcoin/bitcoin/blob/f7144b24be09e7db2173a0b15d73f99a08b98118/test/functional/interface_usdt_mempool.py#L103-L104

with `bpf_usdt_readarg()` followed by [`bpf_probe_read_user()`](https://github.com/iovisor/bcc/blob/master/docs/reference_guide.md#10-bpf_probe_read_user) or a [`bpf_probe_read_user_str()`](https://github.com/iovisor/bcc/blob/master/do
...

💬 hebasto commented on issue "Unable to compile for test coverage on Nixos 24.05":
(https://github.com/bitcoin/bitcoin/issues/31087#issuecomment-2500966713)
@danielabrozzoni

Could you please post the full output of the `cmake -B build -DCMAKE_BUILD_TYPE=Coverage` command?

💬 0xB10C commented on issue "Tracepoint Interface Tracking Issue":
(https://github.com/bitcoin/bitcoin/issues/31274#issuecomment-2500981683)
There is also #27380 with discussion about a problem in the `interface_usdt_mempool.py` test.

https://github.com/bitcoin/bitcoin/blob/f7144b24be09e7db2173a0b15d73f99a08b98118/test/functional/interface_usdt_mempool.py#L317-L320

A possible fix might be https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-2500962838 - but even if this doesn't fix #27380, it should probably be done.