💬 hodlinator commented on pull request "test: Fix RANDOM_CTX_SEED use with parallel tests":
(https://github.com/bitcoin/bitcoin/pull/30737#issuecomment-2488197113)
Agree that issues here are fixed. For orderliness, maybe the fuzz-part of dfef02f9382579352abcb4fcc8d85170de9f441a from this PR could be done as a new PR just to ensure named folders?

💬 maflcko commented on pull request "test: Fix RANDOM_CTX_SEED use with parallel tests":
(https://github.com/bitcoin/bitcoin/pull/30737#issuecomment-2488253384)
Ah yes. I am happy to review a pull for named folders when fuzzing

🚀 fanquake merged a pull request: "guix: scope pkg-config to Linux only"
(https://github.com/bitcoin/bitcoin/pull/31276)

👍 fanquake approved a pull request: "build: Enable -Wbidi-chars=any"
(https://github.com/bitcoin/bitcoin/pull/31315#pullrequestreview-2448264885)
ACK fa7857ccda5d82739bba16eeb7244433978d28f3

```bash
/root/ci_scratch/src/kernel/cs_main.cpp:8:33: warning: found problematic Unicode character "U+202E (RIGHT-TO-LEFT OVERRIDE)" [-Wbidi-chars=]
8 | RecursiveMutex cs_main; // 1234 <U+202E> 1234 <U+202C>
| ^~~~~~~~
```

🚀 fanquake merged a pull request: "build: Enable -Wbidi-chars=any"
(https://github.com/bitcoin/bitcoin/pull/31315)

💬 maflcko commented on issue "bitcoin-qt failed assertion on startup":
(https://github.com/bitcoin-core/gui/issues/844#issuecomment-2488264917)
There is a reproducer and context in the other thread.

👍 fanquake approved a pull request: "doc: Correct PR Review Club frequency from weekly to monthly"
(https://github.com/bitcoin/bitcoin/pull/31327#pullrequestreview-2448277743)
ACK 637f437a1642ce845d7f750b45b71320a82d83b5

> Should I also update the PR description?

Yes. I've done it now in any case.

🚀 fanquake merged a pull request: "doc: Correct PR Review Club frequency from weekly to monthly"
(https://github.com/bitcoin/bitcoin/pull/31327)

⚠️ fanquake opened an issue: ""heapleakdetection" entry in registry for bitcoin-qt.exe"
(https://github.com/bitcoin-core/gui/issues/845)
Moved from https://github.com/bitcoin/bitcoin/issues/30629.

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

there is an entry indicating there is a heap leak in bitcoin-qt.exe:

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\RADAR\HeapLeakDetection\DiagnosedApplications\bitcoin-qt.exe]
"LastDetectionTime"=hex(b):ce,61,4c,3c,47,bc,da,01

unfortunately no details, also it could be qt related? i hope so :D

### Expected behaviour

...

💬 fanquake commented on issue ""heapleakdetection" entry in registry for bitcoin-qt.exe":
(https://github.com/bitcoin-core/gui/issues/845#issuecomment-2488274177)
Actually the hex LastDetectionTime translates to:

LDAP: 133626153101189582
Epoch/Unix time: 1718141710
GMT: 2024. June 11., Tuesday 21:35:10

so it cannot be v27.1 as it wasn't released yet, i used v27.0 at that time.

✅ fanquake closed an issue: ""heapleakdetection" entry in registry for bitcoin-qt.exe"
(https://github.com/bitcoin/bitcoin/issues/30629)

💬 fanquake commented on issue ""heapleakdetection" entry in registry for bitcoin-qt.exe":
(https://github.com/bitcoin/bitcoin/issues/30629#issuecomment-2488274606)
Not sure what to do here. Given there's been 0 response, moving to the Gui repo: https://github.com/bitcoin-core/gui/issues/845.

👍 brunoerg approved a pull request: "fuzz: Fix difficulty target generation in `p2p_headers_presync`"
(https://github.com/bitcoin/bitcoin/pull/31213#pullrequestreview-2448363822)
code review ACK a6ca8f324396522e9748c9a7bbefb3bf1c74a436

📝 Abdulhafidh-TripleA opened a pull request: "Update README triple A.md"
(https://github.com/bitcoin/bitcoin/pull/31330)
bitcoin to triple A

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements o
...

✅ willcl-ark closed a pull request: "Update README triple A.md"
(https://github.com/bitcoin/bitcoin/pull/31330)

📝 fanquake locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/31330)
bitcoin to triple A

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements o
...

🚀 fanquake merged a pull request: "fuzz: Fix difficulty target generation in `p2p_headers_presync`"
(https://github.com/bitcoin/bitcoin/pull/31213)

📝 fanquake opened a pull request: "doc: add copyright header to p2p_headers_presync"
(https://github.com/bitcoin/bitcoin/pull/31331)
Add the missing copyright header.

👍 willcl-ark approved a pull request: "doc: add copyright header to p2p_headers_presync"
(https://github.com/bitcoin/bitcoin/pull/31331#pullrequestreview-2448419190)
ACK 7d3703dec3d738204257b4eb77e4e83d1c79e23c

🚀 fanquake merged a pull request: "doc: add copyright header to p2p_headers_presync"
(https://github.com/bitcoin/bitcoin/pull/31331)