💬 tdb3 commented on pull request "doc: Correct PR Review Club frequency from weekly to monthly":
(https://github.com/bitcoin/bitcoin/pull/31327#issuecomment-2488136391)
Let's [squash](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) the two commits into one. It makes for a cleaner history when this is merged.

🚀 fanquake merged a pull request: "test: Revert to random path element"
(https://github.com/bitcoin/bitcoin/pull/31317)

💬 hebasto commented on pull request "build: Unify `-logsourcelocations` format":
(https://github.com/bitcoin/bitcoin/pull/30811#issuecomment-2488163342)
I suspect that this change broke OSS-Fuzz coverage build: https://issues.oss-fuzz.com/issues/379122777.

⚠️ fanquake opened an issue: "bitcoin-qt failed assertion on startup"
(https://github.com/bitcoin-core/gui/issues/844)
Moved from https://github.com/bitcoin/bitcoin/issues/31289.

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

I ran bitcoin-qt the same way I always do, but it failed to start up. The terminal shows this:

```
[New Thread 0x7fff337fe6c0 (LWP 4274)]
[New Thread 0x7fff32ffd6c0 (LWP 4275)]
[New Thread 0x7fff327fc6c0 (LWP 4276)]
[New Thread 0x7fff31ffb6c0 (LWP 4277)]
[New Thread 0x7fff317fa6c0 (LWP 4278)]
[New Thread 0x7fff30
...

✅ fanquake closed an issue: "bitcoin-qt failed assertion on startup"
(https://github.com/bitcoin/bitcoin/issues/31289)

💬 fanquake commented on issue "bitcoin-qt failed assertion on startup":
(https://github.com/bitcoin/bitcoin/issues/31289#issuecomment-2488181320)
Moved to https://github.com/bitcoin-core/gui/issues/844.

💬 hodlinator commented on pull request "test: Revert to random path element":
(https://github.com/bitcoin/bitcoin/pull/31317#discussion_r1850037851)
I like the robustness of the current solution. Never know where `SeedRandomForTest` might creep in inside unit/bench/fuzz. Please resolve this.

💬 GabrieleBocchi commented on pull request "doc: Correct PR Review Club frequency from weekly to monthly":
(https://github.com/bitcoin/bitcoin/pull/31327#issuecomment-2488188141)
Thank you @tdb3, I did it. Should I also update the PR description?
This is actually my first contribution to this project, thank you for your guidance and support!

💬 hodlinator commented on pull request "test: Fix RANDOM_CTX_SEED use with parallel tests":
(https://github.com/bitcoin/bitcoin/pull/30737#issuecomment-2488197113)
Agree that issues here are fixed. For orderliness, maybe the fuzz-part of dfef02f9382579352abcb4fcc8d85170de9f441a from this PR could be done as a new PR just to ensure named folders?

💬 maflcko commented on pull request "test: Fix RANDOM_CTX_SEED use with parallel tests":
(https://github.com/bitcoin/bitcoin/pull/30737#issuecomment-2488253384)
Ah yes. I am happy to review a pull for named folders when fuzzing

🚀 fanquake merged a pull request: "guix: scope pkg-config to Linux only"
(https://github.com/bitcoin/bitcoin/pull/31276)

👍 fanquake approved a pull request: "build: Enable -Wbidi-chars=any"
(https://github.com/bitcoin/bitcoin/pull/31315#pullrequestreview-2448264885)
ACK fa7857ccda5d82739bba16eeb7244433978d28f3

```bash
/root/ci_scratch/src/kernel/cs_main.cpp:8:33: warning: found problematic Unicode character "U+202E (RIGHT-TO-LEFT OVERRIDE)" [-Wbidi-chars=]
8 | RecursiveMutex cs_main; // 1234 <U+202E> 1234 <U+202C>
| ^~~~~~~~
```

🚀 fanquake merged a pull request: "build: Enable -Wbidi-chars=any"
(https://github.com/bitcoin/bitcoin/pull/31315)

💬 maflcko commented on issue "bitcoin-qt failed assertion on startup":
(https://github.com/bitcoin-core/gui/issues/844#issuecomment-2488264917)
There is a reproducer and context in the other thread.

👍 fanquake approved a pull request: "doc: Correct PR Review Club frequency from weekly to monthly"
(https://github.com/bitcoin/bitcoin/pull/31327#pullrequestreview-2448277743)
ACK 637f437a1642ce845d7f750b45b71320a82d83b5

> Should I also update the PR description?

Yes. I've done it now in any case.

🚀 fanquake merged a pull request: "doc: Correct PR Review Club frequency from weekly to monthly"
(https://github.com/bitcoin/bitcoin/pull/31327)

⚠️ fanquake opened an issue: ""heapleakdetection" entry in registry for bitcoin-qt.exe"
(https://github.com/bitcoin-core/gui/issues/845)
Moved from https://github.com/bitcoin/bitcoin/issues/30629.

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

there is an entry indicating there is a heap leak in bitcoin-qt.exe:

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\RADAR\HeapLeakDetection\DiagnosedApplications\bitcoin-qt.exe]
"LastDetectionTime"=hex(b):ce,61,4c,3c,47,bc,da,01

unfortunately no details, also it could be qt related? i hope so :D

### Expected behaviour

...

💬 fanquake commented on issue ""heapleakdetection" entry in registry for bitcoin-qt.exe":
(https://github.com/bitcoin-core/gui/issues/845#issuecomment-2488274177)
Actually the hex LastDetectionTime translates to:

LDAP: 133626153101189582
Epoch/Unix time: 1718141710
GMT: 2024. June 11., Tuesday 21:35:10

so it cannot be v27.1 as it wasn't released yet, i used v27.0 at that time.

✅ fanquake closed an issue: ""heapleakdetection" entry in registry for bitcoin-qt.exe"
(https://github.com/bitcoin/bitcoin/issues/30629)

💬 fanquake commented on issue ""heapleakdetection" entry in registry for bitcoin-qt.exe":
(https://github.com/bitcoin/bitcoin/issues/30629#issuecomment-2488274606)
Not sure what to do here. Given there's been 0 response, moving to the Gui repo: https://github.com/bitcoin-core/gui/issues/845.