💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226)
Seems unnecessarily wasteful for all future CPU cycles consumed by this test.

💬 instagibbs commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#discussion_r1848500841)
right. So `consensus_result` :melting_face:

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848518145)
pushed on follow-up

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848522659)
Cheers!

💬 Sjors commented on pull request "rpc: add optional blockhash to waitfornewblock":
(https://github.com/bitcoin/bitcoin/pull/30635#issuecomment-2486082502)
I took @ryanofsky's suggestion: https://github.com/bitcoin/bitcoin/pull/30635#discussion_r1792082432

💬 Sjors commented on pull request "rpc: add optional blockhash to waitfornewblock":
(https://github.com/bitcoin/bitcoin/pull/30635#discussion_r1848615985)
The latest version gets rid of this check entirely.

💬 Sjors commented on pull request "mining: add early return to waitTipChanged()":
(https://github.com/bitcoin/bitcoin/pull/31297#discussion_r1848635656)
In other words:

```
if !tip_changed
wait_for: tip_changed
return new_tip
```

💬 maflcko commented on pull request "test: Revert to random path element":
(https://github.com/bitcoin/bitcoin/pull/31317#discussion_r1848646213)
Yes, this issue is re-introduced.

It can also be tested on top of https://github.com/bitcoin/bitcoin/commit/fa80b08fef0eaa600339caa678fdf80a8aec3ce3 via something like: `RANDOM_CTX_SEED=21 FUZZ=utxo_total_supply ./bld-cmake/src/test/fuzz/fuzz -runs=10 -jobs=2 -workers=2`

I didn't want to fix it, as it was pre-existing and no one complained (at least OSS-Fuzz did not), whereas OSS-Fuzz did complain about the fixed issue.

However, as this is a trivial fix, I've added another commit to do
...

📝 fanquake opened a pull request: "guix: swap `moreutils` for just `sponge`"
(https://github.com/bitcoin/bitcoin/pull/31323)
Switch to building the only `moreutils` utility we actually need (`sponge`). This results in having less unused stuff in the Guix environment (i.e all the other `moreutils` utilities), and, the dependency graph is simplified. i.e we no-longer have a dependency on `perl`, `docbook` etc, for this package.

Current `moreutils` dependency graph:

`sponge` dependency graph:
![sponge](https://github.com
...

💬 hebasto commented on pull request "guix: swap `moreutils` for just `sponge`":
(https://github.com/bitcoin/bitcoin/pull/31323#issuecomment-2486178270)
Concept ACK.

💬 TheCharlatan commented on pull request "guix: swap `moreutils` for just `sponge`":
(https://github.com/bitcoin/bitcoin/pull/31323#issuecomment-2486199683)
Nice, Concept ACK

💬 achow101 commented on pull request "test: Rework wallet_migration.py to use previous releases":
(https://github.com/bitcoin/bitcoin/pull/31248#discussion_r1848730584)
Done

💬 achow101 commented on pull request "test: Rework wallet_migration.py to use previous releases":
(https://github.com/bitcoin/bitcoin/pull/31248#discussion_r1848730720)
Done

💬 achow101 commented on pull request "test: Rework wallet_migration.py to use previous releases":
(https://github.com/bitcoin/bitcoin/pull/31248#discussion_r1848730962)
Done

💬 achow101 commented on pull request "test: Rework wallet_migration.py to use previous releases":
(https://github.com/bitcoin/bitcoin/pull/31248#discussion_r1848731122)
Fixed

💬 achow101 commented on pull request "descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey`":
(https://github.com/bitcoin/bitcoin/pull/31243#discussion_r1848737129)
Done

💬 achow101 commented on pull request "descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey`":
(https://github.com/bitcoin/bitcoin/pull/31243#discussion_r1848737236)
Done

💬 achow101 commented on pull request "descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey`":
(https://github.com/bitcoin/bitcoin/pull/31243#discussion_r1848737391)
Added a TODO

⚠️ lcharles123 opened an issue: "Feature request: Backup of datadir state"
(https://github.com/bitcoin/bitcoin/issues/31324)
### Please describe the feature you'd like to see added.

It will be good to have a option included in bitcoind to backup and restore the current state of the datadir periodically.

### Is your feature related to a problem, if so please describe it.

Not a software problem, but its the environment. Many events can corrupt data inside datadir, to name some: power outages, out of resources (RAM), network fail (in case of network storage).
Once corrupted, it's costly to re-sync it again from scra
...

💬 achow101 commented on pull request "wallet: Remove IsMine from migration code":
(https://github.com/bitcoin/bitcoin/pull/30328#discussion_r1848782223)
Hmm, the test that is supposed to fail here is passing because the P2WSH scriptPubKey also ends up in the `setWatchOnly` so it is added when we iterate those.

I think if the wallet was used normally, this loop probably isn't necessary. However, I am hesitant to remove it as in theory, if a P2WSH were in `mapScripts` and not in `setWatchOnly`, we would miss it but `IsMine()` would've still allowed it. I think the only way to get that though is through direct modification of the wallet file or
...