✅ fanquake closed a pull request: "refactor: spanify DecodeBits, use constexpr std::array instead of vector"
(https://github.com/bitcoin/bitcoin/pull/31302)

💬 Sjors commented on pull request "Drop script_pub_key arg from createNewBlock":
(https://github.com/bitcoin/bitcoin/pull/31318#issuecomment-2485792072)
Afaik the only way external users make blocks today is the `getblocktemplate` RPC, which drops the coinbase transaction from the template it returns.

Similarly in `submitSolution`, used by Stratum v2, we expect to receive the full coinbase transaction and replace whatever was in the `CBlockTemplate`.

Unless you're solo mining, the pool is going to add its own outputs, manipulate the extra nonce, add its own name, etc. Even with a solo pool (a weird concept) you would configure the payout a
...

💬 fanquake commented on pull request "depends: Update minimum required CMake version":
(https://github.com/bitcoin/bitcoin/pull/31300#issuecomment-2485792150)
> The selected versions in the patches seem random, why not pick the same value for all of them?

Yea. If anything, just consolidate to the same minimum required version as Core.

💬 GIgako19929 commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2485804884)
This pull request introduces a new RPC method, `getdescriptoractivity`, and includes several related changes. The most important changes are the addition of the new RPC method, updates to documentation, and the introduction of a new utility function.

### New RPC Method:
* Added the `getdescriptoractivity` RPC method to retrieve spend and receive activity for a set of descriptors within specified blocks. This method works in conjunction with the `scanblocks` RPC to reduce the need for additio
...

💬 GIgako19929 commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2485806660)
This pull request introduces a new RPC method, `getdescriptoractivity`, which provides detailed information on spend and receive activities for specified descriptors and blocks. Additionally, it includes several related updates to the codebase and documentation.

### New RPC Method:
* `getdescriptoractivity` RPC method: This new method allows users to find all spend/receive activity relevant to a given set of descriptors within specified blocks. It pairs well with the `scanblocks` method to r
...

💬 instagibbs commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1848424503)
yep feel free to not do this one for now (I just ran into it writing my own test case)

💬 GIgako19929 commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2485817184)
This pull request introduces a new RPC method, `getdescriptoractivity`, and includes various related updates to the documentation and codebase. The most important changes include the addition of the new RPC method, updates to the documentation to reflect this new method, and code improvements to support the new feature.

### New RPC Method:

* Added `getdescriptoractivity` RPC method to retrieve spend and receive activity for a set of descriptors within specified blocks. This method pairs wi
...

💬 Sjors commented on pull request "mining: add early return to waitTipChanged()":
(https://github.com/bitcoin/bitcoin/pull/31297#discussion_r1848440029)
I'm assuming `wait_for` won't be triggered until `m_tip_block` is set or modified, or the timeout passes. So it doesn't return early.

✅ fanquake closed a pull request: "Typo Update bitcoin-conf.md"
(https://github.com/bitcoin/bitcoin/pull/31322)

💬 hebasto commented on pull request "cmake: Set top-level target output locations":
(https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2485835136)
Rebased on top of the https://github.com/bitcoin/bitcoin/pull/31307 to workaround MSVC compiler issue.

💬 fanquake commented on pull request "build: Enable -Wbidi-chars=any":
(https://github.com/bitcoin/bitcoin/pull/31315#issuecomment-2485840546)
Concept ACK - looks like GH also tries to warn about this.

💬 instagibbs commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2485845484)
light review Ack 878b6c85466366c4ae5f454ec49b5a5f561e0ed2

Reviewed tests and interface mostly

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226)
Seems unnecessarily wasteful for all future CPU cycles consumed by this test.

💬 instagibbs commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#discussion_r1848500841)
right. So `consensus_result` :melting_face:

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848518145)
pushed on follow-up

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848522659)
Cheers!

💬 Sjors commented on pull request "rpc: add optional blockhash to waitfornewblock":
(https://github.com/bitcoin/bitcoin/pull/30635#issuecomment-2486082502)
I took @ryanofsky's suggestion: https://github.com/bitcoin/bitcoin/pull/30635#discussion_r1792082432

💬 Sjors commented on pull request "rpc: add optional blockhash to waitfornewblock":
(https://github.com/bitcoin/bitcoin/pull/30635#discussion_r1848615985)
The latest version gets rid of this check entirely.

💬 Sjors commented on pull request "mining: add early return to waitTipChanged()":
(https://github.com/bitcoin/bitcoin/pull/31297#discussion_r1848635656)
In other words:

```
if !tip_changed
wait_for: tip_changed
return new_tip
```

💬 maflcko commented on pull request "test: Revert to random path element":
(https://github.com/bitcoin/bitcoin/pull/31317#discussion_r1848646213)
Yes, this issue is re-introduced.

It can also be tested on top of https://github.com/bitcoin/bitcoin/commit/fa80b08fef0eaa600339caa678fdf80a8aec3ce3 via something like: `RANDOM_CTX_SEED=21 FUZZ=utxo_total_supply ./bld-cmake/src/test/fuzz/fuzz -runs=10 -jobs=2 -workers=2`

I didn't want to fix it, as it was pre-existing and no one complained (at least OSS-Fuzz did not), whereas OSS-Fuzz did complain about the fixed issue.

However, as this is a trivial fix, I've added another commit to do
...