💬 hodlinator commented on pull request "test: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2484340220)
Thanks @m3dwards for having a look!

I had not tested the case of *bitcoind* exiting early together with my suggested change here (focused more on stalling as in one of the issues inspiring it).

Made some changes to this part of `TestNode.stop_node()` to handle an already dead process:

https://github.com/bitcoin/bitcoin/blob/ba28593147ccc880c3a4d40db0d4ef57f4766254/test/functional/test_framework/test_node.py#L412-L420

With those changes, the output for such a case is now:

<details>
...

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31320)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31320)

⚠️ Justin11111a opened an issue: "Segmentation fault when ./bitcoind"
(https://github.com/bitcoin/bitcoin/issues/31321)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Error Run Bitcoind deamon after compile on ubuntu 22

1. compile depend
2. compile daemon
3. run ./bitcoind show error below

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7e4b5ee in std::_Rb_tree_decrement(std::_Rb_tree_node_base const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6

### Expected behaviour

Running as normal

### Steps to reproduce

1. compile de
...

💬 CaseyCarter commented on issue "MSVC 17.12.0 internal compiler error ":
(https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2484420880)
I dug through the logs for yesterday's nightly run, and the trunk compiler built `utxo_snapshot.cpp` just fine. I see: we onboarded bitcoin on 2024-10-22. It's likely the 17.12 compilers have never seen it. Sorry about the regression; go ahead and file a report at https://developercommunity.visualstudio.com/cpp/report and we'll see if we can get it serviced quickly.

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2484428814)
Can someone rerun the windows job? Now that I'm not a member of the org, I can't kick CI Jobs.

💬 furszy commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#discussion_r1847463412)
nit:
This isn't from the PR but `i` is an unsigned integer, so this second `i==0` is redundant.

💬 glozow commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1847535823)
That makes sense, thanks. I wanted to clarify what was meant by "all" additions and removals.

💬 glozow commented on issue "Package Relay Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/27463#issuecomment-2484571009)
Update similar to my irc update: there are a few possible next steps including (1) rebasing #28031 to start adding the orphan resolution module (2) making `TxDownloadManager` internally thread-safe (3) finishing up the one_honest_peer fuzzer.

Nothing is open for review right now as I am a bit busy with other things and still deciding what to do next.

👍 lucasbalieiro approved a pull request: "cmake: Improve robustness and usability"
(https://github.com/bitcoin/bitcoin/pull/31233#pullrequestreview-2444224077)
Hi, @hebasto!

tACK Commit [4b6a842](https://github.com/bitcoin/bitcoin/pull/31233/commits/4b6a842c28010a00e121fd36cc0b4e1fa658d249)

I have successfully run the build modifications on my machine:

**Distributor:** Ubuntu
**Version:** 22.04.5 LTS
**Release:** 22.04
**Codename:** Jammy

The build completed without any warnings or errors. I also ran the tests both with and without Python, and the console responses were as expected. Please see the attached images for further detail
...

💬 maflcko commented on pull request "build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31307#issuecomment-2484864282)
I'd say this is fine to merge even without an upstream report. Even if there was one, it will take some time (weeks?) to propagate the fix. Blocking the CI for this repo on that seems not ideal.

💬 maflcko commented on issue "Segmentation fault when ./bitcoind":
(https://github.com/bitcoin/bitcoin/issues/31321#issuecomment-2484868095)
What are the exact steps to reproduce? What is the traceback?

👍 BrandonOdiwuor approved a pull request: "Decouple WalletModel from RPCExecutor"
(https://github.com/bitcoin-core/gui/pull/841#pullrequestreview-2444475869)
tACK 002b792b9a85100d89e47706c29cf1fd355d9727

Was able to build successfully on Ubuntu 24.04 with Qt version 5.15.13 with `-DENABLE_WALLET=OFF` and `-BUILD_GUI=ON` flags and was able to successfully try a couple of RPCs on the GUI RPC console


💬 maflcko commented on pull request "refactor: Fix remaining clang-tidy performance-inefficient-vector errors":
(https://github.com/bitcoin/bitcoin/pull/31305#discussion_r1847956841)
> Are you saying this will affect fuzzing behavior?

No, I was thinking that this may slow down the fuzz target, but I don't see any difference when running over `./fuzz_corpora/txorphan`, so I guess this doesn't matter.

(Since you are asking, yes, this may influence the fuzz engine behavior. The reason is that the standard library is also annotated with coverage feedback, so a memory reallocation may count as a coverage increase)

💬 maflcko commented on pull request "refactor: Fix remaining clang-tidy performance-inefficient-vector errors":
(https://github.com/bitcoin/bitcoin/pull/31305#issuecomment-2485135779)
lgtm ACK 01e54b7d82a053238b62121eeba2ac2c45b88859

💬 fanquake commented on pull request "build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31307#issuecomment-2485281314)
Not blocking, but we can leave #31303 open until an upstream report is filed.

💬 Sjors commented on pull request "Add multiprocess binaries to release build":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2485303923)
@hebasto I don't understand.

🚀 fanquake merged a pull request: "build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC"
(https://github.com/bitcoin/bitcoin/pull/31307)

💬 hebasto commented on pull request "Add multiprocess binaries to release build":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2485333241)
> @hebasto I don't understand.

`make -C depends HOST=arm-linux-gnueabihf` does not build multiprocess package.

💬 Sjors commented on pull request "Drop script_pub_key arg from createNewBlock":
(https://github.com/bitcoin/bitcoin/pull/31318#issuecomment-2485334909)
Forgot to modify `mining.capnp`.