⚠️ MORTEZAMIRSALI opened an issue: "Officials of the organization pay attention, just as you guarantee health here, how do you not prevent the invasion of wild animals into the reservoirs related to me? This double action means that no person, whether he was already working or later, enters, or no organization has the right to interfere in the related reservoirs. They don't have the original owner in your repositories, destroy my assets, Twitter changed all my tokens, took my possessions, on the other hand, pay attention to the jackals' support, there have been several crashes today, 400 bitcoins have been mined, destroy them all, why without the permission of the owner, the right to enter address and interests, you should organize and make laws according to my property, everyone is in line to destroy, even tonspn is not "
(https://github.com/bitcoin/bitcoin/issues/31319)

💬 MORTEZAMIRSALI commented on issue "Officials of the organization pay attention, just as you guarantee health here, how do you not prevent the invasion of wild animals into the reservoirs related to me? This double action means that no person, whether he was already working or later, enters, or no organization has the right to interfere in the related reservoirs. They don't have the original owner in your repositories, destroy my assets, Twitter changed all my tokens, took my possessions, on the other hand, pay attention to the jackals' support, there have been several crashes today, 400 bitcoins have been mined, destroy them all, why without the permission of the owner, the right to enter address and interests, you should organize and make laws according to my property, everyone is in line to destroy, even tonspn is not ":
(https://github.com/bitcoin/bitcoin/issues/31319#issuecomment-2484216000)
balanced and the main owner's financial interests are targeted, Bitcoin is the same, please check all the vandalism of the reservoirs, no one who uses blockchain without the permission of the owner How can the principal destroy interests?

✅ achow101 closed an issue: "Officials of the organization pay attention, just as you guarantee health here, how do you not prevent the invasion of wild animals into the reservoirs related to me? This double action means that no person, whether he was already working or later, enters, or no organization has the right to interfere in the related reservoirs. They don't have the original owner in your repositories, destroy my assets, Twitter changed all my tokens, took my possessions, on the other hand, pay attention to the jackals' support, there have been several crashes today, 400 bitcoins have been mined, destroy them all, why without the permission of the owner, the right to enter address and interests, you should organize and make laws according to my property, everyone is in line to destroy, even tonspn is not "
(https://github.com/bitcoin/bitcoin/issues/31319)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31319)

🤔 hodlinator reviewed a pull request: "util: Improve documentation and negation of args"
(https://github.com/bitcoin/bitcoin/pull/31212#pullrequestreview-2443807751)
Thanks for continued review and reminding me to raise the bar for the PR @ryanofsky.

Added tests which helped uncover that *bitcoin-cli* might as well also support `-norpccookiefile` too, and part of *src/common/init.cpp* which was not handling `-noconf` correctly.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1847330326)
Fixed in latest push. Also switched from `ifstream::peek()` to `fs::is_directory()` after verifying the latter returns true for directory-symlinks as well.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1847326060)
Thanks! Implemented in latest push with some variation.

💬 hodlinator commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1847328295)
Thanks for catching this. Was not my intention to leave the door wide open when users pass `-norpccookiefile`. :man_facepalming:
Keep a belt & suspenders `bool` in latest push.

💬 kevkevinpal commented on pull request "test: Revert to random path element":
(https://github.com/bitcoin/bitcoin/pull/31317#issuecomment-2484236327)
tACK [fa80b08](https://github.com/bitcoin/bitcoin/pull/31317/commits/fa80b08fef0eaa600339caa678fdf80a8aec3ce3)

was able to reproduce the crash from https://github.com/bitcoin/bitcoin/pull/31317#issuecomment-2483056878 locally on my machine. Reviewed and ran the code aswell and it looks good to me

🤔 furszy reviewed a pull request: "Improve parallel script validation error debug logging"
(https://github.com/bitcoin/bitcoin/pull/31112#pullrequestreview-2443818466)
Concept ACK. Getting deeper.

💬 furszy commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#discussion_r1847332068)
nit: could also test that only the first found error is retrieved. Checking in this way that no further `check()`s are executed.

💬 hodlinator commented on pull request "test: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#discussion_r1847351945)
I am still working on this PR. Not thrilled about removing the 3 comment strings predating this PR.

🤔 theStack reviewed a pull request: "cmake: Set top-level target output locations"
(https://github.com/bitcoin/bitcoin/pull/31161#pullrequestreview-2443913213)
Did some quick testing on Ubuntu 22.04 LTS and OpenBSD 7.6, verifying that the binaries end up in a single place as expected:
```
$ ls ./build/bin/
bitcoin-cli bitcoin-util bitcoind noverify_tests test_bitcoin unitester
bitcoin-tx bitcoin-wallet exhaustive_tests object tests
```
Not sure how people feel about binaries from subtree projects al
...

⚠️ hoailinhle opened an issue: "utACK af049b2b52a93dcd05a78c381510534b0c52b4de"
(https://github.com/bitcoin/bitcoin/issues/31320)
utACK af049b2b52a93dcd05a78c381510534b0c52b4de

I believe there are no downsides to this, except for making the signing time double on average. It reduces the entropy in the nonce slightly, but not in a way that is usable to an attacker as far as I can tell.

Comments, @gmaxwell, @apoelstra ?

_Originally posted by @sipa in https://github.com/bitcoin/bitcoin/issues/13666#issuecomment-405108732_

💬 hodlinator commented on pull request "test: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2484340220)
Thanks @m3dwards for having a look!

I had not tested the case of *bitcoind* exiting early together with my suggested change here (focused more on stalling as in one of the issues inspiring it).

Made some changes to this part of `TestNode.stop_node()` to handle an already dead process:

https://github.com/bitcoin/bitcoin/blob/ba28593147ccc880c3a4d40db0d4ef57f4766254/test/functional/test_framework/test_node.py#L412-L420

With those changes, the output for such a case is now:

<details>
...

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31320)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31320)

⚠️ Justin11111a opened an issue: "Segmentation fault when ./bitcoind"
(https://github.com/bitcoin/bitcoin/issues/31321)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Error Run Bitcoind deamon after compile on ubuntu 22

1. compile depend
2. compile daemon
3. run ./bitcoind show error below

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7e4b5ee in std::_Rb_tree_decrement(std::_Rb_tree_node_base const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6

### Expected behaviour

Running as normal

### Steps to reproduce

1. compile de
...

💬 CaseyCarter commented on issue "MSVC 17.12.0 internal compiler error ":
(https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2484420880)
I dug through the logs for yesterday's nightly run, and the trunk compiler built `utxo_snapshot.cpp` just fine. I see: we onboarded bitcoin on 2024-10-22. It's likely the 17.12 compilers have never seen it. Sorry about the regression; go ahead and file a report at https://developercommunity.visualstudio.com/cpp/report and we'll see if we can get it serviced quickly.

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#issuecomment-2484428814)
Can someone rerun the windows job? Now that I'm not a member of the org, I can't kick CI Jobs.