✅ achow101 closed an issue: "سلام من ابتدای ۳۴۸۶۶ را با شوکت فرزند موسی ویدا فرزند علی پگاه فرزند جلال در صنعت دریای حفاری و کشتیرانی ودر زمینه محاسبات حورا فرزند علی پرویز اسم باباشو یادم نیست و دبیر ریاضیم اقای امروانی که فامیلیشو عوض کرد و خرید یک جایگاه دیگه ۳۴۸۶۶ از پول اولین بالانس ۶ تا تقصیم سلولی برای خودم هستم . "
(https://github.com/bitcoin/bitcoin/issues/31309)

:lock: achow101 locked an issue: "سلام من ابتدای ۳۴۸۶۶ را با شوکت فرزند موسی ویدا فرزند علی پگاه فرزند جلال در صنعت دریای حفاری و کشتیرانی ودر زمینه محاسبات حورا فرزند علی پرویز اسم باباشو یادم نیست و دبیر ریاضیم اقای امروانی که فامیلیشو عوض کرد و خرید یک جایگاه دیگه ۳۴۸۶۶ از پول اولین بالانس ۶ تا تقصیم سلولی برای خودم هستم . "
(https://github.com/bitcoin/bitcoin/issues/31309)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31310)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31310)

💬 pythcoiner commented on pull request "wallet: BIP 326 sequence based anti-fee-snipe for taproot inputs":
(https://github.com/bitcoin/bitcoin/pull/24128#issuecomment-2481930460)
tACK faf4c7107bafc8b0db48909f37e4a242107b804a modulo rebase
reviewed & write [this tests](https://github.com/pythcoiner/bitcoin_tests/blob/24128/src/main.rs) that verify:
- when all inputs are taproot anti fee sniping is 50/50 nSequence/nLockTime
- when nSequence, the input index is randomly chosen
- when nLocktime, 10% are 1-100 blocks behind the current height
- when there is some non-taproot inputs, anti fee sniping is always nLocktime
- when there is some non-confirmed in
...

💬 maflcko commented on pull request "refactor: convert ContainsNoNUL to ContainsNUL":
(https://github.com/bitcoin/bitcoin/pull/31301#discussion_r1846027455)
I guess once there is C++23, we could just remove this function and use `str.contains('\0')` directly everywhere instead of `ContainsNUL(str)`? If so, a simple comment to say so may be sufficient to avoid having to touch the same lines twice?

💬 naumenkogs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1846051102)
Weird UI indeed, i left a reply and I'll try to monitor that thread now.

💬 maflcko commented on pull request "build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31307#issuecomment-2482232825)
lgtm ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817

💬 maflcko commented on issue "MSVC 17.12.0 internal compiler error ":
(https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2482236115)
According to https://github.com/bitcoin/bitcoin/pull/27930#issuecomment-1602985185 MSVC is including Bitcoin Core in an internal test-suite, but I guess they are not compiling the fuzz tests? cc @CaseyCarter

💬 naumenkogs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2482237418)
ACK 5679f398e2a3ab8315d39ee674ccb8ad6a8f73c7

💬 naumenkogs commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#issuecomment-2482268618)
ACK https://github.com/bitcoin/bitcoin/commit/5736d1ddacc4019101e7a5170dd25efbc63b622a

My concern above was related to LimitMempoolSize(), but indeed it's easy to see it doesn't happen between the two `m_changeset->Apply()` calls .

💬 maflcko commented on pull request "refactor: Fix remaining clang-tidy performance-inefficient-vector errors":
(https://github.com/bitcoin/bitcoin/pull/31305#issuecomment-2482277836)
lgtm ACK 9cb24f82cf88607e289bd53833a9bb0976653b26

💬 CaseyCarter commented on issue "MSVC 17.12.0 internal compiler error ":
(https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2482280615)
I see a ` -DBUILD_FUZZ_BINARY=ON` in the setup, which suggests to me that we are at least building the fuzz tests. We are, however, at 0ca1d1b which seems to be about a month old. Our Real-World-Code projects don't live at head, they jump forward periodically. Is this a recent regression?

💬 maflcko commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/31306#discussion_r1846091005)
Not sure about using releases which are basically EOL in less than 6 months after the release branch is created. This requires touching the release branches to bump those along.

My preference would be to use `APT_LLVM_V`

💬 maflcko commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/31306#discussion_r1846097750)
are you sure this is correct? Not that it matters, but isn't it theoretically pessimising in `ExpectSuccess(StrFn(Untranslated("S"), true), {}, Untranslated("S"));`?

📝 sipsorcery opened a pull request: "Simplify constructor in fuzz test to help msvc compiler frontend parser."
(https://github.com/bitcoin/bitcoin/pull/31311)
Resolves #31303.

💬 maflcko commented on pull request "Simplify constructor in fuzz test to help msvc compiler frontend parser.":
(https://github.com/bitcoin/bitcoin/pull/31311#discussion_r1846128048)
It is easy to see that this code was generated by an LLM (https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2481584659), because it is wrong.

Luckily CI should catch this error.

📝 BrandonOdiwuor opened a pull request: "test: run functional tests from ctest"
(https://github.com/bitcoin/bitcoin/pull/31312)
Fixes https://github.com/bitcoin/bitcoin/issues/18816

This PR enables functional tests to be included in the ctest suite when the ENABLE_FUNCTIONAL_TESTS flag is set to ON during the CMake configuration.

i.e
```
cmake -B build -DENABLE_FUNCTIONAL_TESTS=ON
cmake --build build
ctest --test-dir build
```

💬 sipsorcery commented on pull request "Simplify constructor in fuzz test to help msvc compiler frontend parser.":
(https://github.com/bitcoin/bitcoin/pull/31311#discussion_r1846137713)
Whoops, I did inspect but yes, missed the static keyword getting dropped. Guess it will need to wait for an msvc fix then.

✅ sipsorcery closed a pull request: "Simplify constructor in fuzz test to help msvc compiler frontend parser."
(https://github.com/bitcoin/bitcoin/pull/31311)