💬 maflcko commented on pull request "test: enable running independent functional test sub-tests":
(https://github.com/bitcoin/bitcoin/pull/30991#issuecomment-2475784402)
review ACK 409d0d629378c3e23388ed31516376ad1ae536b5

💬 naumenkogs commented on pull request "validation: Remove RECENT_CONSENSUS_CHANGE validation result":
(https://github.com/bitcoin/bitcoin/pull/31269#issuecomment-2475789631)
ACK https://github.com/bitcoin/bitcoin/commit/e80e4c6ff91e27d7d40f099a2d7942c29085234c

🚀 fanquake merged a pull request: "validation: Remove RECENT_CONSENSUS_CHANGE validation result"
(https://github.com/bitcoin/bitcoin/pull/31269)

💬 TheCharlatan commented on pull request "guix: scope pkg-config to Linux only":
(https://github.com/bitcoin/bitcoin/pull/31276#issuecomment-2475883027)
Guix build (aarch64):
```
a9e1f628dd64913209e6f55f183453b046c91e44fb959ea61e0c40c0a8457e98 guix-build-2833befb7822/output/aarch64-linux-gnu/SHA256SUMS.part
d082fbc96abb72a4bb0495833b6361d1ab61f8eefc3423571589920ed6c89678 guix-build-2833befb7822/output/aarch64-linux-gnu/bitcoin-2833befb7822-aarch64-linux-gnu-debug.tar.gz
6d94622d87e86ceef908e2b05435ac7f0e4b7f3d224454f619155e44c36128b9 guix-build-2833befb7822/output/aarch64-linux-gnu/bitcoin-2833befb7822-aarch64-linux-gnu.tar.gz
ca288057fc
...

💬 fanquake commented on pull request "guix: remove `util-linux`":
(https://github.com/bitcoin/bitcoin/pull/31285#issuecomment-2475890313)
> Of those, hexdump was required

Thanks, that is what I'd been looking for, but missed in the list 😅.

🚀 fanquake merged a pull request: "tinyformat: Add compile-time checking for literal format strings"
(https://github.com/bitcoin/bitcoin/pull/31174)

✅ fanquake closed an issue: "Unit test failures when using multiple jobs and RANDOM_CTX_SEED"
(https://github.com/bitcoin/bitcoin/issues/30696)

🚀 fanquake merged a pull request: "doc: Fix grammatical errors in multisig-tutorial.md"
(https://github.com/bitcoin/bitcoin/pull/31225)

💬 laanwj commented on issue "Tracepoint Interface Tracking Issue":
(https://github.com/bitcoin/bitcoin/issues/31274#issuecomment-2476023531)
> We could internalize the relevant macro parts of systemtap's sys/sdt.h for the Linux tracepoints. This would allow us to drop the external dependency on systemtap

This still makes sense to me, it's just a few macros which haven't changed in years and are super unlikely to change significantly, because they insert ELF annotations (according to a well-known spec) and NOP instructions.

Dropping a guix dependency would be good!

But this is just Linux. i don't know how it is for other plat
...

🤔 BrandonOdiwuor reviewed a pull request: "cmake: add optional source files to bitcoin_crypto directly"
(https://github.com/bitcoin/bitcoin/pull/31268#pullrequestreview-2435763802)
Approach ACK. Great catch!

Nice simplification! Adding the optional source files directly to `bitcoin_crypto` eliminating the need for intermediate libraries like `bitcoin_crypto_sse41, bitcoin_crypto_avx2, and bitcoin_crypto_x86_shani`

💬 laanwj commented on issue "RFC: Adopt C++ Safe Buffers?":
(https://github.com/bitcoin/bitcoin/issues/31272#issuecomment-2476047174)
> However, this requires using the standard library containers or primitives to represent buffers. For example, instead of using a raw C-array, std::array should be preferred. Also, instead of using a raw C-pointer, std::span should be preferred.

i think we've already been going in this direction for quite a while.

💬 laanwj commented on issue "guix: Linux and macOS builds are not cross-arch reproducible with powerpc64le build arch":
(https://github.com/bitcoin/bitcoin/issues/31207#issuecomment-2476057139)
> I would be happy to upload my binaries

Yes, please do. i'm happy to try to help find the difference but i don't have access to a ppc64 system.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#issuecomment-2476081352)
> Instead I was worried about evictions (i can't think of other side effects) of add/remove invalid stuff. Doesn't this allow to clear the victims mempool for free?

Just to be clear, in case anyone has lost track: we're specifically talking about a codepath we believe is not possible to trigger, namely one where the `PolicyScriptChecks` pass yet the `ConsensusScriptChecks` fail for some transaction, and someone is able to submit such a transaction as part of a package to our node.

In this
...

💬 TheCharlatan commented on pull request "guix: scope pkg-config to Linux only":
(https://github.com/bitcoin/bitcoin/pull/31276#issuecomment-2476093725)
Looks like we could could also get rid of the pkgconfig hints in the toolchain file: https://github.com/TheCharlatan/bitcoin/commit/1a6724af305122973efcc8a329e98f41077314a2 (did a guix build with this patch too).

📝 maflcko opened a pull request: "refactor: Avoid std::string format strings"
(https://github.com/bitcoin/bitcoin/pull/31287)
This changes some unchecked `std::string` format strings to use string literals, which are `consteval` checked at compile-time.

Split out, because it is used in several pull requests.

💬 TheCharlatan commented on pull request "refactor: Make node_id a const& in RemoveBlockRequest":
(https://github.com/bitcoin/bitcoin/pull/31282#discussion_r1842093313)
Why not keep using clang for this job?

💬 maflcko commented on pull request "refactor: Make node_id a const& in RemoveBlockRequest":
(https://github.com/bitcoin/bitcoin/pull/31282#discussion_r1842104265)
It requires adding a suppression, or some other workaround at some point, see https://github.com/bitcoin/bitcoin/issues/29635#issuecomment-2047861599

Given that GCC does not require suppressions, it may be preferable for now.

Though, I am happy to drop the commit, and leave it for a follow-up. I just thought, it would be nice to include here, so that testing is easy for those that want.

💬 laanwj commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2476182650)
> @laanwj suggested to post the utxoset when it gets corrupted again, will do that when it does.

It might (or might not) give some insight into the kind of corruption happening, or whether it's a result of a software bug. Mind that leveldb's writing behavior is very predictable: it only ever appends to files, it doesn't do random writes.

💬 laanwj commented on pull request "rpc: increase the defaults for -rpcthreads and -rpcworkqueue":
(https://github.com/bitcoin/bitcoin/pull/31215#issuecomment-2476206670)
> The higher limits won't increase memory unless they are being used. And these defaults can be set lower on memory constrained systems to disable using them.

Not entirely true, every thread has some memory and overhead, even if it's not doing anything. On 32-bit systems the virtual memory space for the stack space of each thread is also significant.

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#discussion_r1842122891)
Done