💬 marcofleon commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2474371365)
From various fuzz runs:

<details>
<summary>stack trace 1</summary>

```
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==1654160==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000010 (pc 0x7f4ed8ac0563 bp 0x7ffd7bdeff90 sp 0x7ffd7bdefba8 T1654160)
==1654160==The signal is caused by a READ memory access.
==1654160==Hint: address points to the zero page.
#0 0x7f4ed8ac0563 in std::_Rb_tree_rebalance_for_erase(std::_Rb_tree_node_base*, std::_Rb_tree_node_base&) (/lib/x86
...

💬 instagibbs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2474376868)
@marcofleon to be clear this is happening on master or follow-up?

💬 laanwj commented on pull request "guix: remove `util-linux`":
(https://github.com/bitcoin/bitcoin/pull/31285#issuecomment-2474381820)
Concept ACK

Does this make a difference to the build env?
i wonder if util-linux is somehow coming in through the closure of one of the other packages, it seems such a base thing

💬 maflcko commented on pull request "ci: Skip broken Wine64 tests by default":
(https://github.com/bitcoin/bitcoin/pull/31284#issuecomment-2474383795)
Checked that `RUN_UNIT_TESTS=true MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_win64.sh" ./ci/test_run_all.sh` still works.

💬 instagibbs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2474385001)
ok replicated on this PR, I'll track it down

💬 marcofleon commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2474387376)
Yeah not on master, just this PR.

💬 marcofleon commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#issuecomment-2474394030)
It seems to be commit 7f0d8633b174c8b96cc28ec05005b8e89ab4957d

💬 marcofleon commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#discussion_r1840960818)
It's this commit here that's causing the errors. Seems that this was actually needed.

💬 fanquake commented on pull request "guix: remove `util-linux`":
(https://github.com/bitcoin/bitcoin/pull/31285#issuecomment-2474401790)
> Does this make a difference to the build env?

Yea, it's pruning out`util-linux`. See here for a diff of `/bin` of the profile of master vs this PR: https://gist.github.com/fanquake/2785035aeab228a1d6046dbbdd55f299, for `x86_64-linux-gnu`.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#issuecomment-2474424857)
Just rebased this on master -- @0xB10C thanks for the note on the tracepoint change. @instagibbs I think I could rewrite the `CheckEphemeralSpends()` code to take advantage of the changesets for package validation (since we will now be maintaining a map of package transactions that we can query), but maybe that can be done in a separate PR? Just left that code as-is for now.

💬 laanwj commented on pull request "guix: remove `util-linux`":
(https://github.com/bitcoin/bitcoin/pull/31285#issuecomment-2474441538)
Nice!

Of those, `hexdump` was required with the autotools build system. Not sure about others.

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1841026397)
Sure, looks like tests can be rewritten for it not to be needed. Will address in the next push

💬 polespinasa commented on pull request "Wallet: "listreceivedby*" fix":
(https://github.com/bitcoin/bitcoin/pull/30972#issuecomment-2474535023)
Lgtm
Tested ack

I ran the unit test and functional test (without bdb) and all pass.
Also tested manually using regtest the steps in function ``test_listreceivedby`` and the behaviour is the expected.

👍 instagibbs approved a pull request: "cluster mempool: Implement changeset interface for mempool"
(https://github.com/bitcoin/bitcoin/pull/31122#pullrequestreview-2434231838)
ACK 5736d1ddacc4019101e7a5170dd25efbc63b622a

Picks up TRACEPOINT and ephemeral dust stuff.

via `git range-diff master 0ca1e05d8bcbc42892156c15f128a5f829e9e48e 5736d1ddacc4019101e7a5170dd25efbc63b622a`

💬 instagibbs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#discussion_r1841060999)
specifically needs the `SyncWithValidationInterfaceQueue`, not the unused part.

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#issuecomment-2474606749)
I pushed a commit refactoring `miner_tests` to use the `Mining` interface. I plan to expand those tests to cover `waitNext()`.

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#discussion_r1841070497)
a316ba58cba5df8aadb05737959b97eeb6a350b4: I think dropping this doesn't matter?

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#discussion_r1841075744)
a316ba58cba5df8aadb05737959b97eeb6a350b4: I'm tempted to use `miner.submitSolution()` here.

💬 Sjors commented on issue "Bitcoin Core "not opened" after software update to macOS Sequoia 15.0.1 (24A348)":
(https://github.com/bitcoin/bitcoin/issues/31069#issuecomment-2474702003)
@sipa afaik self-signing should only be needed for the tar download, which has bitcoind, bitcoin-qt, etc. It should not be needed for the main zip release. I'm also unable to start the downloaded version on my new M4 mac. Looks like #15774 got a lot worse as of macOS 15.1.

The way to work around it now is to go to Security Settings. It will show you Bitcoin Core was blocked from starting, and you can click Open Anyway. This really requires being careful about how you go the binary obviously.

💬 Sjors commented on issue "macOS App Notarization & Stapling":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-2474704643)
Ah great, anyone macOS release, another pain increase.

I'm also unable to start the downloaded version on my new M4 mac running macOS 15.1.

The option-click workaround no longer works. The new way is just open it, dismiss the error. Then go to Security Settings. It will show you Bitcoin Core was blocked from starting, and you can click Open Anyway.