👍 rkrux approved a pull request: "doc: correct typos"
(https://github.com/bitcoin/bitcoin/pull/31271#pullrequestreview-2427587276)
ACK 726cbee9553b25bedfef70cfd5be9f1eeec8a30d

🚀 fanquake merged a pull request: "cmake: Revamp `FindLibevent` module"
(https://github.com/bitcoin/bitcoin/pull/31181)

💬 maflcko commented on pull request "bench: add support for custom data directory":
(https://github.com/bitcoin/bitcoin/pull/31000#issuecomment-2468455953)
re-ACK 6c7b3bf0ce7a6238457dd44ee1d5d744b3663a52

💬 furszy commented on pull request "test: report detailed msg during utf8 response decoding error":
(https://github.com/bitcoin/bitcoin/pull/31251#discussion_r1836872860)
sure, done as suggested. Thanks

💬 brunoerg commented on pull request "fuzz: fix bad alloc in connman target":
(https://github.com/bitcoin/bitcoin/pull/31235#issuecomment-2468489703)
Force-pushed squashing and addressing https://github.com/bitcoin/bitcoin/pull/31235#discussion_r1836765925.

💬 andrewtoth commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#issuecomment-2468489763)
re-crACK 9edbe5a48fe9a2c0d364882fcb7d44ae6aac6d24

💬 brunoerg commented on pull request "fuzz: fix bad alloc in connman target":
(https://github.com/bitcoin/bitcoin/pull/31235#discussion_r1836877155)
Done.

💬 andrewtoth commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1836877971)
minor nit: I don't think this one needed to be renamed to `pair`. `self` still makes sense here.

💬 hodlinator commented on pull request "util: Narrow scope of args (-color, -version, -conf, -datadir)":
(https://github.com/bitcoin/bitcoin/pull/31212#issuecomment-2468495898)
Added commit which now guards against passing directory paths as `-conf` values as per https://github.com/bitcoin/bitcoin/pull/31212#issuecomment-2468421728.

💬 l0rinc commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1836880690)
yeah, but it's more consistent this way (and method name already mentions self)

💬 achow101 commented on pull request "doc: Add missing 'blank=true' option in offline-signing-tutorial.md":
(https://github.com/bitcoin/bitcoin/pull/31237#issuecomment-2468501470)
Post merge -0

`disable_private_keys` already implies `blank` so there isn't really a point in specifying `blank` explicitly. I would have preferred to remove the earlier text that says both options would be set.

📝 maflcko opened a pull request: "ci: Bump valgrind tasks to clang-18"
(https://github.com/bitcoin/bitcoin/pull/31273)
This is the default, see https://packages.ubuntu.com/noble/clang, so likely more widely used. Thus, it seems better to use `clang-18`, instead of `clang-16` in the valgrind CI tasks.

💬 fanquake commented on pull request "doc: Add missing 'blank=true' option in offline-signing-tutorial.md":
(https://github.com/bitcoin/bitcoin/pull/31237#issuecomment-2468510059)
I guess if we decide to do that, we can also update the other guides that are doing this redundantly, i.e: https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md#13-create-the-multisig-wallet.

💬 hodlinator commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2468514467)
cr-ACK ee1128ead846698db5e5633f193883837f2fbc64

`git range-diff master 0440c40 ee1128e`:

- Only [comment corrections](https://github.com/bitcoin/bitcoin/pull/31172#discussion_r1834418655.) since my last Windows 11 run.

💬 l0rinc commented on pull request "ci: Bump valgrind tasks to clang-18":
(https://github.com/bitcoin/bitcoin/pull/31273#issuecomment-2468531329)
> better to use clang-18 [...] in the valgrind CI tasks

Why only for `valgrind` tasks and not e.g. `00_setup_env_native_nowallet_libbitcoinkernel.sh`? To have a wider variety of versions?

💬 fanquake commented on pull request "ci: Bump valgrind tasks to clang-18":
(https://github.com/bitcoin/bitcoin/pull/31273#issuecomment-2468531448)
Last time I checked this, this needed additional suppressions (maybe only for aarch64)? Is that no-longer the case?

👍 tdb3 approved a pull request: "bench: add support for custom data directory"
(https://github.com/bitcoin/bitcoin/pull/31000#pullrequestreview-2427666716)
code review and light test re ACK 6c7b3bf0ce7a6238457dd44ee1d5d744b3663a52

`build/src/bench/bench_bitcoin`:
...
`/tmp/test_common bitcoin/BlockAssemblerAddPackageTxns/1731341243673972130/regtest/blocks`

💬 fanquake commented on pull request "ci: Bump valgrind tasks to clang-18":
(https://github.com/bitcoin/bitcoin/pull/31273#issuecomment-2468534148)
> Why only for valgrind tasks and not e.g. 00_setup_env_native_nowallet_libbitcoinkernel.sh?

Probably because of the reason listed in `00_setup_env_native_nowallet_libbitcoinkernel.sh`:

> Use minimum supported python3.10 (or best-effort 3.11) and clang-16, see doc/dependencies.md

👍 theStack approved a pull request: "test: report detailed msg during utf8 response decoding error"
(https://github.com/bitcoin/bitcoin/pull/31251#pullrequestreview-2427672566)
re-ACK a2c45ae5480a2ee643665d6ecaee9714a287a70e

💬 l0rinc commented on pull request "validation: do not wipe utxo cache for stats/scans/snapshots":
(https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-2468549376)
> The test interface_usdt_utxocache.py fails

I haven't reviewed the code in detail yet (since the [build is still failing](https://github.com/bitcoin/bitcoin/pull/30610#pullrequestreview-2277942711)).

<details>
<summary>reproduced build failure</summary>

```bash

> apt install systemtap-sdt-dev
> cmake -B build -DCMAKE_BUILD_TYPE=Release -DWITH_USDT=ON && cmake --build build -j$(nproc)
> build/test/functional/interface_usdt_utxocache.py

2024-11-11T15:47:49.211000Z TestFramework
...