✅ achow101 closed a pull request: "refactor: Simplify bnb coin_selection test params"
(https://github.com/bitcoin/bitcoin/pull/26111)

📝 0xB10C converted_to_draft a pull request: "tracing: Only prepare tracepoint arguments when actually tracing"
(https://github.com/bitcoin/bitcoin/pull/26593)
Currently, if the tracepoints are compiled (e.g. in depends and release builds), we always prepare the tracepoint arguments regardless of the tracepoints being used or not. We made sure that the argument preparation is as cheap as possible, but we can almost completely eliminate any overhead for users not interested in the tracepoints (the vast majority), by gating the tracepoint argument preparation with an `if(something is attached to this tracepoint)`. To achieve this, we use the optional sem
...

💬 achow101 commented on pull request "test: Assert RPC Server binds before creating cookie":
(https://github.com/bitcoin/bitcoin/pull/26964#issuecomment-1522042872)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "test: Assert RPC Server binds before creating cookie"
(https://github.com/bitcoin/bitcoin/pull/26964)

💬 0xB10C commented on pull request "tracing: network connection tracepoints":
(https://github.com/bitcoin/bitcoin/pull/25832#issuecomment-1522043071)
Still think this is relevant, marking this as in draft until I address the feedback.

📝 0xB10C converted_to_draft a pull request: "tracing: network connection tracepoints"
(https://github.com/bitcoin/bitcoin/pull/25832)
This adds five new tracepoints with documentation and tests for network connections:

- established connections with `net:inbound_connection` and `net:outbound_connection`
- closed connections (both closed by us or by the peer) with `net:closed_connnection`
- connections that we choose to evict with `net:evicted_connection`
- connections that are misbehaving and punished with `net:misbehaving_connection`

I've been using these tracepoints for a few months now to monitor connection lifetim
...

✅ achow101 closed a pull request: "wallet, refactor: FundTransaction(): return out-params as `util::Result` structure"
(https://github.com/bitcoin/bitcoin/pull/26129)

✅ achow101 closed a pull request: "wallet: Include a signature with encrypted keys to mitigate a wallet scam"
(https://github.com/bitcoin/bitcoin/pull/25766)

✅ achow101 closed a pull request: "CCoinsViewCache code cleanup & deduplication"
(https://github.com/bitcoin/bitcoin/pull/9384)

💬 achow101 commented on pull request "test: allow BITCOIN_TEST_PATH to specify working dir":
(https://github.com/bitcoin/bitcoin/pull/26564#issuecomment-1522051059)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "During IBD, prune as much as possible until we get close to where we will eventually keep blocks"
(https://github.com/bitcoin/bitcoin/pull/20827)
This should reduce pruning flushes even more, speeding up IBD with pruning on systems that have a sufficient dbcache.

Assumes 1 MB per block between tip and best header chain. Simply adds this to the buffer pruning is trying to leave available, which results in pruning almost everything up until we get close to where we need to be keeping blocks.

💬 achow101 commented on pull request "fuzz: BIP 42, BIP 30, CVE-2018-17144":
(https://github.com/bitcoin/bitcoin/pull/17860#issuecomment-1522062568)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "Make all networking code mockable"
(https://github.com/bitcoin/bitcoin/pull/21878)
_This is a roadmap PR. It can be merged, but it can also be split into separate PRs and to get proper thorough review it is split._

Add wrapper methods to the syscalls `accept()`, `setsockopt()`, `getsockname()`, `bind()`, `listen()` in the [`Sock`](https://github.com/bitcoin/bitcoin/blob/eb9a1fe03779bf05062b70f14190cb23ff42b46f/src/util/sock.h#L25) class (e.g. `Sock::Accept()`). Those methods can be overriden (mocked) by unit tests ([existent example in `master`](https://github.com/bitcoin/
...

💬 real-or-random commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-1522066480)
> Based on those results, if at all, those optimizations should probably only be enabled if GCC is used? (Not sure if it's worth the review and maintenance burden though.)

Some of the code changes here conflict with https://github.com/bitcoin/bitcoin/pull/21590, and given that clang 14 is better than this ASM, we should maybe get benchmarks on a recent GCC (like 12.2) and see if it's faster. If not, I also wonder if there's a better way to convince GCC to output good code.

@theStack Can y
...

💬 achow101 commented on pull request "[WIP] p2p: Add random txn's from mempool to GETBLOCKTXN":
(https://github.com/bitcoin/bitcoin/pull/27086#issuecomment-1522069254)
This PR does not seem to have conceptual support. Please leave a comment if you would like this to be reopened.

✅ achow101 closed a pull request: "[WIP] p2p: Add random txn's from mempool to GETBLOCKTXN"
(https://github.com/bitcoin/bitcoin/pull/27086)

📝 achow101 converted_to_draft a pull request: "util: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior"
(https://github.com/bitcoin/bitcoin/pull/17783)
**This is based on #16545 + #17580.** The non-base commits are:

- [`cf2c60c5203` util: Forbid ambiguous multiple assignments in config file](https://github.com/bitcoin/bitcoin/pull/17493/commits/cf2c60c5203c67e23f396d82b2edb09bb7e01f59)
- [`20ace2d0964` test: Extend util_ArgsMerge test to check for "Multiple values specified" errors](https://github.com/bitcoin/bitcoin/pull/17493/commits/20ace2d096420974689fe18b8fa73d120d7c6d10)

---

Make negating list options act the same as not specify
...

📝 achow101 converted_to_draft a pull request: "refactor: Remove settings merge reverse precedence code"
(https://github.com/bitcoin/bitcoin/pull/17581)
**This is based on #16545 + #17580 + #17493.** The non-base commits are:

- [`a057e0c38f2` refactor: Remove settings merge reverse precedence code](https://github.com/bitcoin/bitcoin/pull/17581/commits/a057e0c38f2d56219568bc6f4ff9e972cdb339c0)

---

This has no effect on behavior because as of https://github.com/bitcoin/bitcoin/pull/17493 it's not possible to specify multiple values for single value settings in the config file.

This change implements one of the settings simplifications
...

📝 achow101 converted_to_draft a pull request: "fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses"
(https://github.com/bitcoin/bitcoin/pull/26859)
In the process of doing so, refactor `ConsumeNetAddr()` to generate the addresses from IPv4, IPv6, Tor, I2P and CJDNS networks in the same way - by preparing some random stream and deserializing from it. Similar code was already found in `RandAddr()`.

💬 achow101 commented on pull request "wallet: Refactor and document CoinControl":
(https://github.com/bitcoin/bitcoin/pull/26066#issuecomment-1522073245)
Are you still working on this?