💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832400954)
Why 25 and not 1 block?

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832492686)
nit: Reduce the number of variables:
```suggestion
std::optional<COutPoint> outpoint_to_rbf{fuzzed_data_provider.ConsumeBool() ? GetChildEvictingPrevout(tx_pool) : std::nullopt};
```

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832985488)
Instead of creating two variables named `tx` here and on line 288, `emplace_back` the return value of the lambda:
```suggestion
txs.push_back([&] {
```

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832788903)
nit: Declare both `const` to be consistent between `num_in` & `num_out`

💬 hodlinator commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834500036)
```suggestion
// Pop random outpoint. We erase them to avoid double-spending
// while in this loop, but later add them back (unless last_tx).
```

👍 tdb3 approved a pull request: "test: clarify log messages when handling SOCKS5 proxy connections"
(https://github.com/bitcoin/bitcoin/pull/31239#pullrequestreview-2425008603)
code review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800

While we're updating this file, shouldn't docstring for `handle()` say `RFC1928` instead of `RFC192`? https://www.rfc-editor.org/rfc/rfc1928.txt

```python
def handle(self):
"""Handle socks5 request according to RFC192."""
```

💬 furszy commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1835111673)
In f3b0593b8:
Can you explain why did you remove the other coins (2 and 4) that were here before? Guess they will be selected and break something if we re-add them because of the algo predilection for unifying utxos?

💬 furszy commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1835113240)
In https://github.com/bitcoin/bitcoin/commit/f3b0593b8bd67bc919b21cd636a01813fc5538c8:

This could output a bit more detailed error message:
```c++
BOOST_CHECK_MESSAGE(EquivalentResult(expected_result, *result), strprintf("Result mismatch in BnB-Success: %s. Expected %s vs %s", test_title, InputsToString(expected_result), InputsToString(*result)));
BOOST_CHECK_MESSAGE(result->GetSelectedValue() == expected_amount, strprintf("Selected amount mismatch in BnB-Success: %s. Expected %d vs %d", t
...

📝 secp512k2 opened a pull request: "doc: Fix missing comma in JSON example in REST-interface.md"
(https://github.com/bitcoin/bitcoin/pull/31259)
This pull request addresses a minor issues in the REST-interface.md documentation:

Missing Comma in JSON Example: In the "Query UTXO set" section, a missing comma after the "desc" field in the JSON example has been added to ensure valid JSON syntax.

📝 ryanofsky opened a pull request: "WIP: scripted-diff: Type-safe settings retrieval"
(https://github.com/bitcoin/bitcoin/pull/31260)
This PR changes the way settings are registered and retrieved to provide more compile-time safety. Currently settings are [registered](https://github.com/ryanofsky/bitcoin/blob/03cff2c1421e5db59963eba1a845ef5dd318c275/src/init.cpp#L504) like:

```c++
argsman.AddArg("-pid=<file>", strprintf("Specify pid file. Relative paths will be prefixed by a net-specific datadir location. (default: %s)", BITCOIN_PID_FILENAME), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
```

and [retrieved](https
...

📝 ryanofsky converted_to_draft a pull request: "WIP: scripted-diff: Type-safe settings retrieval"
(https://github.com/bitcoin/bitcoin/pull/31260)
This PR changes the way settings are registered and retrieved to provide more compile-time safety. Currently settings are [registered](https://github.com/ryanofsky/bitcoin/blob/03cff2c1421e5db59963eba1a845ef5dd318c275/src/init.cpp#L504) like:

```c++
argsman.AddArg("-pid=<file>", strprintf("Specify pid file. Relative paths will be prefixed by a net-specific datadir location. (default: %s)", BITCOIN_PID_FILENAME), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
```

and [retrieved](https
...

🤔 mzumsande reviewed a pull request: "net, init: derive default onion port if a user specified a -port"
(https://github.com/bitcoin/bitcoin/pull/31223#pullrequestreview-2424908328)
>Another alternative: don't listen for Tor on regtest by default (were all reports for this for regtest?).

I don't know, but I could see people / orgs having local setups with multiple nodes on mainnet, e.g. with one node facing random peers from the internet/allowing inbounds, and others that only connect to local trusted peers. In general, I don't like regtest-specific rules so I would see them as a last resort if nothing else works.

> What about setups that use e.g. -port=5000 and have
...

💬 mzumsande commented on pull request "net, init: derive default onion port if a user specified a -port":
(https://github.com/bitcoin/bitcoin/pull/31223#discussion_r1835050453)
dropped as suggest. I guess I was also thinking about local port contention: If bitcoind binds to a port from the list that is usually used by other protocols, then this might affect other programs from starting up or working correctly. Do you think that is an issue we should care about?

💬 mzumsande commented on pull request "net, init: derive default onion port if a user specified a -port":
(https://github.com/bitcoin/bitcoin/pull/31223#discussion_r1835065201)
I think that `-bind=...=onion` in connection with `-port` doesn't resolve the problem completely, because that node wouldn't have any other binds than the onion bind (in particular no bind-on-any) and therefore couldn't receive any non-onion inbound connections.
Not sure if there is a way to avoid the problem other than not using `-port` in the first place.

💬 mzumsande commented on pull request "net, init: derive default onion port if a user specified a -port":
(https://github.com/bitcoin/bitcoin/pull/31223#discussion_r1835061247)
Sound interesting - will try to test this a bit more / and will probably change it to that early next week.

Is this interaction between `-port` and `-bind` without port useful / necessary for anything or more of a gimmick? (it already exists on master) I kind of think as `-port` as an option I'd choose if I didn't want to use `-bind` (and would use `-bind` with a port if I used it at all), so the combination seems a bit confusing.

💬 ryanofsky commented on pull request "WIP: scripted-diff: Type-safe settings retrieval":
(https://github.com/bitcoin/bitcoin/pull/31260#issuecomment-2465902292)
Current status of this PR is that `bitcoind` and `test_bitcoin` binaries work and functional and unit tests pass, but there are compile errors in the other binaries that need to be fixed, and this also needs to be rebased. The PR is complete with all functionality described above implemented, but it probably needs more documentation. I also would like to add more commits replacing last remaining GetArg / GetIntArg / GetBoolArg / GetArgs / IsArgSet / IsArgNegated method uses with `Setting::Get` a
...

📝 secp512k2 opened a pull request: "doc: Clarify GUI Compilation Instructions for Qt Libraries in build-n…"
(https://github.com/bitcoin/bitcoin/pull/31261)
This PR updates build-netbsd.md to improve clarity regarding the installation of Qt libraries for GUI compilation.

This small change enhances clarity for developers by ensuring that instructions for Qt installation and the GUI build option are more explicit, especially for those less familiar with the process on NetBSD.

⚠️ Aste525 opened an issue: "AST283"
(https://github.com/bitcoin/bitcoin/issues/31262)
### Please describe the feature you'd like to see added.

import secrets
import math
import json
from datetime import datetime
from decimal import Decimal

class MetaphysicalConstants:
"""Konstanta Metafisika untuk Bitcoin"""
def __init__(self):
self.BITCOIN_SUPPLY = 21000000
self.HALVING_INTERVAL = 210000
self.METAPHYSICAL_BYTES = 283 # Transformasi dari 399
self.N = 21 # Konstanta dasar Bitcoin
self.Z = self.calculate_z_ratio()

...

✅ fanquake closed an issue: "AST283"
(https://github.com/bitcoin/bitcoin/issues/31262)

:lock: fanquake locked an issue: "AST283"
(https://github.com/bitcoin/bitcoin/issues/31262)