💬 github12101 commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450276326)
> hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
Can/did you run memtest86, for several hours? No errors?
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450276326)
> hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
Can/did you run memtest86, for several hours? No errors?
💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1824764954)
Guess I'd prefer to remove it, since it's been a slippery slope of noncompliance over time
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1824764954)
Guess I'd prefer to remove it, since it's been a slippery slope of noncompliance over time
💬 jb55 commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450280042)
> > hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
>
> Can/did you run memtest86, for several hours? No errors?
I haven't done that yet because I run my entire business (https://damus.io) off this node. my system has been stable for years.
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450280042)
> > hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
>
> Can/did you run memtest86, for several hours? No errors?
I haven't done that yet because I run my entire business (https://damus.io) off this node. my system has been stable for years.
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1824765673)
Thanks! Updated.
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1824765673)
Thanks! Updated.
💬 darosior commented on issue "(Past issue) On Windows, pruned nodes could crash while deleting a block file":
(https://github.com/bitcoin/bitcoin/issues/31193#issuecomment-2450283360)
Of course, better safe than sorry with this matter!
(https://github.com/bitcoin/bitcoin/issues/31193#issuecomment-2450283360)
Of course, better safe than sorry with this matter!
💬 Sjors commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450313186)
> I believe your build log contains a warning like this:
Ah yes, I see those, though buried in the logs. It seems good to _recommend_ ninja in that case, for the QT depends build and all platforms.
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450313186)
> I believe your build log contains a warning like this:
Ah yes, I see those, though buried in the logs. It seems good to _recommend_ ninja in that case, for the QT depends build and all platforms.
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450317443)
> > I believe your build log contains a warning like this:
>
> Ah yes, I see those, though buried in the logs. It seems good to _recommend_ ninja in that case, for the QT depends build and all platforms.
GNU Make fails to build Qt on Linux though.
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450317443)
> > I believe your build log contains a warning like this:
>
> Ah yes, I see those, though buried in the logs. It seems good to _recommend_ ninja in that case, for the QT depends build and all platforms.
GNU Make fails to build Qt on Linux though.
💬 Sjors commented on issue "Gracefully handle dropped UPnP support ":
(https://github.com/bitcoin-core/gui/issues/843#issuecomment-2450319051)
@darosior I could imagine a scenario in which we remove a Tor related setting and it would be unsafe to simply ignore it. But that's not the case here.
(https://github.com/bitcoin-core/gui/issues/843#issuecomment-2450319051)
@darosior I could imagine a scenario in which we remove a Tor related setting and it would be unsafe to simply ignore it. But that's not the case here.
💬 petertodd commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2450326549)
On Thu, Oct 31, 2024 at 09:14:40AM -0700, Gregory Sanders wrote:
> > @@ -34,7 +34,7 @@ BIPs that are implemented by Bitcoin Core:
> * [`BIP 111`](https://github.com/bitcoin/bips/blob/master/bip-0111.mediawiki): `NODE_BLOOM` service bit added, and enforced for all peer versions as of **v0.13.0** ([PR #6579](https://github.com/bitcoin/bitcoin/pull/6579) and [PR #6641](https://github.com/bitcoin/bitcoin/pull/6641)).
> * [`BIP 112`](https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki):
...
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2450326549)
On Thu, Oct 31, 2024 at 09:14:40AM -0700, Gregory Sanders wrote:
> > @@ -34,7 +34,7 @@ BIPs that are implemented by Bitcoin Core:
> * [`BIP 111`](https://github.com/bitcoin/bips/blob/master/bip-0111.mediawiki): `NODE_BLOOM` service bit added, and enforced for all peer versions as of **v0.13.0** ([PR #6579](https://github.com/bitcoin/bitcoin/pull/6579) and [PR #6641](https://github.com/bitcoin/bitcoin/pull/6641)).
> * [`BIP 112`](https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki):
...
💬 willcl-ark commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450339413)
32MB does seem pretty small...
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450339413)
32MB does seem pretty small...
💬 github12101 commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450347899)
> > > hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
> >
> >
> > Can/did you run memtest86, for several hours? No errors?
>
> I haven't done that yet because I run my entire business (https://damus.io) off this node. my system has been stable for years.
I am afraid, until you do, you can't rule out memory problems. Unti
...
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450347899)
> > > hmm I have a small dbcache size I just noticed... can't remember why I set it to that. maybe the increased fsyncs is increasing the chance of a bug somehow? can't think of anything else if its not a hardware issue.
> >
> >
> > Can/did you run memtest86, for several hours? No errors?
>
> I haven't done that yet because I run my entire business (https://damus.io) off this node. my system has been stable for years.
I am afraid, until you do, you can't rule out memory problems. Unti
...
💬 github12101 commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450352153)
> 32MB does seem pretty small...
Good point, @jb55 any only 32MiB for dbcache?
I gave it the following:
`dbcache=16384`
Is it recommended to give it as much as you can spare. If you have free RAM, give it couple of gigabytes.
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450352153)
> 32MB does seem pretty small...
Good point, @jb55 any only 32MiB for dbcache?
I gave it the following:
`dbcache=16384`
Is it recommended to give it as much as you can spare. If you have free RAM, give it couple of gigabytes.
💬 hebasto commented on pull request "cmake: Set top-level target output locations":
(https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2450355793)
> Concept ACK.
>
> ... we currently have:
>
> ```cmake
> set_target_properties(bitcoin-chainstate PROPERTIES
> SKIP_BUILD_RPATH OFF
> )
> ```
>
> Which I think can be removed now, no?
No, we can't. Only for Windows builds, `*.exe` and `*.dll` files reside in a single `bin` subdirectory. For other platforms, shared libraries still reside in their own `lib` subdirectory, which still require using RPATH.
No, we can't. Only for Windows builds `*.exe` and `*.dll` files resi
...
(https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2450355793)
> Concept ACK.
>
> ... we currently have:
>
> ```cmake
> set_target_properties(bitcoin-chainstate PROPERTIES
> SKIP_BUILD_RPATH OFF
> )
> ```
>
> Which I think can be removed now, no?
No, we can't. Only for Windows builds, `*.exe` and `*.dll` files reside in a single `bin` subdirectory. For other platforms, shared libraries still reside in their own `lib` subdirectory, which still require using RPATH.
No, we can't. Only for Windows builds `*.exe` and `*.dll` files resi
...
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1824849464)
> Where does this patch come from? If upstream, can you link to the issue/commits? If not upstream/ it's a bug in Qt, has an issue been opened upstream?
It’s the latter. However, the issue only manifests when cross-compiling for macOS, which is not supported by the Qt project. Therefore, I doubt there’s a reproducible case for the supported build scenarios.
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1824849464)
> Where does this patch come from? If upstream, can you link to the issue/commits? If not upstream/ it's a bug in Qt, has an issue been opened upstream?
It’s the latter. However, the issue only manifests when cross-compiling for macOS, which is not supported by the Qt project. Therefore, I doubt there’s a reproducible case for the supported build scenarios.
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450398106)
> There's probably enough GUI-only stuff here, i.e `bison, ninja-build, python3, xz-utils`, that this could be moved to it's own `#### Gui` section.
> See #31192.
Fellow reviewers!
Please review https://github.com/bitcoin/bitcoin/pull/31192 first :)
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2450398106)
> There's probably enough GUI-only stuff here, i.e `bison, ninja-build, python3, xz-utils`, that this could be moved to it's own `#### Gui` section.
> See #31192.
Fellow reviewers!
Please review https://github.com/bitcoin/bitcoin/pull/31192 first :)
📝 Sjors opened a pull request: "Remove processNewBlock from mining interface"
(https://github.com/bitcoin/bitcoin/pull/31196)
This method was added in 7b4d3249ced93ec5986500e43b324005ed89502f, but became unnecessary with the introduction of interfaces::BlockTemplate::submitSolution in 7b4d3249ced93ec5986500e43b324005ed89502f.
Suggested in https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2404460342
(https://github.com/bitcoin/bitcoin/pull/31196)
This method was added in 7b4d3249ced93ec5986500e43b324005ed89502f, but became unnecessary with the introduction of interfaces::BlockTemplate::submitSolution in 7b4d3249ced93ec5986500e43b324005ed89502f.
Suggested in https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2404460342
💬 Sjors commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2450415920)
I opened #31196 to drop `processNewBlock`.
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2450415920)
I opened #31196 to drop `processNewBlock`.
💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1824870223)
removed the line and updated commit message
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1824870223)
removed the line and updated commit message
💬 jb55 commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450422819)
I set it to 1024, will see if that helps
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2450422819)
I set it to 1024, will see if that helps
💬 maflcko commented on pull request "[POC] ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1824873424)
IIRC the Ubuntu mirrors are often down, so this would lead to intermittent issues without caching.
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1824873424)
IIRC the Ubuntu mirrors are often down, so this would lead to intermittent issues without caching.