💬 fanquake commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441965376)
This seems like even more reason to do #31071.

💬 hebasto commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441967340)
cc @sipsorcery @hodlinator

✅ fanquake closed an issue: "p2p_seednode.py intermittent issue: Expected messages "["Couldn't connect to peers from addrman after 10 seconds. Adding seednode (0.0.0.2) to addrfetch"]" does not partially match log:"
(https://github.com/bitcoin/bitcoin/issues/31103)

🚀 fanquake merged a pull request: "test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs"
(https://github.com/bitcoin/bitcoin/pull/31142)

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads ~17% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-2441972474)
Anyone know why this compiles on Win64 CI, but does not on Win64 native, VS 2022 CI? It seems the latter does not respect the `mutable` lambda capture keyword, so it won't resolve to the `std::vector<T>` parameter but looks for `std::vector<const T>`. Or I need to give that compiler version a hint to resolve to that?

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819321990)
done

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322099)
sure, than verbatim

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322211)
This may be me being too attached to the BIP125 rule numbers. Moved things around a bit, let me know if it's better.

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322447)
oops, fixed and removed more vestigial signaling code and comments in test

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2441978861)
@stickies-v re `doc/bips.md/` bip125 is still opt-in, we are drifting further and further away from that BIP and will finally basically kill it off with cluster mempool. Not sure what we want to do there.

👍 tdb3 approved a pull request: "netinfo: add peer services column and outbound-only option"
(https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2399540351)
cr re ACK 87532fe55856efc063cf81244800da37a015ba75

👍 tdb3 approved a pull request: "test: Don't enforce BIP94 on regtest unless specified by arg"
(https://github.com/bitcoin/bitcoin/pull/31156#pullrequestreview-2399550494)
cr and light test ACK e60cecc8115d3b28be076792baa5e4ea26d353a6

Sanity checked by removing the argument and seeing that the test fails as expected.
```diff
- self.restart_node(0, extra_args=['-test=bip94'])
+ self.restart_node(0, extra_args=[])
```

✅ maflcko closed an issue: "ci: failure in win64 unit tests `err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."`)"
(https://github.com/bitcoin/bitcoin/issues/30792)

💬 maflcko commented on issue "ci: failure in win64 unit tests `err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."`)":
(https://github.com/bitcoin/bitcoin/issues/30792#issuecomment-2442017046)
Let's move discussion to #31071

✅ maflcko closed an issue: "win64-cross CI timeout: `wine: chdir to /tmp/wine-JFrcnM/server-30-e86edd : No such file or directory`; `01e0:err:module:relocate_ntdll ntdll could not be mapped at preferred address (0x320000), expect trouble`"
(https://github.com/bitcoin/bitcoin/issues/30969)

💬 maflcko commented on issue "win64-cross CI timeout: `wine: chdir to /tmp/wine-JFrcnM/server-30-e86edd : No such file or directory`; `01e0:err:module:relocate_ntdll ntdll could not be mapped at preferred address (0x320000), expect trouble`":
(https://github.com/bitcoin/bitcoin/issues/30969#issuecomment-2442018028)
Let's move discussion to #31071

💬 fanquake commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2442024926)
This thread is getting long, but from what I tell, these are the current unaddressed review comments:

https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1780881370
https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1795202925
https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1791790452
https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1791789613
https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1794934340
https://github.com/bitcoin/bitcoin/pull/30997
...

🚀 fanquake merged a pull request: "test: Remove dead code from interface_zmq test"
(https://github.com/bitcoin/bitcoin/pull/30942)

💬 rkrux commented on pull request "netinfo: add peer services column and outbound-only option":
(https://github.com/bitcoin/bitcoin/pull/30930#discussion_r1819433982)
Thanks for clarifying, I was wondering whether the below line would cause `NODE_NONE` to show up as `n` but that should not be the case.

💬 laanwj commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2442197074)
concept ACK, windows 10 was released almost 10 years ago now, i don't think it makes sense to support anything older