💬 fanquake commented on pull request "cmake: Add `FindQRencode` module and enable `libqrencode` package for MSVC":
(https://github.com/bitcoin/bitcoin/pull/31173#discussion_r1819254887)
> various build environments

Given that all the new code is just to facilitate MSVC/`vcpkg`, you could probably be a bit more concrete with the documentation. Otherwise someone might wonder why all of this is being done, when
```bash
find_package(PkgConfig REQUIRED)
pkg_check_modules(PC_QRencode QUIET libqrencode)
```
would otherwise work.

💬 fanquake commented on pull request "build: Rename `PACKAGE_*` variables to `CLIENT_*`":
(https://github.com/bitcoin/bitcoin/pull/31042#issuecomment-2441896956)
Guix Build:
```bash
2df1f3823c8f689140e3a400f0fdc49d4fe0d2bc4d29402d9765bf9821147b28 guix-build-70713303b639/output/aarch64-linux-gnu/SHA256SUMS.part
33a4689e3200b0fbd56d8098b33cf9388baebe641d27dd6dc09813f56ea2abb1 guix-build-70713303b639/output/aarch64-linux-gnu/bitcoin-70713303b639-aarch64-linux-gnu-debug.tar.gz
35f43ddc81853d054544bbe70d7d8461867c026a7b4d3c9ae90ee248bf28c9de guix-build-70713303b639/output/aarch64-linux-gnu/bitcoin-70713303b639-aarch64-linux-gnu.tar.gz
b87c9dd699093402
...

💬 hebasto commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441904898)
Tested 49994fadb3b71552fd99acd8671c52e08284b5e9.

The cross-compiled on Ubuntu 24.10 `bitcoind.exe` fails to run on Windows 11 Pro 23H2.

💬 sr-gi commented on pull request "test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs":
(https://github.com/bitcoin/bitcoin/pull/31142#issuecomment-2441921060)
tACK [6c9fe7b](https://github.com/bitcoin/bitcoin/pull/31142/commits/6c9fe7b73ea1572b8b56c716ab13d9866f91c6e9)

💬 fanquake commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441921131)
> The cross-compiled on Ubuntu 24.10 bitcoind.exe fails to run on Windows 11 Pro 23H2.

Can you provide some actionable information? The CI and cross-compiled unit tests have run & passed.

💬 mzumsande commented on pull request "test: Don't enforce BIP94 on regtest unless specified by arg":
(https://github.com/bitcoin/bitcoin/pull/31156#discussion_r1819302834)
good point, I forgot about `-test=`. Changed it to that approach, as a a result a `regtest` prefix is no longer necessary because the `-test=` will fail init on other networks anyway.

🚀 fanquake merged a pull request: "build: Rename `PACKAGE_*` variables to `CLIENT_*`"
(https://github.com/bitcoin/bitcoin/pull/31042)

💬 hebasto commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441960421)
> > The cross-compiled on Ubuntu 24.10 bitcoind.exe fails to run on Windows 11 Pro 23H2.
>
> Can you provide some actionable information? The CI and cross-compiled unit tests have run & passed.

The only difference from CI is that I run `bitcoind.exe` on Windows, not under Wine.

💬 fanquake commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441965376)
This seems like even more reason to do #31071.

💬 hebasto commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2441967340)
cc @sipsorcery @hodlinator

✅ fanquake closed an issue: "p2p_seednode.py intermittent issue: Expected messages "["Couldn't connect to peers from addrman after 10 seconds. Adding seednode (0.0.0.2) to addrfetch"]" does not partially match log:"
(https://github.com/bitcoin/bitcoin/issues/31103)

🚀 fanquake merged a pull request: "test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs"
(https://github.com/bitcoin/bitcoin/pull/31142)

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads ~17% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-2441972474)
Anyone know why this compiles on Win64 CI, but does not on Win64 native, VS 2022 CI? It seems the latter does not respect the `mutable` lambda capture keyword, so it won't resolve to the `std::vector<T>` parameter but looks for `std::vector<const T>`. Or I need to give that compiler version a hint to resolve to that?

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819321990)
done

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322099)
sure, than verbatim

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322211)
This may be me being too attached to the BIP125 rule numbers. Moved things around a bit, let me know if it's better.

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1819322447)
oops, fixed and removed more vestigial signaling code and comments in test

💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2441978861)
@stickies-v re `doc/bips.md/` bip125 is still opt-in, we are drifting further and further away from that BIP and will finally basically kill it off with cluster mempool. Not sure what we want to do there.

👍 tdb3 approved a pull request: "netinfo: add peer services column and outbound-only option"
(https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2399540351)
cr re ACK 87532fe55856efc063cf81244800da37a015ba75

👍 tdb3 approved a pull request: "test: Don't enforce BIP94 on regtest unless specified by arg"
(https://github.com/bitcoin/bitcoin/pull/31156#pullrequestreview-2399550494)
cr and light test ACK e60cecc8115d3b28be076792baa5e4ea26d353a6

Sanity checked by removing the argument and seeing that the test fails as expected.
```diff
- self.restart_node(0, extra_args=['-test=bip94'])
+ self.restart_node(0, extra_args=[])
```