💬 fanquake commented on pull request "doc: replace `-?` with `-h` and `-help`":
(https://github.com/bitcoin/bitcoin/pull/31118#discussion_r1814528609)
Maybe this will be the last time we rewrite this.
Introduced as `-?`: b21244e0be5727f8c4e8c5de0a9aa2c597ae8ed2
Changed to `--help`: 05fdb97df46d0a0675b93e9791bd5d498e5e5117
Changed back to `-?`: d8513fe41102dcbfc05235f3b95e33eb1878f880
Now we are going back to `-h`: f0130ab1a1e65583637b6a362b879ea3253e7bb7.

💬 maflcko commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814534953)
CI seems to agree:

```
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_iterator.h:1100:16: runtime error: reference binding to misaligned address 0x7f10961d9084 for type 'unsigned long', which requires 8 byte alignment
0x7f10961d9084: note: pointer points here
94 8e 20 eb 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x55780d85ab85 in __gnu_cxx::__normal_iterator<unsigned long*, std::span<unsig
...

💬 maflcko commented on pull request "RPC: Return `permitbaremultisig` and `maxdatacarriersize` in `getmempoolinfo`":
(https://github.com/bitcoin/bitcoin/pull/29954#issuecomment-2434648576)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

💬 l0rinc commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814537555)
Isn't this what we're doing in `CScript` as well https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L496 ?

💬 fanquake commented on issue "How to compile the GUI on opensuse tumbleweed with cmake?":
(https://github.com/bitcoin-core/gui/issues/842#issuecomment-2434651202)
Added to 29.0 milestone as this will either need to be fixed, or documented as no-longer-supported.

💬 l0rinc commented on pull request "doc: replace `-?` with `-h` and `-help`":
(https://github.com/bitcoin/bitcoin/pull/31118#discussion_r1814543917)
I'm fine with `--help` as well, but `-?` just isn't working on a mac

💬 l0rinc commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814546031)
Thanks, I'll investigate.
I assumed there will be more to check, that's why it's still a draft.

💬 fanquake commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2434663476)
Also needs a release note.

👍 fanquake approved a pull request: "build: Fix kernel static lib component install"
(https://github.com/bitcoin/bitcoin/pull/31078#pullrequestreview-2391773492)
ACK 82e16e698321ea6fb69ce5a08b048347aab8c74e

💬 maflcko commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814563302)
> Isn't this what we're doing in `CScript` as well https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L496 ?

no? `value_type` is `unsigned char` (an 8-bit integer type) and this one here is `uint64_t` (an 64-bit integer type).

🚀 fanquake merged a pull request: "build: Fix kernel static lib component install"
(https://github.com/bitcoin/bitcoin/pull/31078)

💬 l0rinc commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814564883)
Yes, just saw it, my mistake

🚀 fanquake merged a pull request: "fees: Remove CLIENT_VERSION serialization"
(https://github.com/bitcoin/bitcoin/pull/29702)

💬 l0rinc commented on pull request "optimization: pack util::Xor into 64 bit chunks instead of doing it byte-by-byte":
(https://github.com/bitcoin/bitcoin/pull/31144#discussion_r1814606913)
Replaced it with `memcpy` and it looks like the compiler successfully uses with [vector instructions](https://www.felixcloutier.com/x86/pxor): https://godbolt.org/z/Koscjconz

💬 maflcko commented on issue "CI failure: `Error: Directory '/tmp/ccache_dir' must be created in advance.`":
(https://github.com/bitcoin/bitcoin/issues/31108#issuecomment-2434777782)
I think asking everyone (probably 100 pull requests overall) to push (normal push, force-push, rebase, ...), or to ignore the failure is a bit too much.

I'll try a temporary workaround.

💬 stickies-v commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2434788469)
> What is the use of REST interface that doesn't have enough endpoints?

It allows for a binary response format, which is not possible with the (JSON-)RPC interface. For large queries, not having the JSON de/serialization round-trip can make a very meaningful performance difference. As such, I believe adding non-performance-critical REST endpoints is always going to be a tough sell, because they wouldn't be meaningfully different from their RPC alternative, thus adding less benefit for the ma
...

💬 stickies-v commented on issue "Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/issues/31017#issuecomment-2434794745)
Note: #31065 was closed because of lack of conceptual support to implement this feature.

💬 laanwj commented on issue "V2 Only Option":
(https://github.com/bitcoin/bitcoin/issues/29618#issuecomment-2434815458)
> CJDNS is still a routed ove rlay network, where packets do not always go the shortest (internet) route to the destination. That is a latency hit vs native IP.

There are some edge cases where super low latency matters, such as mining (or spy nodes :sweat_smile: ), but in general, propagation of anything over the P2P network can be slow and that's fine. There's no tight UI loop. It's not worth to compromise privacy over latency-like it might the case of web browsing, or even the lightning ne
...

👍 laanwj approved a pull request: "test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs"
(https://github.com/bitcoin/bitcoin/pull/31142#pullrequestreview-2391962749)
Code review ACK 6c9fe7b73ea1572b8b56c716ab13d9866f91c6e9

💬 dergoegge commented on pull request "Introduce `g_fuzzing` global for fuzzing checks":
(https://github.com/bitcoin/bitcoin/pull/31093#discussion_r1814676869)
Done!