💬 hodlinator commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2426460077)
PR: #31124

💬 hodlinator commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426479455)
For brief context, in 3 of 3 checked Windows stack dumps, the main callstack where it hangs has been:
```
ntdll.dll!NtReleaseSemaphore() Unknown
KERNELBASE.dll!ReleaseSemaphore() Unknown
WmiApRpl.dll!WmiReverseGuard::LeaveRead(long) Unknown
WmiApRpl.dll!WmiReverseMemoryExt<class WmiReverseGuard>::Read(void *,unsigned long,unsigned long *,unsigned long) Unknown
WmiApRpl.dll!WmiAdapterWrapper::GetValidity(unsigned long) Unknown
WmiApRpl.dll!WmiAdapterWrapper::CollectObjects(unsi
...

💬 sipa commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#discussion_r1808672524)
You may want to also modify the "// Dynamic environment data (performance monitoring, ...)" line in `SeedPeriodic()` in random.cpp.

💬 sipa commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426496088)
Concept ACK

💬 fanquake commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426561701)
Concept ACK - can also remove `winreg.h`.

💬 fjahr commented on pull request "miner: Reorg Testnet4 minimum difficulty blocks":
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-2426574794)
CI is broken because BIP94 is also active on regtest and this change breaks some functional tests that are not related to the issue. I don't think I need to work on fixing those tests unless I get an indication that people think this is actually interesting to merge.

We are getting some report that the `getblocktemplate` sometimes hangs on a small-ish debian 12 server. I have not been able to reproduce this locally or on a small-ish ubuntu server. Would be great if anyone is interested in tes
...

💬 laanwj commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426608538)
Concept ACK as explained in https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2425157662 - querying all performance counters has a potentially high overhead for the system.

💬 hodlinator commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#discussion_r1808780747)
Adjusted in latest push (5cdca2f9d704f2f57ed49beaa764d31c8c55ca77), new comment:
```C++
// Dynamic environment data (clocks, resource usage, ...)
```

💬 pinheadmz commented on issue "estimateSmartFee error: "Insufficient data or no feerate found"":
(https://github.com/bitcoin/bitcoin/issues/31116#issuecomment-2426620801)
@qk-santi ok sounds like you have a clear understanding and the behavior is still unexpected. I would check two more things:
- Check your bitcoin.conf for anything that might be affecting mempool policy (rbf, relayfee, whitelist, etc)
- Enable estimate fee logging `bitcoin-cli logging '["estimatefee"]'` and watch debug.log for `[estiamtefee]` messages

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1808807963)
Done.

💬 hodlinator commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426664437)
Thanks! Incorporated feedback so far. Changed my personal master branch back to running a scheduled hourly Windows-only job with dump file generation, now including the fix from this PR: https://github.com/bitcoin/bitcoin/compare/master...hodlinator:bitcoin:master

💬 furszy commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#issuecomment-2426682018)
Sad rebase due to tiny conflict with #30937. Ready to go.

👍 TheCharlatan approved a pull request: "guix: Enable CET for `glibc` package"
(https://github.com/bitcoin/bitcoin/pull/31121#pullrequestreview-2382132329)
ACK 4d3da08d1b9d07acb43420899e0d16fad2437fb0

Guix build (aarch64):
```
f661515f39c1fef7b7ab7e1de3665ccf3efba9ffbcc6c4de396962e9c6b1a92e guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/SHA256SUMS.part
f4889a72693e3249ac5d59b83c23ddb74f15d9e844c131ae41e17fd5daa15772 guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/bitcoin-4d3da08d1b9d-aarch64-linux-gnu-debug.tar.gz
68dc8bb68f0682047357d292ee71e7b654e3aa1431f50a1ae9ef459f51318663 guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/bitcoin-4
...

💬 hebasto commented on pull request "guix: Enable CET for `glibc` package":
(https://github.com/bitcoin/bitcoin/pull/31121#issuecomment-2426705250)
Concept ACK.

👍 instagibbs approved a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097#pullrequestreview-2382078763)
ACK 86e2a6b749c7fecbd086b361806ac9f6e9426d79

played with tests to ensure the test was failing how I'd expect it with modifications

💬 instagibbs commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#discussion_r1808805047)
nit: Agreed, this would help readability.

💬 hodlinator commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426731716)
Updated 2 more comments along the lines of https://github.com/bitcoin/bitcoin/pull/31124#discussion_r1808780747 in latest push.

👍 TheCharlatan approved a pull request: "Add Signet and testnet4 launch shortcuts for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334#pullrequestreview-2382176682)
ACK cfd03de965a081facbd72316c76603dd7aa511bd

💬 fanquake commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#discussion_r1808866610)
@sipa might be able to pull this into #31112, given it's following up.

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#issuecomment-2426745024)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1803064149