💬 laanwj commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2425157662)
> The call to RegQueryValueExA in RandAddSeedPerfmon:

good find !

i couldn't find anything wrong with that code; however i looked into the Microsoft documentation for this: https://learn.microsoft.com/en-us/windows/win32/perfctrs/using-the-registry-functions-to-consume-counter-data

apparently, querying HKEY_PERFORMANCE_DATA can potentially load all kinds of DLLs for performance counter data, depending on drivers installed on the system, as well as collects performance information for ev
...

💬 1440000bytes commented on issue "Listen on random port by default (not 8333)":
(https://github.com/bitcoin/bitcoin/issues/31036#issuecomment-2425175641)
> > Downsides:
>
> Another downside would be that finding an initial batch of peers would take longer. GETADDR answers will include many addresses that are not reachable, whereas DNS seeders only resolve to addresses of nodes that the crawler could reach very recently. I would expect that there would be quite a noticeable effect.

Let's fix DNS seeds: https://github.com/bitcoin/bitcoin/issues/30900

Or someone experienced and influential does a RFC which changes https://datatracker.ietf.o
...

💬 laanwj commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1807984414)
agree that that's clearer; it may not always be (due to ASmap being an approximation, as well as incomplete information) but the AS number is supposed ot be the end-point AS, not just one along the route

⚠️ Billgates098 opened an issue: "Flash bitcoin"
(https://github.com/bitcoin/bitcoin/issues/31123)

✅ achow101 closed an issue: "Flash bitcoin"
(https://github.com/bitcoin/bitcoin/issues/31123)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31123)

👍 rkrux approved a pull request: "Remove mempoolfullrbf"
(https://github.com/bitcoin/bitcoin/pull/30592#pullrequestreview-2380966553)
tACK https://github.com/bitcoin/bitcoin/commit/f863f5a4f991ccfdf865d39c73269b196eeb4902

Make and functional tests are successful.

💬 rkrux commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1808131075)
Nice to see these checks going away!

👍 rkrux approved a pull request: "Package validation: accept packages of size 1"
(https://github.com/bitcoin/bitcoin/pull/31096#pullrequestreview-2381095095)
tACK https://github.com/bitcoin/bitcoin/commit/72872c7073e99da0828e788b25520dcecf721c1b
Would be great to have the docs updated as well.

Make and functional tests successful.

In regtest I manually created a PSBT, processed it and submitted a single transaction package with successful response.

```
➜ bitcoin git:(2024-10-submitpackage-singleton) ✗ bitcoincli submitpackage "[\"020000000001018e61beaa1f85daba48a46e6bef4e58d12f32768d347185cb077c988cc5af976b0000000000fdffffff02e60f10240100
...

💬 rkrux commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1808203711)
Worth updating RPC doc as well here? Informing that only child is also allowed.

https://github.com/bitcoin/bitcoin/blob/master/src/rpc/mempool.cpp#L926

👍 rkrux approved a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118#pullrequestreview-2381221879)
tACK https://github.com/bitcoin/bitcoin/commit/f0130ab1a1e65583637b6a362b879ea3253e7bb7

I compiled `bench_bitcoin`, and ran the help command on Mac OS. `-h` works, `-?` doesn't.

Wondering why is `-h` a hidden argument. Do you think it's worth making it non-hidden with its own message just like `-?`?
https://github.com/bitcoin/bitcoin/blob/master/src/common/args.cpp#L692

💬 laanwj commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2425956873)
> Wondering why is -h a hidden argument. Do you think it's worth making it non-hidden with its own message just like -??

There's no reason to list both seperately. That would clutter the list. `-?` is the weird duck out in that it lists the short-name option as primary instead of the long one (`-help`). Might add the alternatives to the help message say,

```
-help
Print this help message and exit (also -h or -?)
```

👍 BrandonOdiwuor approved a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118#pullrequestreview-2381328047)
ACK f0130ab1a1e65583637b6a362b879ea3253e7bb7, great catch

💬 fanquake commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2426002132)
> The call to RegQueryValueExA in RandAddSeedPerfmon:

I think you can open a PR to just remove this entirely.

💬 cdecker commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2426003595)
From what I can tell it is working as expected:

```
dig x9.seed.bitcoinstats.com. @1.1.1.1

; <<>> DiG 9.18.28-0ubuntu0.22.04.1-Ubuntu <<>> x9.seed.bitcoinstats.com. @1.1.1.1
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 28948
;; flags: qr rd ra; QUERY: 1, ANSWER: 24, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;x9.seed.bitcoinstats.com. IN A

;; ANSWER SECTIO
...

💬 rkrux commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2426028146)
> > Wondering why is -h a hidden argument. Do you think it's worth making it non-hidden with its own message just like -??
>
> There's no reason to list both seperately. That would clutter the list. `-?` is the weird duck out in that it lists the short-name option as primary instead of the long one (`-help`). Might add the alternatives to the help message say,
>
> ```
> -help
> Print this help message and exit (also -h or -?)
> ```

@laanwj Yes, this^ seems better.

👍 fanquake approved a pull request: "Update libmultiprocess library"
(https://github.com/bitcoin/bitcoin/pull/31105#pullrequestreview-2381376853)
ACK 90b405516f7f3be522ced3e0c4d23b3892df0661

💬 sdaftuar commented on pull request "Add imbued v3 based on template-matching":
(https://github.com/bitcoin/bitcoin/pull/29427#issuecomment-2426055128)
I believe this PR is no longer relevant, so closing for now.

✅ sdaftuar closed a pull request: "Add imbued v3 based on template-matching"
(https://github.com/bitcoin/bitcoin/pull/29427)

💬 l0rinc commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2426061892)
I've pushed the default change in a separate commit, let me know if this is what you had in mind:
```bash
% build/src/bench/bench_bitcoin -h
[...]
-help
Print this help message and exit (also -h or -?)
```