💬 pinheadmz commented on issue "estimateSmartFee error: "Insufficient data or no feerate found"":
(https://github.com/bitcoin/bitcoin/issues/31116#issuecomment-2423881835)
It might be helpful to have version of the affected node and debug log output. You may need to run `bitcoin-cli logging '["estimatefee"]'`

💬 EthanHeilman commented on pull request "CAT in Tapscript (BIP-347)":
(https://github.com/bitcoin/bitcoin/pull/29247#issuecomment-2423935186)
@achow101 What does draft vs non-draft mean in the bitcoin-core github? My understanding was moving from draft to non-draft means code is ready for review. Similar to moving WIP.

Is draft/non-draft is being used to signal community consensus or bitcoin-core consensus? If so, I agree this should be a draft.

🤔 Zidane115 reviewed a pull request: "optimization: reserve memory allocation for transaction inputs/outputs"
(https://github.com/bitcoin/bitcoin/pull/30093#pullrequestreview-2379595565)
Wwe

📝 fjahr opened a pull request: "miner: Reorg Testnet4 minimum difficulty blocks"
(https://github.com/bitcoin/bitcoin/pull/31117)
Note: This is just a proof of concept put here for discussion/feedback/brainstorming/improvement. I am not sure if we want to merge this into core at all since it can be dealt with externally as well. But this was the simplest way for me to make it work and it's probably also simpler for many miners to run this branch rather than another external software.

### Context

Testnet4 fixes block storms but it kept the minimum-difficulty exception in place. The rationale was that this would be the
...

📝 fjahr converted_to_draft a pull request: "miner: Reorg Testnet4 minimum difficulty blocks"
(https://github.com/bitcoin/bitcoin/pull/31117)
Note: This is just a proof of concept put here for discussion/feedback/brainstorming/improvement. I am not sure if we want to merge this into core at all since it can be dealt with externally as well. But this was the simplest way for me to make it work and it's probably also simpler for many miners to run this branch rather than another external software.

### Context

Testnet4 fixes block storms but it kept the minimum-difficulty exception in place. The rationale was that this would be the
...

💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2424064713)
Re: the recent discussion here, see #31117

📝 l0rinc opened a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118)
The question mark is interpreted as a wildcard for any single character in Zsh (see https://www.techrepublic.com/article/globbing-wildcard-characters-with-zsh), so `bench_bitcoin -?` will not show the help message on systems using Zsh, such as macOS.

Since `-h` provides equivalent help functionality (as defined in https://github.com/bitcoin/bitcoin/blob/master/src/common/args.cpp#L684-L693), the `benchmarking.md` documentation has been updated to ensure compatibility with macOS.

----

#
...

💬 TheCharlatan commented on pull request "init: Some small chainstate load improvements":
(https://github.com/bitcoin/bitcoin/pull/31046#discussion_r1807432735)
I think your suggestion is a bit better. I'll push it if something else comes up. Looks to me like that code iterated over the chainstates in a previous un-pushed version, that would explain why only the errors are surfaced here. There is also ryanofsky's assumeutxo state cleanup PR that could catch this later if we don't get it here

💬 TheCharlatan commented on pull request "init: Correct coins db cache size setting":
(https://github.com/bitcoin/bitcoin/pull/31064#discussion_r1807433006)
fyi I also hope we can improve how to do this in ryanofsky's #30214.

💬 l0rinc commented on pull request "test: Fuzz the human-readable part of bech32 as well":
(https://github.com/bitcoin/bitcoin/pull/30623#discussion_r1807434072)
> BIP173/BIP350 specify the maximum length of bech32/bech32m strings as 90 characters.

Yes, but https://en.bitcoin.it/wiki/BIP_0352 states that:
> Note: [BIP173](https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki) imposes a 90 character limit for Bech32 segwit addresses and limits versions to 0 through 16, whereas a silent payment address requires at least 117 characters[[12]](https://en.bitcoin.it/wiki/BIP_0352#cite_note-why_117_chars-12) and allows versions up to 31. Additional
...

💬 andrewtoth commented on pull request "validation: Make ReplayBlocks interruptible":
(https://github.com/bitcoin/bitcoin/pull/30155#issuecomment-2424107647)
Concept ACK

It appears to me that the size of the cache used in ReplayBlocks is never checked if it grows too large. Wouldn't this mean that if the node was sufficiently far behind, the rolling forward would fill up the cache to levels exceeding dbcache? This would result in a cycle of rolling forward and then OOM crashing, never being able to write any chainstate to disk.

💬 sipa commented on pull request "test: Fuzz the human-readable part of bech32 as well":
(https://github.com/bitcoin/bitcoin/pull/30623#discussion_r1807450121)
Sure, but support for silent payment hasn't been merged. Today, the codebase only supports bech32 as specified by bip173/bip350 (see https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md).

✅ achow101 closed a pull request: "Simple security.doc improvement"
(https://github.com/bitcoin/bitcoin/pull/31114)

💬 achow101 commented on pull request "Simple security.doc improvement":
(https://github.com/bitcoin/bitcoin/pull/31114#issuecomment-2424198074)
Thank you for your contribution. Stylistic and formatting changes to documentation are generally discouraged as they come at a cost for the project as a whole while not meaningfully changing anything. In particular, many of the changes in this PR do not change how things are rendered, nor the readability of the documentation even when viewed in plain text. The motivation provided does not justify the burden on the project that this may place on the project. A burden could be any of the following
...

💬 achow101 commented on pull request "CAT in Tapscript (BIP-347)":
(https://github.com/bitcoin/bitcoin/pull/29247#issuecomment-2424200438)
In general, draft means that a PR is not in a state where it could be merged. It indicates to reviewers that they may not want to do any in depth code review of the PR yet.

In the context of this PR, there does not appear to be consensus for the concept of OP_CAT in TapScript yet, so this PR cannot be merged even if the code is okay. Hence marking it as a draft.

Note that this is a result of a [Kill/Shill/Merge](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Kill-Shill-Drill) session
...

💬 davidgumberg commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2424219301)
> seeding randomness entropy from Windows performance data obtained through the Registry API during startup hangs when attempting to release a semaphore deep in Microsoft code.

The call to `RegQueryValueExA` in `RandAddSeedPerfmon`:

https://github.com/bitcoin/bitcoin/blob/e8f72aefd20049eac81b150e7f0d33709acd18ed/src/randomenv.cpp#L80-L91

⚠️ Hulamoney opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/31119)

💬 andrewtoth commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#issuecomment-2424297328)
If I understand correctly, this would allow us to reuse the parallel check queue with worker threads to fetch block inputs from disk. Then we could fetch and cache all missing inputs concurrently in ConnectBlock instead of fetching from disk one by one.

✅ achow101 closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/31119)

👍 laanwj approved a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118#pullrequestreview-2380203415)
ACK f0130ab1a1e65583637b6a362b879ea3253e7bb7
Easier to remember too, `-?` is a kind of mingling between Windows/DOS `/?` and UNIX `-h` conventions.