💬 jonatack commented on pull request "netinfo: add peer services column and outbound-only peers list":
(https://github.com/bitcoin/bitcoin/pull/30930#issuecomment-2420562022)
> I think you also should update line 93 (change "4" to "5")
>
> ```
> argsman.AddArg("-netinfo", "Get network peer connection information from the remote server. An optional integer argument from 0 to 4 can be passed for different peers listings (default: 0). Pass \"help\" for detailed help documentation.", ArgsManager::ALLOW_ANY, OptionsCategory::CLI_COMMANDS);
> ```

Good catch @LarryRuane -- added 153b898a77f4c892731c220ce85d29c1cf880355 to ensure we don't overlook updating this.

💬 jonatack commented on pull request "netinfo: add peer services column and outbound-only peers list":
(https://github.com/bitcoin/bitcoin/pull/30930#issuecomment-2420580314)
Updated per `git diff 683b558 1847b9` to take @vasild's [suggestion](https://github.com/bitcoin/bitcoin/pull/30930#discussion_r1795748339) and a fix for @LarryRuane's [catch](https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2363290423) (thanks!)

💬 jonatack commented on pull request "netinfo: add peer services column and outbound-only peers list":
(https://github.com/bitcoin/bitcoin/pull/30930#issuecomment-2420629857)
Updated to take @vasild's [suggestion](https://github.com/bitcoin/bitcoin/pull/30930#discussion_r1795748339) and a fix for @LarryRuane's [catch](https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2363290423) (thanks!) and doc updates I overlooked.

<details><summary><code>git diff 683b558 17f8f03</code></summary><p>

```diff
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp
index 000f7695de6..6bda4cbe0c5 100644
--- a/src/bitcoin-cli.cpp
+++ b/src/bitcoin-cli.cpp
@@ -57
...

🤔 ariard reviewed a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097#pullrequestreview-2376369218)
Re-Code Review ACK 86e2a6b7

The code nit improvement, ready to be git cherry-picked:https://github.com/ariard/bitcoin/tree/2024-10-check2-impr

💬 masahiro0000 commented on issue "CI failure: `Error: Directory '/tmp/ccache_dir' must be created in advance.`":
(https://github.com/bitcoin/bitcoin/issues/31108#issuecomment-2420879801)
Hi @maflcko
In commit fa252da, the CCACHE_DIR was removed from the .cirrus.yml file. Originally, the directory for CCACHE_DIR is supposed to be created in another shell script. However, since the definition has been deleted, the directory is not being created, which is likely causing the error.

As a solution, it seems that the previous commit might have been incorrect, so we may need to contact the administrator and request them to revise the commit.

💬 ariard commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2420893629)
@mzumsande

> Again, the issues mentioned in #30572 (comment) and #30572 (comment) point out that unrequested transactions are received today when an orphan resolution clears outstanding tx requests both by txid and wtxid here, but there is still> a tx request in flight (we already sent GETDATA but haven't received the TX yet), which is seen as unrequested when the TX arrives. So the transactions were requested before, but aren't seen as requested anymore at the point the tx > is received. Ho
...

👍 1440000bytes approved a pull request: "rest: Support transaction broadcast in REST interface"
(https://github.com/bitcoin/bitcoin/pull/31065#pullrequestreview-2376591484)
ACK https://github.com/bitcoin/bitcoin/pull/31065/commits/6b32a886e351f0af3084ccab076a52e0eafc5aab

Two changes since last review:
- [Test](https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799005090) fixed
- Added in [release notes](https://github.com/bitcoin/bitcoin/commit/6b32a886e351f0af3084ccab076a52e0eafc5aab)

> Do you think it would make sense to add an additional flag, like -allowrestbroadcast, defaulting to off?

I don't think this needs to be done in bitcoin core. Web
...

📝 andrewtoth converted_to_draft a pull request: "Don't wipe coins cache when full and instead evict LRU clean entries"
(https://github.com/bitcoin/bitcoin/pull/31102)
Depends on #28939.

This only wipes the coins cache if memory usage is greater than total allowed cache size. Instead, it does a non-wiping sync to disk and keeps all unspent coins in the cache. These are tracked in a linked list of clean entries, and when spent are removed from the clean linked list and appended to the dirty linked list. This results in the head of the clean linked list containing the oldest clean entry.

When the cache grows to above the large size threshold, clean entries
...

👍 1440000bytes approved a pull request: "netinfo: add peer services column and outbound-only peers list"
(https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2376596938)
ACK https://github.com/bitcoin/bitcoin/pull/30930/commits/17f8f03ec69b6dd3d61137a39b8f88201ec500dc

Changes since last review: https://github.com/bitcoin/bitcoin/pull/30930#issuecomment-2420629857

⚠️ ariard opened an issue: "Follow-up from Moderation Rules"
(https://github.com/bitcoin/bitcoin/issues/31110)
Just to be sure this is not a compromised of the github platform itself:
https://github.com/bitcoin-core/meta/issues/11

💬 baycclark commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#issuecomment-2421654737)
> An earlier version allowed users to create watchonly wallets (wallets without private keys) that were "encrypted". Such wallets would have a stored encryption keys, but nothing would actually be encrypted with them. This can cause unexpected behavior such as [bitcoin-core/gui#772](https://github.com/bitcoin-core/gui/issues/772).
>
> We can detect such wallets as they will have the disable private keys flag set, no encrypted keys, and encryption keys. For such wallets, we can remove those en
...

💬 virtu commented on issue "Distribute darknet node addresses via DNS seeds using AAAA records":
(https://github.com/bitcoin/bitcoin/issues/31062#issuecomment-2421667923)
> From what i heard it's not generally a good idea to stash different data in AAAA records. Caching DNS servers can have checks to assume the addresses are routable and valid. Additionally, there's also no guarantee that clients get all the addresses, so splitting the data is a bit brittle.
>
> This would also break the assumption that a random address returned from the DNS seed is connectable (because they might get a fragment instead). Bitcoin core peers fully behind Tor rely on this behavio
...

💬 baycclark commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#discussion_r1806050734)
I don’t know where else to go for help, but this sounds like exactly what I’ve been looking for (hopefully). About a year ago I found my old pre-2017 BTC info & when viewing it I accidentally imported it as a WatchOnly & now I can’t do anything with it. I’m a Ethereum Validator & never really understood the BTC Ecosystem, so any help in the right direction would be appreciated. I’ll donate 0.02 BTC to whoever can help.

💬 ariard commented on issue "Follow-up from Moderation Rules":
(https://github.com/bitcoin/bitcoin/issues/31110#issuecomment-2421747490)
Been a while I’ve not been on IRC to attend one of the regular meeting, so I’ll find time to do so during the coming weeks to clarify. There is no rush to clarify that.

After all, it might be just a contributor or maintainer with perms access to the bitcoin Github organization. She or he might have got drunk or be under drugs at some party, and slips the wrong button….

Still hope it’s not a real infrastructure issue, where bitcoin Github repository has been effectively compromised :/

💬 virtu commented on issue "Listen on random port by default (not 8333)":
(https://github.com/bitcoin/bitcoin/issues/31036#issuecomment-2421781383)
Concept ACK

Using a default port defeats some parts of v2transport, I guess.

Concerning DNS seeds, two ideas come to mind:
1. In theory, the issue could be solved by increasing the scope of #31062 by adding port numbers to the encoding and encode also IP addresses with it. Whether the proposal is practical remains to be seen.
2. A more radical solution would be to dispense with DNS seeds and instead rely entirely only on hardcoded seeds for all network types. [Historical data](https://de
...

💬 junghyun0783 commented on pull request "cli: restrict multiple exclusive argument usage in bitcoin-cli":
(https://github.com/bitcoin/bitcoin/pull/30148#issuecomment-2421830756)
I think I'm currently using testnet3.
How do I patch to testnet4?
When I type bitcoind -version,
"Bitcoin Core version v28.0.0"
This is what I get.
I want to apply it to testnet4 and send it.
How can I change it to testnet4?
plz help me!!!

✅ willcl-ark closed an issue: "Follow-up from Moderation Rules"
(https://github.com/bitcoin/bitcoin/issues/31110)

💬 willcl-ark commented on issue "Follow-up from Moderation Rules":
(https://github.com/bitcoin/bitcoin/issues/31110#issuecomment-2421871938)
> Just to be sure this is not a compromised of the github platform itself:

I am not myself aware of any compromise of this platform, but we can wait for others to chime in on your issue at https://github.com/bitcoin-core/meta/issues/11

I have hidden your second comment as "off-topic", as it does not align with our moderation guidelines. Specifically:
- It's off-topic and doesn't contribute to technical discussion (that applies to this entire issue frankly).
- It speculates about individu
...

⚠️ sdaftuar opened an issue: "Trouble fuzzing on macos"
(https://github.com/bitcoin/bitcoin/issues/31111)
I've got a Apple M2 Max macbook pro, running sequoia 15.0.1. I'm trying to follow the instructions for fuzzing on macos, but I'm running into trouble.

I reinstalled llvm via `brew install`, as the instructions indicated:

```
$ clang --version
Homebrew clang version 19.1.2
Target: arm64-apple-darwin24.0.0
Thread model: posix
InstalledDir: /opt/homebrew/Cellar/llvm/19.1.2/bin
$ clang++ --version
Homebrew clang version 19.1.2
Target: arm64-apple-darwin24.0.0
Thread model: posix
Ins
...

💬 sipa commented on issue "Trouble fuzzing on macos":
(https://github.com/bitcoin/bitcoin/issues/31111#issuecomment-2421978663)
From https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md#macos-hints-for-libfuzzer:

> $ cmake --preset=libfuzzer \ -DCMAKE_C_COMPILER="$(brew --prefix llvm)/bin/clang" \ -DCMAKE_CXX_COMPILER="$(brew --prefix llvm)/bin/clang++" \ -DAPPEND_LDFLAGS=-Wl,-no_warn_duplicate_libraries