Bitcoin Core Github
44 subscribers
121K links
Download Telegram
👍 theuni approved a pull request: "depends: sqlite 3.46.1"
(https://github.com/bitcoin/bitcoin/pull/29991#pullrequestreview-2372922887)
Not opposed utACK def6dd0c597f2c7b0c55910792e646b8ff93e36c
📝 fanquake opened a pull request: "[28.x] Some backports"
(https://github.com/bitcoin/bitcoin/pull/31104)
Backports:
* #31007
* #31016
* #31035
💬 hebasto commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803386502)
> Do you plan to open a follow-up to apply the similar change to Windows?

Yes. When I find a proper way to specify the minimum required OS version. The currently used `--major-subsystem-version` and `--minor-subsystem-version` flags do not work for me. And Microsoft docs are not very helpful. So any hints are much appreciated.
💬 RCasatta commented on issue "Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/issues/31017#issuecomment-2417242064)
Please see https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2417141803 for details
💬 maflcko commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803389823)
If everything fails, just updating the docs would be fine as well. Users are always free to shoot themselves in the foot. If the binary works for them, fine, if not, there won't be any support?
🚀 fanquake merged a pull request: "doc: update signet documentation related to build directories"
(https://github.com/bitcoin/bitcoin/pull/30996)
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408738)
sure, changed
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408819)
done
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408904)
done
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409020)
yes, clarified
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409152)
fixed
💬 Sjors commented on issue "Stratum v2 via IPC Mining Interface tracking issue":
(https://github.com/bitcoin/bitcoin/issues/31098#issuecomment-2417271469)
To address the last point (will respond to the rest later):

> It's also my understanding the the IPC logic in Bitcoin Core is not intended as a public API, and thus users of it are expected to exclusively be in Bitcoin Core, I suppose that is changing here?

In general IPC interfaces are not intended to be public, but the mining interface is an exception. @josibake is working on a proof-of-concept Rust demo that uses it, which should be fairly easy to use in SRI.
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409321)
Removed the `bypass_limits` along with unification of CheckEphemeralSpends.
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409405)
done, put the new version in both AcceptMultipleTransactions and AcceptSingleTransaciton
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409501)
changed assert to `Assume` as requested, let it stumble along
💬 stickies-v commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2417294412)
> it's easier to set up for users, since it doesn't require any form of authentication

It seems `electrs` already uses the authentication cookie by default (as per their docs), so for most setups, this shouldn't be a meaningful difference?

> it's safer...

It seems this new endpoint is aimed at less savvy users or users that don't have an overly complex setup and e.g. just want to run an electrum server for personal use. In that scenario, I'm not sure the footguns of e.g forgetting to wh
...
👍 jarolrod approved a pull request: "doc: remove dependency install instructions from win docs"
(https://github.com/bitcoin/bitcoin/pull/31100#pullrequestreview-2373009083)
ACK 184f12c1542f6c53eb2bd9dfb08dfdd490e38846
📝 ryanofsky opened a pull request: "Update libmultiprocess library"
(https://github.com/bitcoin/bitcoin/pull/31105)
Add recent changes and fixes for shutdown bugs.

https://github.com/chaincodelabs/libmultiprocess/pull/111: doc: Add internal design section
https://github.com/chaincodelabs/libmultiprocess/pull/113: Add missing include to util.h
https://github.com/chaincodelabs/libmultiprocess/pull/116: shutdown bugfix: destroy RPC system before running cleanup callbacks
https://github.com/chaincodelabs/libmultiprocess/pull/118: shutdown bugfix: Prevent segfault in server if connection is broken during lon
...
👍 BrandonOdiwuor approved a pull request: "doc: remove dependency install instructions from win docs"
(https://github.com/bitcoin/bitcoin/pull/31100#pullrequestreview-2373066201)
ACK 184f12c1542f6c53eb2bd9dfb08dfdd490e38846
🤔 l0rinc reviewed a pull request: "Don't wipe coins cache when full and instead evict LRU clean entries"
(https://github.com/bitcoin/bitcoin/pull/31102#pullrequestreview-2373049420)
Since this depends on other PRs, would it make sense to draft it until those are merged and CI fixed?