💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2416743789)
I'm moving this pull request to https://github.com/Sjors/bitcoin/pull/68. The `sv2` branch will continue to work as before for the time being. See https://github.com/bitcoin/bitcoin/issues/31098 the plan moving forward.

💬 kevkevinpal commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1803048632)
thanks! Updated in [60dbd42](https://github.com/bitcoin/bitcoin/pull/31040/commits/60dbd42257c0605ab8d83f47babe2baa8f42a71c)

💬 kevkevinpal commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1803050849)
Thanks! I updated in [60dbd42](https://github.com/bitcoin/bitcoin/pull/31040/commits/60dbd42257c0605ab8d83f47babe2baa8f42a71c)

Its supposed to be a random orphan but I removed "and that the first orphan has been dropped" since we are not checking if a random orphan has been dropped and just checking the max orphan amount

💬 Sjors commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803058288)
Yes that should be removed, along with the rest of the paragraph below.

💬 fjahr commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1803064149)
nit: I am not super happy with the wording that the help text here is converged to but we can keep it since I think everyone who understands asmap and BGP knows what is meant by this. The part I don't like is "in the BGP route to the peer" because a BGP route in a routing table includes several ASNs (the actual route), just the last one is the ASN which controls the IP and that is the mapping that we have in ASMap. Better wordings would be "at the end of the BGP route" or (closer to the old text
...

🤔 fjahr reviewed a pull request: "rpc: net: follow-ups for #30062"
(https://github.com/bitcoin/bitcoin/pull/30183#pullrequestreview-2372405981)
utACK b33eb137e39c434a7be69e1453a708b0c52553c4

💬 l0rinc commented on pull request "benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues":
(https://github.com/bitcoin/bitcoin/pull/30349#discussion_r1803077774)
Thanks, done

💬 l0rinc commented on pull request "optimization: precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2416812237)
@laanwj This is the optimization that relies on https://github.com/bitcoin/bitcoin/pull/30349, would really appreciate you input on it.

🚀 achow101 merged a pull request: "optimization: reserve memory allocation for transaction inputs/outputs"
(https://github.com/bitcoin/bitcoin/pull/30093)

📝 fanquake opened a pull request: "doc: drop macOS LLVM install instructions"
(https://github.com/bitcoin/bitcoin/pull/31099)
Followup from #31048.

💬 fanquake commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803097299)
Removed in #31099.

👍 hebasto approved a pull request: "doc: drop macOS LLVM install instructions"
(https://github.com/bitcoin/bitcoin/pull/31099#pullrequestreview-2372473961)
ACK 79aa8280b2edd6a153afa876ae4a5e9ead39dc88.

Thank you for following up.

💬 TheBlueMatt commented on issue "Stratum v2 via IPC Mining Interface tracking issue":
(https://github.com/bitcoin/bitcoin/issues/31098#issuecomment-2416863058)
I'm really quite confused by this. Creating a "temple IPC" interface is not substantially different than creating any other protocol for providing templates. What is the advantage for Bitcoin core to provide something proprietary over a standard that matches what consumers of that interface would want?

💬 maflcko commented on pull request "doc: drop macOS LLVM install instructions":
(https://github.com/bitcoin/bitcoin/pull/31099#issuecomment-2416879897)
lgtm ACK 79aa8280b2edd6a153afa876ae4a5e9ead39dc88

📝 fanquake opened a pull request: "doc: remove dependency install instructions from win docs"
(https://github.com/bitcoin/bitcoin/pull/31100)
This duplicates what is in depends, and is outdated.

Closes #31090.

🚀 fanquake merged a pull request: "test: Print CompletedProcess object on error"
(https://github.com/bitcoin/bitcoin/pull/31067)

🚀 fanquake merged a pull request: "doc: drop macOS LLVM install instructions"
(https://github.com/bitcoin/bitcoin/pull/31099)

💬 maflcko commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803165670)
Do you plan to open a follow-up to apply the similar change to Windows?

📝 fanquake opened a pull request: "[27.x] Prep for 27.2"
(https://github.com/bitcoin/bitcoin/pull/31101)

✅ fanquake closed a pull request: "build: Mark `x86_64-linux-gnu` release binaries as CET-enabled"
(https://github.com/bitcoin/bitcoin/pull/30685)