Bitcoin Core Github
44 subscribers
121K links
Download Telegram
👍 stickies-v approved a pull request: "optimization: reserve memory allocation for transaction inputs/outputs"
(https://github.com/bitcoin/bitcoin/pull/30093#pullrequestreview-2369807087)
ACK ec585f11c38bbe277a596dcea3c813e7c6626050
💬 GregTonoski commented on pull request "add `-limitdummyscriptdatasize` option":
(https://github.com/bitcoin/bitcoin/pull/29520#issuecomment-2414355286)
> Closing this as it has not had any activity in a while, and feedback has not been addressed.

Disgraceful.
💬 achow101 commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2414359345)
Needs a bip
💬 pinheadmz commented on pull request "add `-limitdummyscriptdatasize` option":
(https://github.com/bitcoin/bitcoin/pull/29520#issuecomment-2414362117)
@GregTonoski Your comment is off-topic and inflammatory, resulting in a 24 hour ban, please be respectful.
💬 achow101 commented on pull request "test: extend the SOCKS5 Python proxy to actually connect to a destination":
(https://github.com/bitcoin/bitcoin/pull/29420#issuecomment-2414389340)
cc @tdb3
💬 BitcoinMechanic commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-2414391299)
Relaying anything by default that demonstrably only gets used for malicious purposes (which in this case was *openly stated by the perpetrator*) remains perplexing and embarrassing.
💬 achow101 commented on pull request "tracing: explicitly cast block_connected duration to nanoseconds":
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2414392442)
cc @tdb3
💬 achow101 commented on pull request "validation: do not wipe utxo cache for stats/scans/snapshots":
(https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-2414394453)
cc @davidgumberg @andrewtoth @l0rinc
📝 fanquake locked a pull request: "add `-limitdummyscriptdatasize` option"
(https://github.com/bitcoin/bitcoin/pull/29520)
Same as #28408, but with one new options:

`-limitdummyscriptdatasize` which allows you to choose the maximum size of the relayed dummy script with the default value `MAX_BLOCK_WEIGHT` (maximum size of a block)

PR based on the work of @luke-jr and @LarryRuane with the help of @nsvrn and @ChrisMartl
💬 achow101 commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#issuecomment-2414401962)
cc @l0rinc @hodlinator
💬 chrisguida commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-2414406419)
@dergoegge Think longer-term. It's a terrible precedent to say "oh, scam token protocols are using some old tx format that no one uses anymore because it's extremely inefficient, but we can't disable it because the scammers are paying miners tx fees". Following that precedent to its logical conclusion, bitcoin will eventually become *only* scam token protocols because gullible "investors" can always afford much more in miner fees if they think their $100 tx fee will lead to their scam token atta
...
💬 achow101 commented on pull request "wallet: Automatically repair corrupted metadata with doubled derivation path":
(https://github.com/bitcoin/bitcoin/pull/29124#issuecomment-2414410272)
cc @davidgumberg
💬 jasonandjay commented on pull request "doc: add dustThreshold explain of P2SH & P2TR":
(https://github.com/bitcoin/bitcoin/pull/30023#discussion_r1801486857)
This explanation will make the entire dust calculation logic more complete and I think it should be considered carefully.
💬 achow101 commented on pull request "test: cover base32/base58/base64 with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#issuecomment-2414420014)
cc @hodlinator
💬 achow101 commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-2414421152)
cc @tdb3
💬 achow101 commented on pull request "refactor: policy: Pass kernel::MemPoolOptions to IsStandard[Tx] rather than long list of individual options":
(https://github.com/bitcoin/bitcoin/pull/30232#issuecomment-2414424598)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs. The motivation is vague/missing.

Closing due to lack of interest.
achow101 closed a pull request: "refactor: policy: Pass kernel::MemPoolOptions to IsStandard[Tx] rather than long list of individual options"
(https://github.com/bitcoin/bitcoin/pull/30232)
💬 achow101 commented on pull request "build: improve cxx and linker flag caching":
(https://github.com/bitcoin/bitcoin/pull/30732#issuecomment-2414428036)
cc @hodlinator
💬 achow101 commented on pull request "CAT in Tapscript (BIP-347)":
(https://github.com/bitcoin/bitcoin/pull/29247#issuecomment-2414433454)
Converting to draft while waiting for consensus on this.
📝 achow101 converted_to_draft a pull request: "CAT in Tapscript (BIP-347)"
(https://github.com/bitcoin/bitcoin/pull/29247)
# CAT in Tapscript

This PR provides the necessary code to enable the opcode OP\_CAT in Tapscript as specified in [BIP-347: OP\_CAT in Tapscript](https://github.com/bitcoin/bips/blob/master/bip-0347.mediawiki) and [BIN-2024-0001](https://github.com/bitcoin-inquisition/binana/blob/master/2024/BIN-2024-0001.md),

**Important:** This PR *does not* include miner activation functionality. This means that merging this PR into bitcoin-core will not make OP\_CAT functional in Bitcoin.
If this PR is
...