✅ fanquake closed an issue: "test: Usage of `m_args` vs. `m_node.args`/`gArgs`"
(https://github.com/bitcoin/bitcoin/issues/25055)

🚀 fanquake merged a pull request: "doc: add doxygen for m_args in tests"
(https://github.com/bitcoin/bitcoin/pull/31083)

💬 stickies-v commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2413457129)
> I want to call `submitpackage` and I don't want to have to check if I have more than one transaction to do it. I'm lazy but that restriction seems arbitrary.

I had similar thoughts when reviewing `submitpackage` a while ago. Forcing the user to use different RPCs based on the number of transactions in a package feels arbitrary and not ergonomic to me. A package with size 1 should be a valid package and accepted as such in the relevant RPCs (slowly obsoleting their single-tx alternatives ove
...

📝 instagibbs opened a pull request: "rpc: Disallow non-matching transactions in combinerawtransaction"
(https://github.com/bitcoin/bitcoin/pull/31091)
Resolves #25980 by disallowing obviously broken usage. If txid doesn't match, we can't sensibly combine it.

💬 maflcko commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#issuecomment-2413460900)
lgtm ACK e64b2f1a16e8d0ad2cd181d84e3b70312e3cdf33

💬 l0rinc commented on pull request "CI: Add label to scripted-diffs":
(https://github.com/bitcoin/bitcoin/pull/31089#issuecomment-2413463202)
As an attack vector, people could prefix with `scripted–diff` (using an en dash or other unicode char which wouldn't be obvious to a human, but the CI wouldn't run the provided scripts). Adding a label would provide an extra level of safety to make sure the CI did its job.

Note that this is still a draft and doesn't seem to be working yet, comments like these are welcome.

🚀 fanquake merged a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859)

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#issuecomment-2413476340)
@fanquake can I get a 29.0 milestone for this?

💬 maflcko commented on pull request "CI: Add label to scripted-diffs":
(https://github.com/bitcoin/bitcoin/pull/31089#issuecomment-2413530272)
Those checks are part of the bash script itself. If there is a `BEGIN`, without a matching `scripted-diff` prefix, or vice-versa, the script should already fail.

💬 maflcko commented on pull request "CI: Add label to scripted-diffs":
(https://github.com/bitcoin/bitcoin/pull/31089#issuecomment-2413532736)
If there are (other) bugs, it would be good to enumerate them, with exact steps to reproduce. Then, it would be good to fix them. Once all bugs are fixed, I presume adding a label won't be needed.

💬 maflcko commented on pull request "rpc: Disallow non-matching transactions in combinerawtransaction":
(https://github.com/bitcoin/bitcoin/pull/31091#discussion_r1800909183)
```suggestion
throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Transactions to be combined do not match."));
```

nit?

✅ instagibbs closed a pull request: "rpc: Disallow non-matching transactions in combinerawtransaction"
(https://github.com/bitcoin/bitcoin/pull/31091)

💬 instagibbs commented on pull request "rpc: Disallow non-matching transactions in combinerawtransaction":
(https://github.com/bitcoin/bitcoin/pull/31091#issuecomment-2413539804)
nevermind, pre-segwit is lame, im outta here

💬 achow101 commented on pull request "rpc: Disallow non-matching transactions in combinerawtransaction":
(https://github.com/bitcoin/bitcoin/pull/31091#discussion_r1800915326)
For txs with pre-segwit and nested segwit inputs, txids will not match because the scriptSigs will be different. This check is actually more involved as the transactions need to have scriptSigs stripped.

💬 maflcko commented on pull request "lint: commit-script-check.sh: echo to stderr":
(https://github.com/bitcoin/bitcoin/pull/31063#issuecomment-2413547989)
This makes it easier to rebase a scripted-diff. Now, it is trivial to run it and redirect the failing diff and apply it later. Previously it was required to be manually edited before applying.

💬 l0rinc commented on pull request "CI: Add label to scripted-diffs":
(https://github.com/bitcoin/bitcoin/pull/31089#issuecomment-2413563398)
> If there is a BEGIN, without a matching scripted-diff

Which can be replaced with `BEGlN` (i.e. a lowercase L instead of an I or any other unicode trickery) and reviewers would be fooled into thinking that the scripts were validated by the CI.

📝 brunoerg opened a pull request: "doc: fuzz: remove Honggfuzz NetDriver instructions"
(https://github.com/bitcoin/bitcoin/pull/31092)
Remove Honggfuzz NetDriver instructions from the documentation since it has not been useful for us. See https://github.com/bitcoin/bitcoin/issues/30957 and https://github.com/bitcoin/bitcoin/pull/31012.

✅ brunoerg closed a pull request: "net: fuzz: bypass network magic and checksum validation"
(https://github.com/bitcoin/bitcoin/pull/31012)

💬 brunoerg commented on pull request "net: fuzz: bypass network magic and checksum validation":
(https://github.com/bitcoin/bitcoin/pull/31012#issuecomment-2413564192)
Closing this in favor of #31092

💬 maflcko commented on pull request "doc: fuzz: remove Honggfuzz NetDriver instructions":
(https://github.com/bitcoin/bitcoin/pull/31092#issuecomment-2413577707)
lgtm ACK d823ba6e20bd5fd312b65cf8f71c407c1861793e

Should be trivial to add back, if there is need.