✅ stickies-v closed an issue: "test: C++ debugger interferes with functional tests that quickly stop/start nodes"
(https://github.com/bitcoin/bitcoin/issues/23651)

💬 itornaza commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#issuecomment-2413410099)
reACK a0e089a71dc449f4cc177d6eb3050400e63f4b3f

👍 itornaza approved a pull request: "build: Bump minimum supported macOS to 13.0"
(https://github.com/bitcoin/bitcoin/pull/31048#pullrequestreview-2368758005)
reACK a0e089a71dc449f4cc177d6eb3050400e63f4b3f

💬 maflcko commented on issue "Default -rpcclienttimeout is too low for calls which cause rescan":
(https://github.com/bitcoin/bitcoin/issues/9918#issuecomment-2413423092)
> 3\. Add a warning in the help output for calls which trigger a rescan about the default -rpcclienttimeout being too low.

Seems like this could be an easy doc-only fix?

👍 hodlinator approved a pull request: "bench: add support for custom data directory"
(https://github.com/bitcoin/bitcoin/pull/31000#pullrequestreview-2368774548)
ACK 15cfeebb47587af6ce7be72fd52c57a0483d86d2

### Concept

Thanks @furszy for making the dependency explicit! I don't fully understand the upper/lower level argument as bench_bitcoin has a link dependency on test_util already.

Using ENV-vars instead as suggested in [other comment](https://github.com/bitcoin/bitcoin/pull/31000#discussion_r1800757127) seems too sneaky for me, and contradicts my goal of having things explicit. (IMO one original sin of C was `main` not taking environment args
...

👍 brunoerg approved a pull request: "doc: add doxygen for m_args in tests"
(https://github.com/bitcoin/bitcoin/pull/31083#pullrequestreview-2368790724)
ACK 1fe1b3ba8e9e73987a12fbd9eab7a29459d9f14c

✅ maflcko closed an issue: "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error"
(https://github.com/bitcoin/bitcoin/issues/29255)

💬 maflcko commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-2413443757)
> It must be a hardware issue, as no one else experiences this issue.

Ok, closing for now, but please do provide a comment with more details, if you find anything.

💬 hebasto commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#issuecomment-2413448037)
My Guix build:
```
aarch64
11dcf8e401c3cf7a911bf08cf801d354b53d8f4266b139625ef12f502050ee4f guix-build-a0e089a71dc4/output/arm64-apple-darwin/SHA256SUMS.part
d00bfbd05b870fdd4a1b7626bc0e851a88a3b958a1ff78d6822ed85f743c7c8a guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned.tar.gz
fc0dcd590d775f6e565ec6d7a005e525891b90b5afdd1f6d429d9f615792ca2b guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned
...

✅ maflcko closed an issue: "LevelDB read failure: Corruption: block checksum mismatch"
(https://github.com/bitcoin/bitcoin/issues/30159)

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2413449154)
Closing for now due to inactivity and because I couldn't reproduce this so far.

If you have *exact* and *full* steps to reproduce, starting from a fresh install of the AWS machine, with all settings, etc, I can take another look.

In the meantime, closing for now, but please do provide a comment with more details, if you find anything.

✅ maflcko closed an issue: "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs"
(https://github.com/bitcoin/bitcoin/issues/30692)

💬 maflcko commented on issue "Fatal LevelDB error: Corruption: block checksum mismatch on Linux ext4 SATA SSDs":
(https://github.com/bitcoin/bitcoin/issues/30692#issuecomment-2413450378)
Closing for now due to inactivity, but please do provide a comment with more details, if you find anything.

✅ fanquake closed an issue: "test: Usage of `m_args` vs. `m_node.args`/`gArgs`"
(https://github.com/bitcoin/bitcoin/issues/25055)

🚀 fanquake merged a pull request: "doc: add doxygen for m_args in tests"
(https://github.com/bitcoin/bitcoin/pull/31083)

💬 stickies-v commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2413457129)
> I want to call `submitpackage` and I don't want to have to check if I have more than one transaction to do it. I'm lazy but that restriction seems arbitrary.

I had similar thoughts when reviewing `submitpackage` a while ago. Forcing the user to use different RPCs based on the number of transactions in a package feels arbitrary and not ergonomic to me. A package with size 1 should be a valid package and accepted as such in the relevant RPCs (slowly obsoleting their single-tx alternatives ove
...

📝 instagibbs opened a pull request: "rpc: Disallow non-matching transactions in combinerawtransaction"
(https://github.com/bitcoin/bitcoin/pull/31091)
Resolves #25980 by disallowing obviously broken usage. If txid doesn't match, we can't sensibly combine it.

💬 maflcko commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#issuecomment-2413460900)
lgtm ACK e64b2f1a16e8d0ad2cd181d84e3b70312e3cdf33

💬 l0rinc commented on pull request "CI: Add label to scripted-diffs":
(https://github.com/bitcoin/bitcoin/pull/31089#issuecomment-2413463202)
As an attack vector, people could prefix with `scripted–diff` (using an en dash or other unicode char which wouldn't be obvious to a human, but the CI wouldn't run the provided scripts). Adding a label would provide an extra level of safety to make sure the CI did its job.

Note that this is still a draft and doesn't seem to be working yet, comments like these are welcome.

🚀 fanquake merged a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859)