💬 willcl-ark commented on issue "Historical scripted-diff failures (trivial)":
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411648418)
Closed at request of author.

✅ willcl-ark closed an issue: "Since 0.16 Bitcoin can be stuck connected to adversarial/3rdparty node"
(https://github.com/bitcoin/bitcoin/issues/29506)

💬 willcl-ark commented on issue "Since 0.16 Bitcoin can be stuck connected to adversarial/3rdparty node":
(https://github.com/bitcoin/bitcoin/issues/29506#issuecomment-2411653961)
The problem is not easily reproducible.

Please open a new issue (or leave a comment in here if you want this re-opened) if you experience the problem again.

💬 maflcko commented on issue "Historical scripted-diff failures (trivial)":
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411656801)
IIRC the exit code is ignored either way, because `./test/lint/commit-script-check.sh` doesn't set `-e`, but you do.

That may also be the reason they were not found by CI.

✅ willcl-ark closed an issue: "Default -rpcclienttimeout is too low for calls which cause rescan"
(https://github.com/bitcoin/bitcoin/issues/9918)

💬 willcl-ark commented on issue "Default -rpcclienttimeout is too low for calls which cause rescan":
(https://github.com/bitcoin/bitcoin/issues/9918#issuecomment-2411658195)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.

✅ willcl-ark closed an issue: "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist"
(https://github.com/bitcoin/bitcoin/issues/25868)

💬 willcl-ark commented on issue "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist":
(https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-2411660857)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.

✅ willcl-ark closed an issue: "build warnings in outputtype.cpp: may be used uninitialized"
(https://github.com/bitcoin/bitcoin/issues/29359)

💬 willcl-ark commented on issue "build warnings in outputtype.cpp: may be used uninitialized":
(https://github.com/bitcoin/bitcoin/issues/29359#issuecomment-2411668157)
This is an upstream issue and will be solved next time you upgrade your toolchain.

Closing for now. Leave a comment if you want this re-opened.

💬 darosior commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-2411676907)
This CVE is disputed. The large majority of contributors to this project disagree this is indeed a security vulnerability. I personally believe the CVE system is being abused in this case.

I believe this issue should be closed. There is no point in keeping it open.

🤔 jarolrod reviewed a pull request: "build: Fix kernel static lib component install"
(https://github.com/bitcoin/bitcoin/pull/31078#pullrequestreview-2367206853)
concept ack

master install

```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoinkernel.a
```



pr install

```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoin_crypto.a
-- Installing: /usr/local/lib/libbitcoin_crypto_sse41.a
-- Installing: /usr/local/lib/libbitcoin_crypto_avx2.a
-- Installing: /usr/local/lib/libbitcoin_cryp
...

⚠️ danielabrozzoni opened an issue: "Unable to compile for test coverage on Nixos 24.05"
(https://github.com/bitcoin/bitcoin/issues/31087)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I'm trying to compile Bitcoin Core for test coverage as explained in `doc/developer-notes.md`, but the command `cmake -P build/Coverage.cmake` fails with
```
[...]
Finished .info-file creation
Deleting all .da files in src and subdirectories
Done.
.lcov-wrapped: WARNING: negative counts found in tracefile test_bitcoin_filtered.info
Combining tracefiles.
Reading tracefile test_bitc
...

💬 Av32000 commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#discussion_r1799983029)
I agree with you, I'm closing the pr.

✅ Av32000 closed a pull request: "doc: Add xz-utils to the general dependencies for windows build"
(https://github.com/bitcoin/bitcoin/pull/31084)

💬 Fidel76y commented on issue "Setting torcontrol overrides proxy address":
(https://github.com/bitcoin/bitcoin/issues/25265#issuecomment-2412085149)
According to my understanding bitcoin core designed automatically to configure tor when using `torcontrol,` when `torcontrol` is active the device automatically manages the tor instance making it override the manual proxy configuration

⚠️ ismaelsadeeq opened an issue: "wallet: rpc: `settxfee` sets the wallet feerate not fee"
(https://github.com/bitcoin/bitcoin/issues/31088)
The wallet RPC `settxfee` sets the fee rate for a wallet.

Current help text:
```
Set the transaction fee rate in BTC/kvB for this wallet. Overrides the global -paytxfee command line parameter.
Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.

Arguments:
1. amount (numeric or string, required) The transaction fee rate in BTC/kvB

Result:
true|false (boolean) Returns true if successful
```
This is a misnomer, as stated h
...

💬 ismaelsadeeq commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2412341951)
> I'm not sure. Point 3 and the rationales in [#20484 (comment)](https://github.com/bitcoin/bitcoin/pull/20484#issuecomment-734786305) suggest a possibly safer way (perhaps you have a workaround in mind I'm overlooking).

You are right! I opened an issue for this #31088

💬 1440000bytes commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2412347684)
No IPv6 support?

💬 ismaelsadeeq commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2412355904)
> While reviwing data from [txstats](https://txstats.com/d/000000011/fee-estimation?orgId=1) in the context of optimizing how Eclair manages its utxo set I noticed the large variation between estimatesmartfee and, for example, mempool.space fee estimation.

Also see https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2128952313

> Eclair uses `estimatesmartfee` and recently changed from the (previous) default to economical

Bitcoin Core 28.0 also updated its default to `economical`
...