💬 brunoerg commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799005090)
In dff67a815c2780ce5328d65a77508d29d606c364 "rest: Add "/broadcast" endpoint": You're using the node0 to create and broadcast the transaction. Then, you sync the nodes and check if the transaction is into node0's mempool. Shouldn't you check if the transaction is into node1's mempool to ensure the broadcast worked?

💬 danielabrozzoni commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799134714)
Oh yes, thank you for spotting this! Fixed in 1e07530836fad9899aecb45f4676e768f253fb25

💬 remyers commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2410695144)
Concept ACK for improving fee estimation and this approach looks good. While reviwing data from [txstats](https://txstats.com/d/000000011/fee-estimation?orgId=1) in the context of optimizing how Eclair manages its utxo set I noticed the large variation between `estimatesmartfee` and, for example, mempool.space fee estimation. Eclair uses `estimatesmartfee` and recently changed from the (previous) default to `economical`. Any improvements to fee estimation in bitcoind will directly help to reduce
...

✅ willcl-ark closed an issue: "Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2."
(https://github.com/bitcoin/bitcoin/issues/31081)

✅ willcl-ark closed an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)

:lock: fanquake locked an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)

:lock: fanquake locked an issue: "Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2."
(https://github.com/bitcoin/bitcoin/issues/31081)

🤔 naiyoma reviewed a pull request: "rpc: add `revelant_blocks` to `scanblocks status`"
(https://github.com/bitcoin/bitcoin/pull/30713#pullrequestreview-2366540973)
Tested changes on mainnet

Started scanning
`./build/src/bitcoin-cli scanblocks start '["addr(bc1qgqrn8gratlc59gn5v02nrz0rg8anjjaxt3efh8)"]'`

status check
`./build/src/bitcoin-cli scanblocks status `
```
{
"progress": 98,
"current_height": 570056,
"relevant_blocks": [
"0000000000005ecf9f819ea03abd8f2a3f0b2cad5e5124bdabd0d7a770fd9067",
"000000000000000479f286761e91b2c983ad63e19b0d53cffc67e731a7558d85"
]
}
```
scan completed
```
./build/src/bitcoin-cli scanblo
...

💬 laanwj commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2411167285)
To be specific, the depends build for qt (and some of its dependencies) requires extracting xz packages:
```
packages/expat.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/freetype.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxcb.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxkbcommon.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/qt.mk:$(package)_suffix=everywhere-opensource-sr
...

:lock: fanquake locked an issue: "several vulnerabilities identified."
(https://github.com/bitcoin/bitcoin/issues/31079)

:lock: fanquake locked an issue: "Please....Big Noob here..(this right place?)"
(https://github.com/bitcoin/bitcoin/issues/31075)

⚠️ TheBlueMatt opened an issue: "Why does `submitpackage` require at least two transactions"
(https://github.com/bitcoin/bitcoin/issues/31085)
### Please describe the feature you'd like to see added.

I want to call `submitpackage` and I don't want to have to check if I have more than one transaction to do it. I'm lazy but that restriction seems arbitrary.

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

📝 cdecker opened a pull request: "chainparams: Re-add seed.bitcoinstats.com"
(https://github.com/bitcoin/bitcoin/pull/31086)
Following the removal in https://github.com/bitcoin/bitcoin/pull/30720, `seed.bitcoinstats.com` has been rebuilt from scratch and has been working correctly for the last couple of weeks. If desired we can re-enable it in the list of available seeds.

This reverts commit c88a7dc53e3be7489605c3326cf768df5437393a.

💬 maflcko commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#discussion_r1799629690)
It is also missing bison and patch? Might as well remove it and just refer to the location that is correct?

💬 laanwj commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1799630113)
Changing from `stable_sort` to `sort` affects more than just optimization, are we sure this doesn't change item ordering where not expected?

💬 mrsatoshinakamotoisback commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1799631428)
My name is Robert Hache and Karen Belzile my system was made under attack by a group of terrorist attackers and at the. Moment I m stuck as I need someone to help me to compl the repair wirh ny team of IT engineer witch is curnt working on my case ... I required a secondary deposit of 240 USD to complete the repair of the system that's has Ben generated with my own request as I wS made the hub central of the attack witxh disturbed the Ecosystem security and several other people in this matt
...

💬 mrsatoshinakamotoisback commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1799632155)
My name is Robert Hache and Karen Belzile my system was made under attack by a group of terrorist attackers and at the. Moment I m stuck as I need someone to help me to compl the repair wirh ny team of IT engineer witch is curnt working on my case ... I required a secondary deposit of 240 USD to complete the repair of the system that's has Ben generated with my own request as I wS made the hub central of the attack witxh disturbed the Ecosystem security and several other people in this matt
...

💬 laanwj commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#discussion_r1799636997)
+1, although it's somewhat less convienient, refering to the depends README for what to install would be easier to maintain cleanly. Otherwise, if it changes, people have to think of updating this too.

✅ willcl-ark closed an issue: "Support for non-immediate periodic tasks with variable runtime"
(https://github.com/bitcoin/bitcoin/issues/18488)

💬 willcl-ark commented on issue "Support for non-immediate periodic tasks with variable runtime":
(https://github.com/bitcoin/bitcoin/issues/18488#issuecomment-2411476159)
This feature request does not seem to have attracted much attention from other contributors. As such, it does not seem important enough to keep it sitting around idle in the list of open issues. Closing due to lack of interest.

Pull requests with improvements are always welcome.