💬 pinheadmz commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2409137861)
This xz?

https://en.wikipedia.org/wiki/XZ_Utils_backdoor

✅ brunoerg closed a pull request: "contrib: add test for bucketing with asmap"
(https://github.com/bitcoin/bitcoin/pull/28869)

💬 brunoerg commented on pull request "contrib: add test for bucketing with asmap":
(https://github.com/bitcoin/bitcoin/pull/28869#issuecomment-2409138944)
Closing for now.

💬 Av32000 commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2409187469)
Yes but required for `qt` build

💬 ariard commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2409353977)
@0xB10C Very interesting to have the logs about unsolicited transactions from network peers

> I've mostly seen the same few peers sending me unsolicited transactions - at a rate of a few per minute.

User agent might not be verbose that much if they are lightweight clients (e.g ones based on bitcoinj lib) doing transaction broadcast, with no INV before. It could be interesting to get volume of the unsolicited transactions, if there are more likely to come from lightweight clients doing few
...

💬 ariard commented on pull request "Add NODE_TXRELAY_V2.":
(https://github.com/bitcoin/bitcoin/pull/30837#discussion_r1798625492)
will fix it, still looking more for reviews on the BIPs themselves for the disruption minimization approach of restraining the acceptance of unsolicited transactions among upgraded peers only.

💬 ariard commented on issue "Prioritize processing of peers based on their CPU usage":
(https://github.com/bitcoin/bitcoin/issues/31033#issuecomment-2409388532)
I think you can have a look on the discussions in the old #21224 PR. At the time, there were few ideas discussed for the wider mitigations of CPU usage as a denial-of-service. While effectively, unsolicited transactions is far less concerning than CPU usage as a denial-of-service, when #21224 was opened it was realized one of the first step to have DoS mitigations in depth about DoSy transaction-relay was to halt the processing of unrequested transactions.

See again what I was advocating at t
...

💬 brunoerg commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799005090)
In dff67a815c2780ce5328d65a77508d29d606c364 "rest: Add "/broadcast" endpoint": You're using the node0 to create and broadcast the transaction. Then, you sync the nodes and check if the transaction is into node0's mempool. Shouldn't you check if the transaction is into node1's mempool to ensure the broadcast worked?

💬 danielabrozzoni commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799134714)
Oh yes, thank you for spotting this! Fixed in 1e07530836fad9899aecb45f4676e768f253fb25

💬 remyers commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2410695144)
Concept ACK for improving fee estimation and this approach looks good. While reviwing data from [txstats](https://txstats.com/d/000000011/fee-estimation?orgId=1) in the context of optimizing how Eclair manages its utxo set I noticed the large variation between `estimatesmartfee` and, for example, mempool.space fee estimation. Eclair uses `estimatesmartfee` and recently changed from the (previous) default to `economical`. Any improvements to fee estimation in bitcoind will directly help to reduce
...

✅ willcl-ark closed an issue: "Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2."
(https://github.com/bitcoin/bitcoin/issues/31081)

✅ willcl-ark closed an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)

:lock: fanquake locked an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)

:lock: fanquake locked an issue: "Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2."
(https://github.com/bitcoin/bitcoin/issues/31081)

🤔 naiyoma reviewed a pull request: "rpc: add `revelant_blocks` to `scanblocks status`"
(https://github.com/bitcoin/bitcoin/pull/30713#pullrequestreview-2366540973)
Tested changes on mainnet

Started scanning
`./build/src/bitcoin-cli scanblocks start '["addr(bc1qgqrn8gratlc59gn5v02nrz0rg8anjjaxt3efh8)"]'`

status check
`./build/src/bitcoin-cli scanblocks status `
```
{
"progress": 98,
"current_height": 570056,
"relevant_blocks": [
"0000000000005ecf9f819ea03abd8f2a3f0b2cad5e5124bdabd0d7a770fd9067",
"000000000000000479f286761e91b2c983ad63e19b0d53cffc67e731a7558d85"
]
}
```
scan completed
```
./build/src/bitcoin-cli scanblo
...

💬 laanwj commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2411167285)
To be specific, the depends build for qt (and some of its dependencies) requires extracting xz packages:
```
packages/expat.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/freetype.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxcb.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxkbcommon.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/qt.mk:$(package)_suffix=everywhere-opensource-sr
...

:lock: fanquake locked an issue: "several vulnerabilities identified."
(https://github.com/bitcoin/bitcoin/issues/31079)

:lock: fanquake locked an issue: "Please....Big Noob here..(this right place?)"
(https://github.com/bitcoin/bitcoin/issues/31075)

⚠️ TheBlueMatt opened an issue: "Why does `submitpackage` require at least two transactions"
(https://github.com/bitcoin/bitcoin/issues/31085)
### Please describe the feature you'd like to see added.

I want to call `submitpackage` and I don't want to have to check if I have more than one transaction to do it. I'm lazy but that restriction seems arbitrary.

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

📝 cdecker opened a pull request: "chainparams: Re-add seed.bitcoinstats.com"
(https://github.com/bitcoin/bitcoin/pull/31086)
Following the removal in https://github.com/bitcoin/bitcoin/pull/30720, `seed.bitcoinstats.com` has been rebuilt from scratch and has been working correctly for the last couple of weeks. If desired we can re-enable it in the list of available seeds.

This reverts commit c88a7dc53e3be7489605c3326cf768df5437393a.