💬 furszy commented on pull request "bench: add support for custom data directory":
(https://github.com/bitcoin/bitcoin/pull/31000#discussion_r1798442580)
I do think that referencing upper-level binaries in lower-level framework code isn't ideal, and duplicating a single line for an argument that rarely changes behavior is harmless. Especially when the small deduplication comes with other unnecessary stuff and isn't truly a duplication as the help text is customized for benchmark binary users. But, that said, we're already breaking the first point elsewhere in `setup_common.h`, so np. Will re-touch a bit your suggestion and push it.

✅ furszy closed a pull request: "[WIP] p2p: send not_found msgs for unknown, pruned or unwilling to share blocks"
(https://github.com/bitcoin/bitcoin/pull/30385)

💬 danielabrozzoni commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1798526862)
I wanted to keep the API easier by passing only the transaction hex in the body, instead of asking for a whole JSON with optional `maxfeerate`/`maxburnamount` (same parameters as sendrawtransaction), and without the ability to set the maxfeerate, having zero (=suppress the check) is better than having the default max fee rate (otherwise you wouldn't be able to broadcast a very high-paying transaction even if you really wanted to).

Additionally, I think most people that would use this API woul
...

💬 1440000bytes commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1798552649)
I don't have a strong opinion either.

👍 1440000bytes approved a pull request: "rest: Support transaction broadcast in REST interface"
(https://github.com/bitcoin/bitcoin/pull/31065#pullrequestreview-2364985834)
utACK https://github.com/bitcoin/bitcoin/pull/31065/commits/dff67a815c2780ce5328d65a77508d29d606c364

📝 Av32000 opened a pull request: "doc: Add xz-utils to the general dependencies for windows build"
(https://github.com/bitcoin/bitcoin/pull/31084)
The `xz-utils` package is not always installed by default on WSL. So when compiling bitcoin core for windows following the [doc](https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md) the compilation of `qt` causes a critical error. `xz-utils` must then be installed afterwards. The bug creates a folder `/bitcoin/depends/work/build/x86_64-w64-mingw32/qt` which blocks the compilation process. You need to manually delete this folder to continue compiling.

`xz-utils`, installed by d
...

👍 Patres7771 approved a pull request: "doc: Add xz-utils to the general dependencies for windows build"
(https://github.com/bitcoin/bitcoin/pull/31084#pullrequestreview-2364994460)
****

💬 pinheadmz commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2409137861)
This xz?

https://en.wikipedia.org/wiki/XZ_Utils_backdoor

✅ brunoerg closed a pull request: "contrib: add test for bucketing with asmap"
(https://github.com/bitcoin/bitcoin/pull/28869)

💬 brunoerg commented on pull request "contrib: add test for bucketing with asmap":
(https://github.com/bitcoin/bitcoin/pull/28869#issuecomment-2409138944)
Closing for now.

💬 Av32000 commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#issuecomment-2409187469)
Yes but required for `qt` build

💬 ariard commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2409353977)
@0xB10C Very interesting to have the logs about unsolicited transactions from network peers

> I've mostly seen the same few peers sending me unsolicited transactions - at a rate of a few per minute.

User agent might not be verbose that much if they are lightweight clients (e.g ones based on bitcoinj lib) doing transaction broadcast, with no INV before. It could be interesting to get volume of the unsolicited transactions, if there are more likely to come from lightweight clients doing few
...

💬 ariard commented on pull request "Add NODE_TXRELAY_V2.":
(https://github.com/bitcoin/bitcoin/pull/30837#discussion_r1798625492)
will fix it, still looking more for reviews on the BIPs themselves for the disruption minimization approach of restraining the acceptance of unsolicited transactions among upgraded peers only.

💬 ariard commented on issue "Prioritize processing of peers based on their CPU usage":
(https://github.com/bitcoin/bitcoin/issues/31033#issuecomment-2409388532)
I think you can have a look on the discussions in the old #21224 PR. At the time, there were few ideas discussed for the wider mitigations of CPU usage as a denial-of-service. While effectively, unsolicited transactions is far less concerning than CPU usage as a denial-of-service, when #21224 was opened it was realized one of the first step to have DoS mitigations in depth about DoSy transaction-relay was to halt the processing of unrequested transactions.

See again what I was advocating at t
...

💬 brunoerg commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799005090)
In dff67a815c2780ce5328d65a77508d29d606c364 "rest: Add "/broadcast" endpoint": You're using the node0 to create and broadcast the transaction. Then, you sync the nodes and check if the transaction is into node0's mempool. Shouldn't you check if the transaction is into node1's mempool to ensure the broadcast worked?

💬 danielabrozzoni commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1799134714)
Oh yes, thank you for spotting this! Fixed in 1e07530836fad9899aecb45f4676e768f253fb25

💬 remyers commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2410695144)
Concept ACK for improving fee estimation and this approach looks good. While reviwing data from [txstats](https://txstats.com/d/000000011/fee-estimation?orgId=1) in the context of optimizing how Eclair manages its utxo set I noticed the large variation between `estimatesmartfee` and, for example, mempool.space fee estimation. Eclair uses `estimatesmartfee` and recently changed from the (previous) default to `economical`. Any improvements to fee estimation in bitcoind will directly help to reduce
...

✅ willcl-ark closed an issue: "Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2."
(https://github.com/bitcoin/bitcoin/issues/31081)

✅ willcl-ark closed an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)

:lock: fanquake locked an issue: "- Fixed a minor bug that incorrectly printed the wrong status message to the user during remote verification."
(https://github.com/bitcoin/bitcoin/issues/31082)