💬 kevkevinpal commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1797449852)
Thank you! updated in [4d59b9a](https://github.com/bitcoin/bitcoin/pull/31040/commits/4d59b9a517afb5eb661b7bc179c51141769658a3)

💬 kevkevinpal commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1797449904)
agreed! Updated in [4d59b9a](https://github.com/bitcoin/bitcoin/pull/31040/commits/4d59b9a517afb5eb661b7bc179c51141769658a3)

⚠️ DpTheSaint opened an issue: "Please....Big Noob here..(this right place?)"
(https://github.com/bitcoin/bitcoin/issues/31075)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Hello, Big noob here. I appreciate you taking the time to read this. I have tried scouring the internet including Github for issues similar to what I am experiencing while Syncing The blockchain on my Host Machine. This is not my first time syncing Core to my Pc, but it is the first time I'm experiencing an issue. The same issue arises both on my Linux OS (same machine) and on my Windows
...

💬 DpTheSaint commented on issue "Please....Big Noob here..(this right place?)":
(https://github.com/bitcoin/bitcoin/issues/31075#issuecomment-2408235250)
i got another popup when i tried to exit QT.

Microsoft Visual C++ Runtime Library:

Assertion failed!
Program c:\Program Files\Bitcoin\bitcoin-qt.exe
file: txdb.cpp
Line: 105

expression: old_heads[0] == hashBlock

for information on how your program can cause an assertion failure, see the visual c++ docs

not sure if this is relevant but thought i'd share it . it popped up after the original error pop-up.

💬 1440000bytes commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#discussion_r1797504637)
Why `max_tx_fee` zero? `sendrawtransaction` RPC has a different default

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2408260421)
Rebased and updated the libsecp subtree to its master

Still need to work on the location of musig specific functions as currently it requires linking secp256k1 directly for a bunch of targets.

👍 tdb3 approved a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859#pullrequestreview-2363689558)
re ACK e64b2f1a16e8d0ad2cd181d84e3b70312e3cdf33

💬 DpTheSaint commented on issue "Please....Big Noob here..(this right place?)":
(https://github.com/bitcoin/bitcoin/issues/31075#issuecomment-2408267000)
Tried again, This time when i exited i didn't get the Microsoft Visual C++ Error but it still gave me Fatal leveldb error, but this time instead of 001325, it was 001355, not the same block, why is this happening?

💬 ryanofsky commented on pull request "refactor: Clean up messy strformat and bilingual_str usages":
(https://github.com/bitcoin/bitcoin/pull/31072#issuecomment-2408293678)
Updated 9a101d2928d14e39365064dc976615b4b9674ca5 -> 022ffd149a64f944d1ade75664e8dc19d04bcda7 ([`pr/bfmt.1`](https://github.com/ryanofsky/bitcoin/commits/pr/bfmt.1) -> [`pr/bfmt.2`](https://github.com/ryanofsky/bitcoin/commits/pr/bfmt.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/bfmt.1-rebase..pr/bfmt.2)) to include more cleanups and help simplify implementation of compile-time translated string format checking in #31061 or #31074

---

re: https://github.com/bitcoin/bitcoin/
...

✅ ryanofsky closed a pull request: "util: Check bilingual_str format strings at compile time"
(https://github.com/bitcoin/bitcoin/pull/31074)

💬 ryanofsky commented on pull request "util: Check bilingual_str format strings at compile time":
(https://github.com/bitcoin/bitcoin/pull/31074#issuecomment-2408295163)
Will close this. There may be some useful ideas here but I don't think this is a clear win over #31061

💬 ryanofsky commented on pull request "refactor: Check translatable format strings at compile-time":
(https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1797526070)
re: https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1793837788

Opened #31072 to implement suggested simplification. Marking this thread resolved since it it's not meant to block this PR in any case.

💬 ryanofsky commented on pull request "refactor: Check translatable format strings at compile-time":
(https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1797526861)
re: https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1793707636

Simplified this further in 6fb39655c5cd2bebad902d271d1edae64b817d2b from #31072. It might just be a bug that this string is not translated, and there also seems to be trailing whitespace in the string. Current commit just simplifies code and keeps existing behavior though.

⚠️ Bombay268 opened an issue: "Wallet usdt"
(https://github.com/bitcoin/bitcoin/issues/31076)
Transférer usdt et déposer compte bancaire

🤔 tdb3 reviewed a pull request: "bench: add support for custom data directory"
(https://github.com/bitcoin/bitcoin/pull/31000#pullrequestreview-2363731043)
Approach ACK
Useful improvement.

Did a quick sanity check for now (ramdisk at /mnt/tmp/).
Planning to circle back.

```
$ build/src/bench/bench_bitcoin -testdatadir=/mnt/tmp/
$ ls /mnt/tmp/test_common\ bitcoin
AssembleBlock DuplicateInputs MempoolCheck WalletBalanceDirty WalletIsMineDescriptors
BlockAssemblerAddPackageTxns LoadExternalBlockFile MempoolEviction WalletBalanceMine Wal
...

💬 Bombay268 commented on issue "Wallet usdt":
(https://github.com/bitcoin/bitcoin/issues/31076#issuecomment-2408337828)
https://tether.to/...00000000000000001e76250b3725547b5887329cfe3a8bb930a70e66747384d3. Blokchain Dash

✅ Bombay268 closed an issue: "Wallet usdt"
(https://github.com/bitcoin/bitcoin/issues/31076)

👍 tdb3 approved a pull request: "doc: update signet documentation related to build directories"
(https://github.com/bitcoin/bitcoin/pull/30996#pullrequestreview-2363732591)
Code review and light test ACK a647d4400d55558735f102988e84eedc39b3affa

💬 sweep-the-lotus commented on issue "Bitcoin Core "not opened" after software update to macOS Sequoia 15.0.1 (24A348)":
(https://github.com/bitcoin/bitcoin/issues/31069#issuecomment-2408345476)
I also have had difficulty finding my Bitcoin folder- I did this : open a terminal type. cd ~/Library
then if you type ls you will see the Application Support folder. type cd "Application Support"
that will put you inside the Application Support folder or directory, type. ls ,you should then see the Bitcoin folder ( directory ). type cd Bitcoin you will now be inside the Bitcoin folder you will now have
access to your files. Unix and Linux you need to put " " when there is
...

💬 sweep-the-lotus commented on issue "Bitcoin Core "not opened" after software update to macOS Sequoia 15.0.1 (24A348)":
(https://github.com/bitcoin/bitcoin/issues/31069#issuecomment-2408389062)
there is an easier way , found this at stackexchange :

"On the new Mac OS X you can't see the Bitcoin folder in the library under /application support/. You have to use Finder and in the menu look for GO and then GO TO type ~/Library in the box. After that you can see the Bitcoin folder under /application support/. " so open a folder and in the right hand upper corner click on the magnifing glass ie search and paste in or type ~/Library hit enter
from there it will beclear wha
...