🤔 naiyoma reviewed a pull request: "test: add test for specifying custom pidfile via `-pid`"
(https://github.com/bitcoin/bitcoin/pull/30724#pullrequestreview-2361352509)
Tested ACK [https://github.com/bitcoin/bitcoin/pull/30724/commits/04e4d52420a0e6bf40d4bd6fe1f31f66db9eab0a](https://github.com/bitcoin/bitcoin/pull/30724/commits/04e4d52420a0e6bf40d4bd6fe1f31f66db9eab0a)

💬 hodlinator commented on pull request "bench: add support for custom data directory":
(https://github.com/bitcoin/bitcoin/pull/31000#discussion_r1796096553)
Adding a dependency on *setup_common.h* is a case of making implicit dependencies explicit in my view. What the current version signifies is a different argument description (starting with "Run benchmarks " like the others) and a default directory value that *can't* be as clear as the original. We shouldn't be duplicating code snippets to avoid `#include`s. Even if it minimizes the size of this specific PR, going forward one has to make sure to keep both the original and duplicated place up to d
...

💬 theuni commented on pull request "Don't zero-after-free `DataStream`: Faster IBD on some configurations":
(https://github.com/bitcoin/bitcoin/pull/30987#issuecomment-2406059129)
> I also made a branch([davidgumberg@c832fed](https://github.com/davidgumberg/bitcoin/commit/c832feda63c586094193433a336b930147472285)) with a version of the zero after free allocator that keeps the compiler optimization prevention, but doesn't actually memset the stream to zero, and performance in some cases is only slightly better than master.

This is an interesting (and expected, I suppose) takeaway. Sadly, it suggests that there's really nothing that we can do to optimize our implementati
...

🤔 jonatack reviewed a pull request: "test: add end-to-end tests for CConnman and PeerManager"
(https://github.com/bitcoin/bitcoin/pull/26812#pullrequestreview-2361487622)
Light ACK 752fbab26aa67b01249ef5948d5c78e0e5a5244e per `git range-diff 489e5aa 612ba17 752fbab` since my previous ACK at https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-1613651346 and a quick re-read of the full changes rebased to current master. I like that the changes here are essentially limited to tests only.

💬 jonatack commented on pull request "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'":
(https://github.com/bitcoin/bitcoin/pull/29418#discussion_r1796164843)
```suggestion
if (key == "") {
if (key.empty()) {
```

💬 Wronskode commented on issue "Listen on random port by default (not 8333)":
(https://github.com/bitcoin/bitcoin/issues/31036#issuecomment-2406165683)
This may causes problems if we have to open the port on the rooter ?

💬 jonatack commented on issue "Listen on random port by default (not 8333)":
(https://github.com/bitcoin/bitcoin/issues/31036#issuecomment-2406179522)
> Currently, about 7% of my IPv4/IPv6 addrman entries use non 8333 port.

Same.

💬 furszy commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#issuecomment-2406197220)
@josibake @achow101 friendly ping. It seems we are quite close here.

⚠️ diivvy opened an issue: "BitcoinCore wallet not showing in my macbook "applications" after software update to macOS Sequoia 15.0.1 (24A348)"
(https://github.com/bitcoin/bitcoin/issues/31069)
Hello,
I have a macbook pro 2021 (1 TB) and this has been my primary device to store my bitcoins. I had downloaded bitcoin core wallet on this mac about 2-3 years ago ( I don't exactly remember when). It was working fine all this while but after this new mac update to Sequoia 15.0.1, I am unable to see the bitcoin core wallet on my mac. I can't see it on the "applications" or in the "finder" or in the "launchpad" of my mac.

I can see that the storage is still occupied in my mac worth about
...

💬 diivvy commented on issue "BitcoinCore wallet not showing in my macbook "applications" after software update to macOS Sequoia 15.0.1 (24A348)":
(https://github.com/bitcoin/bitcoin/issues/31069#issuecomment-2406367132)
@hebasto Please help me in this. How can I contact you regarding this issue?

💬 Troy-ling commented on issue "BitcoinCore wallet not showing in my macbook "applications" after software update to macOS Sequoia 15.0.1 (24A348)":
(https://github.com/bitcoin/bitcoin/issues/31069#issuecomment-2406553727)
Hey there @diivvy !

I hope your issue has been resolved by now. If not, I sincerely apologize for the delayed response. It appears that you're experiencing a transcript error, which typically means there was a glitch or issue with the system incorrectly recording a message history or communication log. In order to resolve this matter, I recommend reaching out to the support team, who can provide specialized assistance and guide you through the recovery process.

I've already created a suppo
...

💬 maflcko commented on issue "ci: failure in win64 unit tests":
(https://github.com/bitcoin/bitcoin/issues/30792#issuecomment-2406589710)
Ok, with the current 31067:

```
# while ( LC_ALL=C.UTF-8 BITCOINUTIL=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-util.exe BITCOINTX=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-tx.exe /usr/bin/python3 /ci_container_base/ci/scratch/build-x86_64-w64-mingw32/test/util/test_runner.py ) ; do ( echo '...' && echo 1 >> /tmp/runs ) ; done

...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...
...

💬 maflcko commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-2406668697)
The pull descriptions claims to add a fuzz test, but I can't see anything related to fuzzing

💬 vasild commented on issue "Distribute darknet node addresses via DNS seeds using AAAA records":
(https://github.com/bitcoin/bitcoin/issues/31062#issuecomment-2406676052)
Concept ACK

> ... from the not publicly routable fc00::/7 subnet ...

This overlaps with CJDNS which [uses `fc00::/8`](https://github.com/cjdelisle/cjdns/blob/master/doc/Whitepaper.md#pulling-it-all-together). This should be ok since those special AAAA records are going to be server by special DNS servers that are separate from the existent ones. Whoever queries them will be aware of the special encoding. Then maybe a special prefix is not needed at all?

Since this is Bitcoin P2P specifi
...

💬 vasild commented on issue "Listen on random port by default (not 8333)":
(https://github.com/bitcoin/bitcoin/issues/31036#issuecomment-2406687686)
> This may causes problems if we have to open the port on the rooter ?

You mean so that the node behind the router, which listens on non-8333 port be reachable from the internet? From the perspective of opening the port on the router a random port is no different than 8333. The idea is only about new installations, existent ones won't be affected. And it is only about the default behavior, so even on new installations one would be able to use `port=8333` or `bind=whatever:8333`.

💬 mkurdist commented on issue "Consider making 27.x Long-Term Support (LTS)":
(https://github.com/bitcoin/bitcoin/issues/31068#issuecomment-2406694877)
It would have been much better if the problem of Bitcoin's terrible fees had been solved

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-2406695750)
> The pull descriptions claims to add a fuzz test, but I can't see anything related to fuzzing

I removed the fuzz test due to https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1061894472 and forgot to update the PR description. Updated now, thanks!

💬 1440000bytes commented on issue "Distribute darknet node addresses via DNS seeds using AAAA records":
(https://github.com/bitcoin/bitcoin/issues/31062#issuecomment-2406707660)
Concept NACK

Onion and i2p nodes not dependent on DNS seeds is a feature. It's better if only IPv4 and IPv6 nodes use it.

Maybe we could experiment with [GNS](https://www.gnunet.org/en/gns.html)? Or use this approach for IPv4 nodes with non default port? https://github.com/bitcoin/bitcoin/issues/30900

💬 maflcko commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-2406773729)
I still wonder how useful this is overall. I understand that it is adding a bunch of test-framework code to mimic the functional tests at a lower level and offers a way to write tests this way in C++. However, developers may still prefer to write the tests in Python going forward, because they are used to it, and because it is more flexible, albeit a bit more expensive, because full processes need to be spun up each time. If this is merged, it will add a few redundant test cases (redundant in th
...

📝 omahs opened a pull request: "Fix typos in check-deps.sh"
(https://github.com/bitcoin/bitcoin/pull/31070)
Fix typos in check-deps.sh