💬 theuni commented on pull request "net: fuzz: bypass network magic and checksum validation":
(https://github.com/bitcoin/bitcoin/pull/31012#issuecomment-2403348003)
If we're going to be peppering the code with these, could we add a safety harness to make sure it's never being used accidentally for a live node?

Maybe somewhere in init.cpp or bitcoind.cpp:
```c++
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
exit(1);
#endif
```

💬 ryanofsky commented on issue "Disallow building fuzz binary without `-DBUILD_FOR_FUZZING`":
(https://github.com/bitcoin/bitcoin/issues/31057#issuecomment-2403389988)
I think I'm not clear on what are the drawbacks of the suggestion in https://github.com/bitcoin/bitcoin/issues/31057#issuecomment-2400559220. It seems like that would fix the issues, simplify the build, make meaning of the cmake options clearer.

I also like cory's suggestion of building fuzzing code just as a static library instead of as an executable if it really is not useful for any runtime testing.

> Perhaps there is a third approach that still allows to check for build breakage whil
...

💬 brunoerg commented on pull request "net: fuzz: bypass network magic and checksum validation":
(https://github.com/bitcoin/bitcoin/pull/31012#issuecomment-2403429581)
> If we're going to be peppering the code with these, could we add a safety harness to make sure it's never being used accidentally for a live node?

Seems good. Note that we're already use `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` to bypass `CheckProofOfWork`.

💬 TheCharlatan commented on pull request "refactor: Improve assumeutxo state representation":
(https://github.com/bitcoin/bitcoin/pull/30214#issuecomment-2403433476)
Concept ACK

📝 TheCharlatan opened a pull request: "init: Correct coins db cache size setting"
(https://github.com/bitcoin/bitcoin/pull/31064)
The chainstate caches are currently re-balanced on startup even in the non-assumeutxo case, leading to the database being needlessly re-opened and its cache re-allocated.

Similar to `InitCoinsCache` and `m_coinstip_cache_size_bytes`, the `m_coinsdb_cache_size_bytes` should be set in `InitCoinsDB`.

Together with only conservatively setting the cache values when a assumeutxo chainstate is present, this allows for skipping the cache re-balance during initialization in the normal non-assumeutx
...

💬 gissellestarch commented on something "":
(https://github.com/bitcoin/bitcoin/commit/9bd168bf5457c6fd9770769547d8757bf14813b0#r147777706)
gisselle :)

👍 tdb3 approved a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859#pullrequestreview-2358455238)
ACK c15ef096ce317ae911dd756593adeac9d9a0b5a1

🤔 pablomartin4btc reviewed a pull request: "wallet: optimize migration process, batch db transactions"
(https://github.com/bitcoin/bitcoin/pull/28574#pullrequestreview-2358325707)
ACK a4e1ba722be5dbd71a3d21e5da82aee5409d22bd

<details>
<summary>I've ran the benchmarks locally on SSD and on an external USB 3.2 pendrive and got an improvement of ~46% (i7-1260P, 32GB RAM, Ubuntu 22.04 - using <code>pyperf system tune</code> to get stable results).</summary>

- This PR:

```
./build/src/bench/bench_bitcoin -filter=WalletMigration

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|---
...

💬 pablomartin4btc commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#discussion_r1794235018)
I ran a bench as well calling `GetPubKey()` only once instead of twice as is currently and didn't gain much out of it, code-wise it could be update it for clarity and practicality anyways but I understand this is not part of the code change and moreover if this is going to be entirely replaced by a refactoring on a follow-up.

💬 jonatack commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#discussion_r1794372847)
After [this push](https://github.com/bitcoin/bitcoin/compare/96f4820f1f274ad371aaa37f8247305183e4642c..cd9297c42447f41b95eea6794535a08341f479dd#diff-ec54487d37183db6e158a11eb3560af15758aba1bd7e253c6b3a58ad3ad16e39R13), ISTM that either the following change is now inadvertently missing, or the PR needs a new title.

```diff
-Running `test/functional/test_runner.py` with the `--coverage` argument tracks which RPCs are
+Running `build/test/functional/test_runner.py` (assuming `build` is your bu
...

🤔 jonatack requested changes to a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859#pullrequestreview-2358537498)
After [this push](https://github.com/bitcoin/bitcoin/compare/96f4820f1f274ad371aaa37f8247305183e4642c..cd9297c42447f41b95eea6794535a08341f479dd#diff-ec54487d37183db6e158a11eb3560af15758aba1bd7e253c6b3a58ad3ad16e39R13), ISTM that either the following change is now inadvertently missing, or the PR needs a new title and description.

```diff
--- a/test/functional/README.md
+++ b/test/functional/README.md
@@ -10,7 +10,8 @@ that file and modify to fit your needs.

-Running `test/functional/t
...

🤔 jonatack requested changes to a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859#pullrequestreview-2358542340)
After [this push](https://github.com/bitcoin/bitcoin/compare/96f4820f1f274ad371aaa37f8247305183e4642c..cd9297c42447f41b95eea6794535a08341f479dd#diff-ec54487d37183db6e158a11eb3560af15758aba1bd7e253c6b3a58ad3ad16e39R13), ISTM that the following change is now inadvertently missing.

```diff
--- a/test/functional/README.md
+++ b/test/functional/README.md
@@ -10,7 +10,8 @@ that file and modify to fit your needs.

-Running `test/functional/test_runner.py` with the `--coverage` argument tracks
...

💬 hebasto commented on issue "macOS 13.7 depends build can't find qt":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2403636635)
Could you please test aba02f0c06fdcf28fe76de4cf00dc73c3aee6208 from [this](https://github.com/hebasto/bitcoin/commits/241009-fix31050/) branch?

I have no access to macOS 13.7 (Intel), so not able to test the patch myself.

💬 achow101 commented on pull request "doc: update IBD requirements in doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/30992#issuecomment-2403641132)
ACK 36a6d4b0078ebb39ed082c866bf49214a2a01241

🚀 achow101 merged a pull request: "doc: update IBD requirements in doc/README.md"
(https://github.com/bitcoin/bitcoin/pull/30992)

💬 achow101 commented on pull request "Mining interface: getCoinbaseMerklePath() and submitSolution()":
(https://github.com/bitcoin/bitcoin/pull/30955#issuecomment-2403650915)
ACK 525e9dcba0b8c6744bcd3725864f39786afc8ed5

🚀 achow101 merged a pull request: "Mining interface: getCoinbaseMerklePath() and submitSolution()"
(https://github.com/bitcoin/bitcoin/pull/30955)

💬 Chrcelalles commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2403755135)
Hola saludos desde Argentina

✅ achow101 closed an issue: "Release Schedule for 28.0"
(https://github.com/bitcoin/bitcoin/issues/29891)

⚠️ achow101 unpinned an issue: "Release Schedule for 28.0"
(https://github.com/bitcoin/bitcoin/issues/29891)
Here is a proposed release schedule for `v28.0`, the next major release of Bitcoin Core. The dates are set to target a release in early October as was previously discussed.

## 2024-08-01 :heavy_check_mark:
- Open Transifex translations for `v28.0`
- Soft translation string freeze (no large or non-critical string changes until release)
- Finalize and close translations for `v26.0`

## 2024-08-12 :heavy_check_mark:
- Feature freeze (bug fixes only until release)
- Translation string free
...