💬 theuni commented on pull request "RFC: build: support for pre-compiled headers.":
(https://github.com/bitcoin/bitcoin/pull/31053#issuecomment-2400782077)
Combining with #30911 produces even more of a speedup (with Make, ninja is about the same).

Config: `-DCMAKE_BUILD_TYPE=Debug -DWITH_CCACHE=OFF -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_FUZZ_BINARY=ON -DBUILD_BENCH=ON`
Using: `make -j24`

Master: 2m7.311s
This PR: 1m34.495s
This PR + #30911: 1m19.046s

Result: Completes in 62% of the time compared to master.

💬 TheCharlatan commented on pull request "init: Some small chainstate load improvements":
(https://github.com/bitcoin/bitcoin/pull/31046#issuecomment-2400797758)
Thank you for the reviews @mzumsande and @stickies-v,

Updated 1bec418e77482a4c53c8f1e7c89a151fdeae0f8e -> a7a02b09fafe9d03e5db1fb9d9600f6a13aaa852 ([chainstate_init_followup_0](https://github.com/TheCharlatan/bitcoin/tree/chainstate_init_followup_0) -> [chainstate_init_followup_1](https://github.com/TheCharlatan/bitcoin/tree/chainstate_init_followup_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainstate_init_followup_0..chainstate_init_followup_1))

* Took @stickies-v's [s
...

💬 sdaftuar commented on pull request "cluster mempool: extend DepGraph functionality":
(https://github.com/bitcoin/bitcoin/pull/30857#issuecomment-2400943410)
reACK 0b3ec8c59b2b6d598531cd4e688eb276e597c825

💬 mzumsande commented on pull request "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/29664#issuecomment-2400951708)
> I'm still not sure why it failed, tried to bump a mocktime with the last push, but poking in the dark since it doesn't fail locally for me...

Hopefullly fixed now, I believe that there was a missing sync in the added test.

> Rather than the crude 10 minute timeout - why not actually check if the block is being downloaded from the chosen peer - i.e. work out the throughput and make a decision based on this (compared to typical throughput from other peers)?

I'm not sure what exactly you
...

💬 gburkhow commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#issuecomment-2401046057)
contrib/guix/INSTALL.md maflcko:2409-less-boost

💬 gburkhow commented on pull request "refactor: include the proper header rather than forward-declaring RemovalReasonToString":
(https://github.com/bitcoin/bitcoin/pull/31058#issuecomment-2401047233)
theuni:fix-pch-forward-declare

🚀 achow101 merged a pull request: "scripted-diff: Modernize nLocalServices naming"
(https://github.com/bitcoin/bitcoin/pull/30885)

🤔 pablomartin4btc reviewed a pull request: "bench: add support for custom data directory"
(https://github.com/bitcoin/bitcoin/pull/31000#pullrequestreview-2355854106)
tACK ded1a6cc498ffde0695eb3ee6828b7c513ccc277

<details>
<summary>Tested on Ubuntu 22.04 locally and using an external USB.</summary>

```
./build/src/bench/bench_bitcoin -filter=Xor -testdatadir=/tmp/btc
Warning, results might be unstable:
* DEBUG defined
* CPU frequency scaling enabled: CPU 0 between 400.0 and 4,700.0 MHz
* CPU governor is 'powersave' but should be 'performance'
* Turbo is enabled, CPU frequency will fluctuate

Recommendations
* Make sure you compile for Release
...

💬 VivaRado commented on issue "support BIP39 mnemonic in descriptors":
(https://github.com/bitcoin/bitcoin/issues/19151#issuecomment-2401402365)
Excuse the spam, but here is our implementation of bip39 with UI in JS, that we use for account access control, client and server side with checksum recalculation. https://github.com/VivaRado/BIP39UI

🤔 Imebeez reviewed a pull request: "[28.x] backports and finalize"
(https://github.com/bitcoin/bitcoin/pull/30959#pullrequestreview-2356142508)
N-2

🤔 Imebeez reviewed a pull request: "[26.0] Finalize or rc4"
(https://github.com/bitcoin/bitcoin/pull/28959#pullrequestreview-2356143151)
N-2

🤔 stratospher reviewed a pull request: "Stratum v2 Noise Protocol"
(https://github.com/bitcoin/bitcoin/pull/29346#pullrequestreview-2054783141)
ACK b588ff8. went through the noise protocol spec. also sharing a [pictorial represantion of the NX handshake](https://github.com/stratospher/blogosphere/blob/main/noise.pdf) if it's useful to other reviewers.

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1776344227)
b4a84ab: any reason for skipping 29?

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1791964862)
b588ff8: nit: could move the MixHash log up (after `DecryptAndHash`)and before Validate log for more clarity.

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1791274447)
b588ff8: shouldn't this be "Noise_NX_Secp256k1+EllSwift_ChaChaPoly_SHA256" (from spec)?

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1792116481)
b588ff8: typo - s/ephmeral/ephemeral in a few places.

since the template provider behaves as the server and only performs the responder handshake flow, it might be useful to mention initiator handshake flow is just for tests.

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1792055061)
b588ff8: (micro nit/feel free to ignore) could `return m_cs1.EncryptMessage` to keep it consistent with how it's done in `DecryptMessage`.

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1792872756)
b588ff8: `(valid_from < now) && (valid_to > now)`

💬 stratospher commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1792239111)
d08a2ebf: sv2 is OFF when fuzzing - so we need to turn it ON here to fuzz locally. Also the sv2 fuzz tests aren't run on the CI.

💬 0xB10C commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2401651398)
> Is anyone running this currently with the code set to always enforce or just log? it would be useful to know at what rate nodes are currently seeing unsolicited.

I switched one of my monitoring nodes to run https://github.com/0xB10C/bitcoin/commit/ba39837d999407a55c3784059f7cf07bdbdfce76 to collect some data on this. Having a glance at the logs since yesterday, I've mostly seen the same few peers sending me unsolicited transactions - at a rate of a few per minute.

> I'm particularly inte
...