💬 theuni commented on pull request "RFC: build: support for pre-compiled headers.":
(https://github.com/bitcoin/bitcoin/pull/31053#issuecomment-2397943775)
Ping @hebasto, @fanquake

Also @willcl-ark, you might be interested in this as you've been benchmarking build times.

💬 TheCharlatan commented on pull request "RFC: build: support for pre-compiled headers.":
(https://github.com/bitcoin/bitcoin/pull/31053#issuecomment-2397951718)
Concept ACK

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2397978598)
> Remaining (non nitty) things I think to be addressed:
>
> 1. [refactor: TxDownloadManager + fuzzing #30110 (comment)](https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2391768053)
>
> 2. [refactor: TxDownloadManager + fuzzing #30110 (comment)](https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1787010637)

Yes 👍 and thanks for looking through what happened with the nonstandard input txns @marcofleon @instagibbs! Sorry for the delay, I still need to sit down and
...

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1790920762)
Yeah, need to rework this, it's confusing

💬 Sjors commented on issue "macOS 13.7 depends build can't find qt":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2399035773)
Here's my depends/x86_64-apple-darwin22.6.0/toolchain.cmake

```
# Copyright (c) 2023-present The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or https://opensource.org/license/mit/.

# This file is expected to be highly volatile and may still change substantially.

# If CMAKE_SYSTEM_NAME is set within a toolchain file, CMake will also
# set CMAKE_CROSSCOMPILING to TRUE, even if CMAKE_SYSTEM_NAME matches
# CMAKE_HOST_SYSTEM_
...

⚠️ Sjors opened an issue: "macOS 15.0.1 can't build Qt (Intel, without Xcode)"
(https://github.com/bitcoin/bitcoin/issues/31054)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

`make` in `depends` fails

This is very recent, will try to find an earlier commit where it works.

### Expected behaviour

To work.

### Steps to reproduce

```
cd depends
make NO_WALLET=1 NO_UPNP=1 NO_ZMQ=1
```

### Relevant log output

```
...
Configuring qt...
Creating qmake...
In file included from /Users/sjors/dev/bitcoin2/depends/work/build/x86_64-apple-darwin24.0.0/qt/5.1
...

💬 Sjors commented on issue "macOS 15.0.1 can't build Qt (Intel, without Xcode)":
(https://github.com/bitcoin/bitcoin/issues/31054#issuecomment-2399057050)
It happens even on d71ac768424333b65a6d88c9752cc9c7fdb276f3, so it's not a recent change in the code. Will try some variations with Xcode, etc.

💬 Sjors commented on issue "macOS 15.0.1 can't build Qt (Intel, without Xcode)":
(https://github.com/bitcoin/bitcoin/issues/31054#issuecomment-2399165977)
When I install XCode 16 and build depends for master @ 62e4516722115c2d5aeb6c197abc73ca7c078b23 it's happy.

`brew install llvm` (currently at 19.1.1) does not help. I used:

```
export PATH="$(brew --prefix llvm)/bin:$PATH"
export LDFLAGS="-L$(brew --prefix llvm)/lib"
export CPPFLAGS="-I$(brew --prefix llvm)/include"
```

Doesn't work on d71ac768424333b65a6d88c9752cc9c7fdb276f3 either.

I went back as far as ef20add4c98674183720d9631ac780f9a248b487 and still getting this error.


...

💬 Sjors commented on issue "macOS 13.7 depends build can't find qt":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2399173681)
Ditto on d71ac768424333b65a6d88c9752cc9c7fdb276f3.

📝 TheCharlatan opened a pull request: "doc: Fix README functional test invocation"
(https://github.com/bitcoin/bitcoin/pull/31055)
Seems like this was missed during the cmake migration.

💬 maflcko commented on pull request "doc: Fix README functional test invocation":
(https://github.com/bitcoin/bitcoin/pull/31055#issuecomment-2399195553)
See https://github.com/bitcoin/bitcoin/pull/30859 (doc: cmake: prepend "build" to functional/test_runner.py by LarryRuane)

✅ TheCharlatan closed a pull request: "doc: Fix README functional test invocation"
(https://github.com/bitcoin/bitcoin/pull/31055)

💬 TheCharlatan commented on pull request "doc: Fix README functional test invocation":
(https://github.com/bitcoin/bitcoin/pull/31055#issuecomment-2399203281)
Ah, missed that pull request.

📝 maflcko opened a pull request: "ci: Double ctest timeout"
(https://github.com/bitcoin/bitcoin/pull/31056)
It looks like msan sometimes hits the timeout. So double it, which should still be useful to catch real timeouts in the wine windows-cross unit tests.

Example: https://github.com/bitcoin/bitcoin/runs/31200880897

💬 maflcko commented on issue "win64-cross CI timeout after 2h ":
(https://github.com/bitcoin/bitcoin/issues/30969#issuecomment-2399281998)
The addrman_tests normally take 14 seconds (https://cirrus-ci.com/task/5931376359243776?logs=ci#L2350), so I guess this issue is a duplicate of https://github.com/bitcoin/bitcoin/issues/23357, just that ctest turned the fail into a timeout.

💬 maflcko commented on pull request "ci: Add missing -DWERROR=ON to test-each-commit":
(https://github.com/bitcoin/bitcoin/pull/31045#issuecomment-2399312390)
> you can do `alias nproc="sysctl -n hw.physicalcpu"` instead of installing all of `coreutils`.

No. It needs to be a real executable in `PATH`, otherwise, it won't be picked up in a new shell:

```
$ alias npr=nproc ; type npr ; bash -c 'type npr'
npr is aliased to `nproc'
bash: line 1: type: npr: not found
```

If you disagree, I am happy to push any other commit, which passes CI and achieves the same.

👍 maflcko approved a pull request: "fuzz: Add fuzz-only build mode option for targets"
(https://github.com/bitcoin/bitcoin/pull/31028#pullrequestreview-2353962202)
lgtm

💬 maflcko commented on pull request "fuzz: Add fuzz-only build mode option for targets":
(https://github.com/bitcoin/bitcoin/pull/31028#discussion_r1791549320)
```suggestion
constexpr bool build_for_fuzzing{
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
{true};
#else
{false};
#endif
```

nit: Could rename, so that it can be re-used in the future for other stuff, if needed?

💬 maflcko commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#discussion_r1791551628)
Will change if I have to re-touch

💬 maflcko commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#discussion_r1791551736)
Will change if I have to re-touch