⚠️ ariard opened an issue: "Document CoreDev organization"
(https://github.com/bitcoin/bitcoin/issues/27497)
### Please describe the feature you'd like to see added.

They have been attempts and discussions in the past to document other aspects of project culture such as maintenance with #25560. The organization of in-person events can be itself a source of contention, and I'm speaking here as a former
organizer. While it's voluntary like all other tasks in Bitcoin open-source, there is a lot of subjectivity in the choice of schedule, place and the selection of attendees. Documenting such process will
...

💬 ajtowns commented on pull request "RPC: Accept options as named-only parameters":
(https://github.com/bitcoin/bitcoin/pull/26485#discussion_r1172071849)
I think this should be:

```c++
if (!inner.m_opts.also_positional) {
CHECK_NONFATAL(named_args.insert(inner_name).second);
}
```

Otherwise a duplicate positional parameter after the `OBJ_NAMED_PARAMS` entry will give an error.

🤔 ajtowns reviewed a pull request: "refactor: Move chain constants to the util library"
(https://github.com/bitcoin/bitcoin/pull/27491#pullrequestreview-1393199662)
Would be better if the second commit (renaming `CBaseChainParam::MAIN` to `ChainType::MAIN` etc) could be a scripted-diff. Perhaps structure it as:

* introduce ChainType
* add `CreateBaseChainParams(ChainType)` and replace `CreateBaseChainParams(string)` with `{ auto ct = ChainTypeFromString(chain); if (ct) { return CreateBaseChainParams(ct); } else { throw...; }` (and so on)
* scripted-diff to switch to `ChainType::MAIN` and `args.GetChainType()`
* remove the now unused functions that
...

💬 ajtowns commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1172082054)
Calling it `ChainName(ChainType chain)` might be a bit clearer?

💬 ajtowns commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1172076982)
Put `MAIN` on a newline and just use 4-space indentation? Newlines for `{` and `}` as well, per style guide? Trailing `,` after `REGTEST` in case we add any new ones later?

💬 fanquake commented on pull request "depends: reuse _config_opts for CMake options":
(https://github.com/bitcoin/bitcoin/pull/27496#issuecomment-1515959787)
> Building them with CMake will allow us to drop several deps that we currently have (autoconf, automake, pkg-config, etc) which would be unfortunate to carry over after the switch-over.

I know it's not relevant for this PR, but is the plan to upstream CMake support everywhere it's missing (sqlite, all the qt deps etc), and maintain it ourselves where it's not upstreamable (i.e bdb), otherwise we still can't drop any deps.

🚀 fanquake merged a pull request: "contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`"
(https://github.com/bitcoin/bitcoin/pull/26681)

💬 fanquake commented on pull request "p2p: update hardcoded mainnet seeds for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27488#issuecomment-1515982170)
Needs rebase

💬 bavr2020 commented on pull request "Register `wallet::AddressPurpose` type":
(https://github.com/bitcoin-core/gui/pull/726#issuecomment-1515987477)
****

📝 fanquake locked a pull request: "Register `wallet::AddressPurpose` type"
(https://github.com/bitcoin-core/gui/pull/726)
This PR is a follow up of bitcoin/bitcoin#27217.

Fixes #725.

💬 MarcoFalke commented on issue "test: use-of-uninitialized-value in sqlite3Strlen30":
(https://github.com/bitcoin/bitcoin/issues/27222#issuecomment-1516009197)
Too bad this doesn't easily reproduce outside of the CI env with valgrind. I guess if someone wants to take a look, it might be easiest to fiddle inside the CI env interactively.

💬 glozow commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#issuecomment-1516052330)
linking #9923
perhaps also relevant: #10594, #10051

💬 0xB10C commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1516063771)
Gave this another look. No luck with `rr` and haven't been able to reproduce this locally or in the CI.

💬 MarcoFalke commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1516070517)
Maybe it will "fix itself" after https://github.com/bitcoin/bitcoin/pull/27360 ?

📝 MarcoFalke opened a pull request: "test: Remove unused signed-integer-overflow suppression"
(https://github.com/bitcoin/bitcoin/pull/27498)

💬 bavr2020 commented on pull request "contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#issuecomment-1516076645)
> Contri

💬 dergoegge commented on pull request "kernel: chainparams updates for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27482#issuecomment-1516080565)
ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81 on the new mainnet params

🚀 fanquake merged a pull request: "kernel: chainparams updates for 25.x"
(https://github.com/bitcoin/bitcoin/pull/27482)

💬 pinheadmz commented on issue "Document CoreDev organization":
(https://github.com/bitcoin/bitcoin/issues/27497#issuecomment-1516116823)
I don't think a project software bug tracker is the right place to discuss this.

💬 hebasto commented on pull request "test: Remove unused signed-integer-overflow suppression":
(https://github.com/bitcoin/bitcoin/pull/27498#discussion_r1172435340)
> was fixed in gcc-11 and later.

Mind pointing at the actual fix if it is known?