Bitcoin Core Github
44 subscribers
120K links
Download Telegram
🤔 promag reviewed a pull request: "qt6: Handle different signatures of `QANEF::nativeEventFilter`"
(https://github.com/bitcoin-core/gui/pull/840#pullrequestreview-2349357223)
I think small changes to make code compatible with both versions are fine until support for qt5 is dropped.

Code review ACK 80761afced12c774a1768fb27a3975d456981ae0.

Alternative is to use type alias
```cpp
#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
using result_t = qintptr*;
#else
using result_t = long*;
#endif
💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2394777591)
Guix builds for the recent push:
- `aarch64`:
```
ad3093fa02114e2ec80b54312ff0df232893dc73395630c3d7fdb34d7fe79d83 guix-build-b0322c462106/output/aarch64-linux-gnu/SHA256SUMS.part
d0b95a6538bb8ad217dcbf6cf481d9849d8a9b0c40ca18717cd3594087a5a5a5 guix-build-b0322c462106/output/aarch64-linux-gnu/bitcoin-b0322c462106-aarch64-linux-gnu-debug.tar.gz
d85f9ce2e9ffb310d55fcc4b9755a52d33935bb742f460fc7b6b74b61bad35a3 guix-build-b0322c462106/output/aarch64-linux-gnu/bitcoin-b0322c462106-aarch64-lin
...
🤔 promag reviewed a pull request: "Fix display issues for IPv6 proxy setup in Options Dialog (UI only, no functionality impact)"
(https://github.com/bitcoin-core/gui/pull/836#pullrequestreview-2349362315)
Code review ACK fee4cba48472239f7a426db62f45c4b6af8e5ef2.
📝 achow101 opened a pull request: "[28.x] doc: Sync 28.0 release notes with website"
(https://github.com/bitcoin/bitcoin/pull/31034)
Since there were some changes to the release notes after the tagging, update the in branch release notes to match those that ended up on the website.
📝 achow101 opened a pull request: "doc: Archive 28.0 release notes"
(https://github.com/bitcoin/bitcoin/pull/31035)
Matches the release notes on the website.
💬 achow101 commented on pull request "descriptor: Add proper Clone function to miniscript::Node":
(https://github.com/bitcoin/bitcoin/pull/30866#discussion_r1788418189)
It's not strictly necessary but I decided to do it this way to follow the pattern used for all other descriptors. The multipath expanded descriptors are treated as separate descriptors everywhere, and doing a deep copy retains that behavior which will allow for future changes that may modify specific descriptors.
⚠️ vasild opened an issue: "Listen on random port by default (not 8333)"
(https://github.com/bitcoin/bitcoin/issues/31036)
### Please describe the feature you'd like to see added.

Connections to port 8333 can be recognized right away as Bitcoin P2P connections. While it is still possible to recognize Bitcoin P2P connections regardless of the port, random ports would make network-wide monitoring harder.


### Is your feature related to a problem, if so please describe it.

Network-wide monitoring.

### Describe the solution you'd like

The listening address and port of a node are propagated and saved in other nodes
...
💬 vasild commented on issue "Prioritize processing of peers based on their CPU usage":
(https://github.com/bitcoin/bitcoin/issues/31033#issuecomment-2394932171)
Good questions that I do not have an answer to.

I guess this should start with planting some metrics - CPU time used by each peer in the last 1, 5 and 15 minutes and assessing what a "usual" situation looks like.

Specific to CPU DoS via invalid transactions: for peers that send us such transactions, maybe multiply the CPU time by a factor e.g. 10x or 100x. Or the other way around - nullify CPU time spend on definitely-good-and-positive things like new blocks or new transactions that we acc
...
💬 azazar commented on issue "[Testnet] Insufficient data or no feerate found":
(https://github.com/bitcoin/bitcoin/issues/31032#issuecomment-2394951796)
The Testnet is becoming more frustrating. Testnet coins are nearly impossible to get without an ASIC, and now sending them has become a hassle too.
💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2394960152)
@hebasto can you try compiling yourself, including the qt wallet
💬 laanwj commented on pull request "doc: Archive 28.0 release notes":
(https://github.com/bitcoin/bitcoin/pull/31035#issuecomment-2394995331)
Does not exactly match the release notes on the v28.0 tag:
```
git diff f019fcec4126aa2618734016711063d3b44260fc:doc/release-notes/release-notes-28.0.md v28.0:doc/release-notes.md | wc
333
```
It does match the one on the website, minus Jekyll metadata wrapping and two EOL space differences.

ACK f019fcec4126aa2618734016711063d3b44260fc
💬 Sjors commented on pull request "Add multiprocess binaries to release build":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2395041597)
Added a commit to enable multiprocess on more CI environments.
💬 pinheadmz commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2395054359)
I'm getting the same error but inside a guix build: https://gist.github.com/pinheadmz/a2603f7f62c7627f33a10d8f39443f20
💬 pinheadmz commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2395065939)
Update: re-downloaded Xcode and re-extracted the SDK, guix build is proceeding again
👍 tdb3 approved a pull request: "[28.x] doc: Sync 28.0 release notes with website"
(https://github.com/bitcoin/bitcoin/pull/31034#pullrequestreview-2349595994)
ACK 89d34cffedcb6ec752fa2ca355ad32e1e413b2f0

Release notes in #31034 and #31035 match
git diff 89d34cffedcb6ec752fa2ca355ad32e1e413b2f0:doc/release-notes.md f019fcec4126aa2618734016711063d3b44260fc:doc/release-notes/release-notes-28.0.md
👍 tdb3 approved a pull request: "doc: Archive 28.0 release notes"
(https://github.com/bitcoin/bitcoin/pull/31035#pullrequestreview-2349596049)
ACK f019fcec4126aa2618734016711063d3b44260fc

Release notes in #31034 and #31035 match
git diff 89d34cffedcb6ec752fa2ca355ad32e1e413b2f0:doc/release-notes.md f019fcec4126aa2618734016711063d3b44260fc:doc/release-notes/release-notes-28.0.md
🚀 achow101 merged a pull request: "doc: Archive 28.0 release notes"
(https://github.com/bitcoin/bitcoin/pull/31035)
🚀 achow101 merged a pull request: "[28.x] doc: Sync 28.0 release notes with website"
(https://github.com/bitcoin/bitcoin/pull/31034)
🚀 glozow merged a pull request: "rpc: add getorphantxs"
(https://github.com/bitcoin/bitcoin/pull/30793)
💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2395092244)
I just pushed from 114a5405c41 to 693a1d079ea for this review https://github.com/bitcoin/bitcoin/pull/30110#pullrequestreview-2343039535
I'll push again to address the silent merge conflict, and also address https://github.com/bitcoin/bitcoin/pull/30110#pullrequestreview-2342669240